Uh oh!
There was an error while loading. Please reload this page.
Trim extra space when suggesting removing bad let - #132996
Merged
Merged
Conversation
rustbot
commented
Nov 13, 2024
Collaborator
r? @chenyukang rustbot has assigned @chenyukang. Use |
clubby789force-pushed
the
unn-let-space
branch
from
November 13, 2024 13:19
d9df3eb to
1136bbfComparejieyouxu
approved these changes
Nov 13, 2024
jieyouxu
left a comment
Member
There was a problem hiding this comment.
Thanks, you can r=me after PR CI is green.
clubby789
commented
Nov 13, 2024
ContributorAuthor
@bors r=jieyouxu rollup |
bors
commented
Nov 13, 2024
Collaborator
Comment on lines
27
to
+28
| LL | let 1 => {} | ||
| | ^^^ | ||
| | ^^^^ |
Contributor
There was a problem hiding this comment.
Ideally we'd modify RemoveLet to have two separate spans, one for the let and another for the let removal suggestion so that the primary span doesn't point at unnecessary whitespace. We can address that as follow up.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 14, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#126046 (Implement `mixed_integer_ops_unsigned_sub`) - rust-lang#132302 (rustdoc: Treat declarative macros more like other item kinds) - rust-lang#132842 (ABI checks: add support for tier2 arches) - rust-lang#132995 (compiletest: Add ``exact-llvm-major-version`` directive) - rust-lang#132996 (Trim extra space when suggesting removing bad `let`) - rust-lang#132998 (Unvacation myself) - rust-lang#133000 ([rustdoc] Fix duplicated footnote IDs) - rust-lang#133001 (actually test next solver) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 14, 2024
Rollup merge of rust-lang#132996 - clubby789:unn-let-space, r=jieyouxu Trim extra space when suggesting removing bad `let` Fixesrust-lang#132969
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#132969