Skip to content

Add FileCheck annotations to mir-opt/copy-prop - #135099

Merged
bors merged 14 commits into
rust-lang:masterfrom
Shunpoco:116971-mir-opt-copy-prop
Nov 3, 2025
Merged

Add FileCheck annotations to mir-opt/copy-prop#135099
bors merged 14 commits into
rust-lang:masterfrom
Shunpoco:116971-mir-opt-copy-prop

Conversation

@Shunpoco

@ShunpocoShunpoco commented Jan 4, 2025

Copy link
Copy Markdown
Contributor

This resolves a part of #116971 .

This PR adds FileCheck annotations to test files under mir-opt/copy-prop.

@rustbot

rustbot commented Jan 4, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2025
Shunpoco
Shunpoco commented Jan 4, 2025
View reviewed changes
Comment threadtests/mir-opt/copy-prop/copy_propagation_arg.rs
Shunpoco
Shunpoco commented Jan 4, 2025
View reviewed changes
Comment threadtests/mir-opt/copy-prop/partial_init.rs
@Shunpoco
Shunpoco marked this pull request as ready for review January 4, 2025 13:16
@Shunpoco

Shunpoco commented Jan 4, 2025

Copy link
Copy Markdown
ContributorAuthor

r? @cjgillot

cjgillot
cjgillot reviewed Jan 8, 2025
View reviewed changes

@cjgillotcjgillot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great work. A few nits.

Comment threadtests/mir-opt/copy-prop/calls.rs
Comment threadtests/mir-opt/copy-prop/calls.rs
Comment threadtests/mir-opt/copy-prop/copy_propagation_arg.rs
Comment threadtests/mir-opt/copy-prop/cycle.rs Outdated
Comment threadtests/mir-opt/copy-prop/dead_stores_better.rs Outdated
Comment threadtests/mir-opt/copy-prop/issue_107511.rs Outdated
Comment threadtests/mir-opt/copy-prop/move_projection.rs Outdated
Comment threadtests/mir-opt/copy-prop/partial_init.rs
@apiraino

apiraino commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

r? compiler

@rustbotrustbot assigned BoxyUwU and unassigned cjgillotApr 8, 2025
@BoxyUwU

BoxyUwU commented Apr 8, 2025

Copy link
Copy Markdown
Member

r? @jieyouxu
weird test stuff

@rustbotrustbot assigned jieyouxu and unassigned BoxyUwUApr 8, 2025
jieyouxu
jieyouxu reviewed Apr 8, 2025
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FileCheck annotations syntactically look okay but I don't know mir-opts well so rerolling a mir-opt reviewer.

@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
Member

r? mir-opt

@rustbotrustbot assigned wesleywiser and unassigned jieyouxuApr 8, 2025
@jieyouxujieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc A-mir-opt Area: MIR optimizations labels Apr 8, 2025
wesleywiser
wesleywiser reviewed Apr 18, 2025
View reviewed changes
Comment threadtests/mir-opt/copy-prop/dead_stores_better.rs Outdated
@wesleywiser

wesleywiser commented Oct 16, 2025

Copy link
Copy Markdown
Member

r? rust-lang/compiler

@rustbotrustbot assigned davidtwco and unassigned wesleywiserOct 16, 2025
davidtwco
davidtwco approved these changes Oct 25, 2025
View reviewed changes

@davidtwcodavidtwco left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, replied to another review comment then r=me

View changes since this review

@Shunpoco
Shunpocoforce-pushed the 116971-mir-opt-copy-prop branch from 7a64137 to b30493bCompareOctober 26, 2025 10:38
@rustbot

rustbot commented Oct 26, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jieyouxu

jieyouxu commented Oct 26, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Can you please squash or otherwise reorganize the commits a bit? 20+ commits seems unnecessary.

@Shunpoco
Shunpocoforce-pushed the 116971-mir-opt-copy-prop branch from b30493b to 620b9b1CompareOctober 26, 2025 10:59
@davidtwco

davidtwco commented Nov 3, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 620b9b1 has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 3, 2025
Merged
bors added a commit that referenced this pull request Nov 3, 2025
@bors
Auto merge of#148446- GuillaumeGomez:rollup-lxwlqol, r=GuillaumeGomez
1f880d9
Rollup of 8 pull requests
Successful merges:
- #135099 (Add FileCheck annotations to mir-opt/copy-prop)
- #145903 (Give correct suggestion for a typo in raw pointers)
- #147520 (Port the remaining SIMD intrinsics to const-eval)
- #148068 (rustdoc: Use configured target modifiers when collecting doctests)
- #148099 (Prepare to move debugger discovery from compiletest to bootstrap)
- #148268 (rustdoc: fix `--emit=dep-info` on scraped examples)
- #148306 (Remove double check when decoding ExpnId to avoid races)
- #148378 (Fix documentation for std::panic::update_hook)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit c97bde7 into rust-lang:masterNov 3, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 3, 2025
rust-timer added a commit that referenced this pull request Nov 3, 2025
@rust-timer
Unrolled build for#135099
e096d76
Rollup merge of #135099 - Shunpoco:116971-mir-opt-copy-prop, r=davidtwco
Add FileCheck annotations to mir-opt/copy-prop
This resolves a part of #116971 .
This PR adds FileCheck annotations to test files under mir-opt/copy-prop.
@Shunpoco
Shunpoco deleted the 116971-mir-opt-copy-prop branch November 3, 2025 19:55
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148446 - GuillaumeGomez:rollup-lxwlqol, r=GuillaumeGomez
a2f0023
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#135099 (Add FileCheck annotations to mir-opt/copy-prop)
- rust-lang/rust#145903 (Give correct suggestion for a typo in raw pointers)
- rust-lang/rust#147520 (Port the remaining SIMD intrinsics to const-eval)
- rust-lang/rust#148068 (rustdoc: Use configured target modifiers when collecting doctests)
- rust-lang/rust#148099 (Prepare to move debugger discovery from compiletest to bootstrap)
- rust-lang/rust#148268 (rustdoc: fix `--emit=dep-info` on scraped examples)
- rust-lang/rust#148306 (Remove double check when decoding ExpnId to avoid races)
- rust-lang/rust#148378 (Fix documentation for std::panic::update_hook)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge ofrust-lang#148446- GuillaumeGomez:rollup-lxwlqol, r=Gui…
04535f2
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#135099 (Add FileCheck annotations to mir-opt/copy-prop)
- rust-lang#145903 (Give correct suggestion for a typo in raw pointers)
- rust-lang#147520 (Port the remaining SIMD intrinsics to const-eval)
- rust-lang#148068 (rustdoc: Use configured target modifiers when collecting doctests)
- rust-lang#148099 (Prepare to move debugger discovery from compiletest to bootstrap)
- rust-lang#148268 (rustdoc: fix `--emit=dep-info` on scraped examples)
- rust-lang#148306 (Remove double check when decoding ExpnId to avoid races)
- rust-lang#148378 (Fix documentation for std::panic::update_hook)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser left review comments
@cjgillotcjgillotcjgillot left review comments
@jieyouxujieyouxujieyouxu left review comments
@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

A-mir-optArea: MIR optimizationsA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

10 participants

@Shunpoco@rustbot@apiraino@BoxyUwU@jieyouxu@wesleywiser@davidtwco@bors@cjgillot@Mark-Simulacrum