Rollup of 8 pull requests by GuillaumeGomez · Pull Request #148446 · rust-lang/rust

GuillaumeGomez · 2025-11-03T16:20:39Z

Successful merges:

Add FileCheck annotations to mir-opt/copy-prop #135099 (Add FileCheck annotations to mir-opt/copy-prop)
Give correct suggestion for a typo in raw pointers #145903 (Give correct suggestion for a typo in raw pointers)
Port the remaining SIMD intrinsics to const-eval #147520 (Port the remaining SIMD intrinsics to const-eval)
rustdoc: Use configured target modifiers when collecting doctests #148068 (rustdoc: Use configured target modifiers when collecting doctests)
Prepare to move debugger discovery from compiletest to bootstrap #148099 (Prepare to move debugger discovery from compiletest to bootstrap)
rustdoc: fix --emit=dep-info on scraped examples #148268 (rustdoc: fix --emit=dep-info on scraped examples)
Remove double check when decoding ExpnId to avoid races #148306 (Remove double check when decoding ExpnId to avoid races)
Fix documentation for std::panic::update_hook #148378 (Fix documentation for std::panic::update_hook)

r? @ghost
@rustbot modify labels: rollup

As we discussed, it is identical with dead_stores_79191

* `set_hook` expects a boxed function * Missing closing delimiter for the closure

To support loading dependencies with target modifiers and avoid ABI mismatch errors.

… r=davidtwco Add FileCheck annotations to mir-opt/copy-prop This resolves a part of rust-lang#116971 . This PR adds FileCheck annotations to test files under mir-opt/copy-prop.

Give correct suggestion for a typo in raw pointers This adds a check for when user wrote `const* T` instead of `*const T`, I just saw how a C-person made this typo and compiler suggests this ```rust --> src/main.rs:2:17 | 2 | let p: const* u8 = 0 as _; | ^ | help: add `mut` or `const` here | 2 | let p: const*mut u8 = 0 as _; | +++ 2 | let p: const*const u8 = 0 as _; | +++++ ``` which is very incorrect also fixesrust-lang#136602 r? compiler

…=GuillaumeGomez rustdoc: fix `--emit=dep-info` on scraped examples Makes sure both stages (the scraping process itself, and the doc build) emit complete dependency lists. CC rust-lang#146220 Part of rust-lang#83784

…hercote Remove double check when decoding ExpnId to avoid races Fixes debug assertion failure as described in rust-lang#141540 (comment) Essentially failure happens during the race while decoding one `ExpnId` from different threads. This ICE doesn't happen with single threaded thread_pool due to early return within `decode_expn_id` with the same condition: https://github.com/rust-lang/rust/blob/8205e6b75ec656305ac235d4726d2c7a1ddcef14/compiler/rustc_middle/src/query/on_disk_cache.rs#L605-L607 However I believe this race does not hurt because `register_expn_id` is pretty much idempotent: https://github.com/rust-lang/rust/blob/8205e6b75ec656305ac235d4726d2c7a1ddcef14/compiler/rustc_span/src/hygiene.rs#L1397-L1413

Fix documentation for std::panic::update_hook The equivalent code given in the documentation of `std::panic::update_hook`[^1] does not compile: * `set_hook` expects a boxed function * Missing closing delimiter for the closure [^1]: rust-lang#92649

GuillaumeGomez · 2025-11-03T16:20:55Z

@bors r+ p=5 rollup=never

bors · 2025-11-03T16:20:58Z

📌 Commit 871692a has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-11-03T16:30:04Z

⌛ Testing commit 871692a with merge 1f880d9...

bors · 2025-11-03T19:35:31Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 1f880d9 to master...

rust-timer · 2025-11-03T19:37:53Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#135099	Add FileCheck annotations to mir-opt/copy-prop	`e096d769a57570506b50ee1a4ca5b75f45c57026` (link)
#145903	Give correct suggestion for a typo in raw pointers	`9b058ff4851713ad962c8612865f51b694494b0f` (link)
#147520	Port the remaining SIMD intrinsics to const-eval	`c3188094cb75407d90fe1309ec224f594e83906d` (link)
#148068	rustdoc: Use configured target modifiers when collecting do…	`2536bfc814873862f2239462c3878d64442ed322` (link)
#148099	Prepare to move debugger discovery from compiletest to boot…	`93f1495d52944a58cb3a3a8835db5cb112346a46` (link)
#148268	rustdoc: fix `--emit=dep-info` on scraped examples	`e61cede09ead0fb87f1259b8aee5769ce845bc28` (link)
#148306	Remove double check when decoding ExpnId to avoid races	`560590ee8231a0ce8e842b8d1d15859e49115a81` (link)
#148378	Fix documentation for std::panic::update_hook	`98f35d43ee4dce69e30b1dcf5fb7fa64789ec0cf` (link)

previous master: f5711a55f5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-03T19:38:36Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f5711a5 (parent) -> 1f880d9 (this PR)

Test differences

Show 15 test diffs

Stage 1

[mir-opt] tests/mir-opt/copy-prop/dead_stores_better.rs: pass -> [missing] (J2)
[run-make] tests/run-make/rustdoc-scrape-examples-dep-info: [missing] -> pass (J2)
[ui] tests/ui/did_you_mean/c-style-pointer-types.rs: [missing] -> pass (J2)

Stage 2

[run-make] tests/run-make/rustdoc-scrape-examples-dep-info: [missing] -> pass (J0)
[mir-opt] tests/mir-opt/copy-prop/dead_stores_better.rs: pass -> [missing] (J1)
[ui] tests/ui/did_you_mean/c-style-pointer-types.rs: [missing] -> pass (J3)
[run-make] tests/run-make/rustdoc-scrape-examples-dep-info: [missing] -> ignore (ignored if target does not support std) (J4)

Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1f880d9a1f4a331f1873829401e9d35fcfab2e36 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 8527.7s -> 10260.3s (+20.3%)
pr-check-1: 1456.2s -> 1710.1s (+17.4%)
x86_64-gnu-gcc: 2812.3s -> 3270.3s (+16.3%)
x86_64-gnu-llvm-21-2: 5170.5s -> 5844.2s (+13.0%)
dist-x86_64-apple: 7967.7s -> 8930.9s (+12.1%)
dist-aarch64-msvc: 5571.9s -> 6241.1s (+12.0%)
dist-i586-gnu-i586-i686-musl: 5570.8s -> 4944.9s (-11.2%)
dist-powerpc64-linux: 5113.9s -> 5682.5s (+11.1%)
dist-ohos-armv7: 3891.6s -> 4316.5s (+10.9%)
x86_64-gnu-nopt: 7488.4s -> 6686.2s (-10.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-04T13:41:26Z

Finished benchmarking commit (1f880d9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-4.1%, -2.0%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.205s -> 474.478s (0.06%)
Artifact size: 390.90 MiB -> 390.89 MiB (-0.00%)

…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#135099 (Add FileCheck annotations to mir-opt/copy-prop) - rust-lang#145903 (Give correct suggestion for a typo in raw pointers) - rust-lang#147520 (Port the remaining SIMD intrinsics to const-eval) - rust-lang#148068 (rustdoc: Use configured target modifiers when collecting doctests) - rust-lang#148099 (Prepare to move debugger discovery from compiletest to bootstrap) - rust-lang#148268 (rustdoc: fix `--emit=dep-info` on scraped examples) - rust-lang#148306 (Remove double check when decoding ExpnId to avoid races) - rust-lang#148378 (Fix documentation for std::panic::update_hook) r? `@ghost` `@rustbot` modify labels: rollup

Kivooeoand others added 30 commits October 25, 2025 19:20

add parser check for pointer typo
ea96b79

Add FileCheck to branch.rs
e36689a

Add FileCheck to calls.rs
3b1e20c

Add FileCheck to copy_propagation_arg.rs
c204231

Add FileCheck to custom_move_arg.rs
17b0d90

Add FileCheck to cycle.rs
ff260c8

Add FileCheck to dead_stores_79191.rs
109870d

remove dead_stores_better.rs
76dc555
As we discussed, it is identical with dead_stores_79191

Add FileCheck to issue_107511.rs
dd2d390

Add FileCheck to move_arg.rs
13e971e

Add FileCheck to move_projection.rs
3d12668

Add FileCheck to mutate_through_pointer.rs
6eaf4fe

Add FileCheck to non_dominate.rs
aa83f17

Add FileCheck to partial_init.rs
8ae4d57

Add FileCheck to reborrow.rs
620b9b1

Implement simd_fma and simd_relaxed_fma in const-eval
c4d6b0b

rustdoc: fix --emit=dep-info on scraped examples
8611f0b

Do not double check for already decoded expn_id to avoid races
2a5d830

Fix test on Windows
65aed3b

Separate debugger discovery from debugger version-query
2044a5f

Only pass debugger-related flags for debuginfo tests
e9f3603

Extract some discovery code for debuginfo tests into submodules
bcfbd74

Fix documentation for std::panic::update_hook
b9e127a
* `set_hook` expects a boxed function * Missing closing delimiter for the closure

Refactor implementation of float minmax intrinsics
d335ea9

Refactor float rounding intrinsics a bit
ebf2e10

Add some missing f16-f128 support in intrinsics
4d70bf4

Add Miri tests for f16/f128 SIMD operations
0681bae

rustdoc: Use configured target modifiers when collecting doctests
accd1fe
To support loading dependencies with target modifiers and avoid ABI mismatch errors.

Rollup merge ofrust-lang#135099- Shunpoco:116971-mir-opt-copy-prop,…
c97bde7
… r=davidtwco Add FileCheck annotations to mir-opt/copy-prop This resolves a part of rust-lang#116971 . This PR adds FileCheck annotations to test files under mir-opt/copy-prop.

GuillaumeGomez added 3 commits November 3, 2025 17:20

Rollup merge ofrust-lang#148268- notriddle:emit-scraped-examples, r…
4f266bd
…=GuillaumeGomez rustdoc: fix `--emit=dep-info` on scraped examples Makes sure both stages (the scraping process itself, and the doc build) emit complete dependency lists. CC rust-lang#146220 Part of rust-lang#83784

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025

bors mentioned this pull request Nov 3, 2025
Add LLVM range attributes to slice length parameters #148350
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 3, 2025

bors merged commit 1f880d9 into rust-lang:masterNov 3, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 3, 2025

GuillaumeGomez deleted the rollup-lxwlqol branch November 3, 2025 19:40

This was referenced Nov 3, 2025
Add alignment parameter to simd_masked_{load,store}#147355
Merged
Implement SIMD funnel shifts in const-eval/Miri #147534
Merged
Turn moves into copies after copy propagation #147804
Merged

Navigation Menu

Uh oh!

Uh oh!

Rollup of 8 pull requests - #148446

Rollup of 8 pull requests#148446
bors merged 36 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup-lxwlqol

GuillaumeGomez commented Nov 3, 2025•
edited by rustbot
Loading

Uh oh!

GuillaumeGomez commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 3, 2025

Uh oh!

github-actionsBot commented Nov 3, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Nov 3, 2025• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 3, 2025

Uh oh!

github-actionsBot commented Nov 3, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 4, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

GuillaumeGomez commented Nov 3, 2025•
edited by rustbot
Loading