Skip to content

Give correct suggestion for a typo in raw pointers - #145903

Merged
bors merged 1 commit into
rust-lang:masterfrom
Kivooeo:c-style-pointer
Nov 3, 2025
Merged

Give correct suggestion for a typo in raw pointers#145903
bors merged 1 commit into
rust-lang:masterfrom
Kivooeo:c-style-pointer

Conversation

@Kivooeo

@KivooeoKivooeo commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown
Member

This adds a check for when user wrote const* T instead of *const T, I just saw how a C-person made this typo and compiler suggests this

 --> src/main.rs:2:17
|
2 | let p:const* u8 = 0as_;
| ^
|
help: add `mut` or `const` here
|
2 | let p:const*mut u8 = 0as_;
| +++
2 | let p:const*const u8 = 0as_;
| +++++

which is very incorrect

also fixes#136602

r? compiler

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 26, 2025
compiler-errors
compiler-errors suggested changes Aug 27, 2025
View reviewed changes
Comment threadcompiler/rustc_parse/src/parser/ty.rs Outdated
Comment threadcompiler/rustc_parse/src/parser/ty.rs Outdated
Comment threadcompiler/rustc_parse/src/parser/ty.rs Outdated
Comment threadcompiler/rustc_parse/src/parser/ty.rs Outdated
Comment threadcompiler/rustc_parse/src/parser/ty.rs Outdated
Comment threadcompiler/rustc_parse/src/parser/ty.rs Outdated
Comment threadcompiler/rustc_parse/src/parser/ty.rs Outdated
let allow_qpath_recovery = recover_qpath == RecoverQPath::Yes;
maybe_recover_from_interpolated_ty_qpath!(self, allow_qpath_recovery);

if (self.token.is_keyword(kw::Const) || self.token.is_keyword(kw::Mut))

@compiler-errorscompiler-errorsAug 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should also be moved into a separate function and also moved way down into the actually if else chain below rather than being hit first on every call to parse_ty_common

@KivooeoKivooeoAug 27, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was made exactly like attribute parsing in types right below, this why I originally chose this place and this strategy

About snapshoting I'm not fully sure I can and should use it here, not only because I fully know how and why it should be used, I checked other places where snapshotting was used and it mostly like in Err branch of match which I don't use

About eating Star it looks correct for me here even if we know that here is Star 100% beacuse we checked it in if, but if there any other way more better way to do I'm in full ears, but honestly I dont personally like this if branch here because of unreachable!, so yeah, should be a better way to do it,

I also adressed a wording problem, new one should be more straighforward and clear for end user

And I made a recovery as a TyKind::Ptr, agree that this is better generally

Also about lookahead(2) or can_begin_type I'm not quite sure why we need it, I'm parsing type in if with parse_ty_no_question_mark_recover to create a TyKind::Ptr from it, and if there will be no type at all it should fail earlier with a different error

@compiler-errorscompiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025
@Kivooeo

Kivooeo commented Aug 27, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2025
@rustbot

rustbot commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

@fmeasefmease assigned fmease and unassigned wesleywiserOct 13, 2025
@Kivooeo

Kivooeo commented Oct 24, 2025

Copy link
Copy Markdown
MemberAuthor

r? compiler

@rustbotrustbot assigned davidtwco and unassigned fmeaseOct 24, 2025
davidtwco
davidtwco reviewed Oct 25, 2025
View reviewed changes
Comment threadcompiler/rustc_parse/src/parser/ty.rs Outdated
@davidtwco

davidtwco commented Nov 3, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit ea96b79 has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 3, 2025
Merged
bors added a commit that referenced this pull request Nov 3, 2025
@bors
Auto merge of#148446- GuillaumeGomez:rollup-lxwlqol, r=GuillaumeGomez
1f880d9
Rollup of 8 pull requests
Successful merges:
- #135099 (Add FileCheck annotations to mir-opt/copy-prop)
- #145903 (Give correct suggestion for a typo in raw pointers)
- #147520 (Port the remaining SIMD intrinsics to const-eval)
- #148068 (rustdoc: Use configured target modifiers when collecting doctests)
- #148099 (Prepare to move debugger discovery from compiletest to bootstrap)
- #148268 (rustdoc: fix `--emit=dep-info` on scraped examples)
- #148306 (Remove double check when decoding ExpnId to avoid races)
- #148378 (Fix documentation for std::panic::update_hook)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 8482454 into rust-lang:masterNov 3, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 3, 2025
rust-timer added a commit that referenced this pull request Nov 3, 2025
@rust-timer
Unrolled build for#145903
9b058ff
Rollup merge of #145903 - Kivooeo:c-style-pointer, r=davidtwco
Give correct suggestion for a typo in raw pointers
This adds a check for when user wrote `const* T` instead of `*const T`, I just saw how a C-person made this typo and compiler suggests this
```rust
--> src/main.rs:2:17
|
2 | let p: const* u8 = 0 as _;
| ^
|
help: add `mut` or `const` here
|
2 | let p: const*mut u8 = 0 as _;
| +++
2 | let p: const*const u8 = 0 as _;
| +++++
```
which is very incorrect
also fixes#136602
r? compiler
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148446 - GuillaumeGomez:rollup-lxwlqol, r=GuillaumeGomez
a2f0023
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#135099 (Add FileCheck annotations to mir-opt/copy-prop)
- rust-lang/rust#145903 (Give correct suggestion for a typo in raw pointers)
- rust-lang/rust#147520 (Port the remaining SIMD intrinsics to const-eval)
- rust-lang/rust#148068 (rustdoc: Use configured target modifiers when collecting doctests)
- rust-lang/rust#148099 (Prepare to move debugger discovery from compiletest to bootstrap)
- rust-lang/rust#148268 (rustdoc: fix `--emit=dep-info` on scraped examples)
- rust-lang/rust#148306 (Remove double check when decoding ExpnId to avoid races)
- rust-lang/rust#148378 (Fix documentation for std::panic::update_hook)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge ofrust-lang#148446- GuillaumeGomez:rollup-lxwlqol, r=Gui…
04535f2
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#135099 (Add FileCheck annotations to mir-opt/copy-prop)
- rust-lang#145903 (Give correct suggestion for a typo in raw pointers)
- rust-lang#147520 (Port the remaining SIMD intrinsics to const-eval)
- rust-lang#148068 (rustdoc: Use configured target modifiers when collecting doctests)
- rust-lang#148099 (Prepare to move debugger discovery from compiletest to bootstrap)
- rust-lang#148268 (rustdoc: fix `--emit=dep-info` on scraped examples)
- rust-lang#148306 (Remove double check when decoding ExpnId to avoid races)
- rust-lang#148378 (Fix documentation for std::panic::update_hook)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes
+1 more reviewer
@compiler-errorscompiler-errorscompiler-errors requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@davidtwcodavidtwco

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

const* suggestions won't compile, and no suggestion for *const

7 participants

@Kivooeo@rustbot@davidtwco@bors@compiler-errors@wesleywiser@fmease