Uh oh!
There was an error while loading. Please reload this page.
mk: Change windows to install from stage2 - #13518
Closed
alexcrichton wants to merge 1 commit into
Closed
Conversation
In the past, windows was installed from stage3 to guarantee convergence between the host and target artifacts, but syntax extensions on all platforms are currently relying on convergence, so special casing this one platform has become less relevant over time. This will also have the added benefit of dealing with rust-lang#13474 and rust-lang#13491. These issues will be closed after next next nightly is confirmed to fix them.
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 16, 2014
Closesrust-lang#13546 (workcache: Don't assume gcc exists on all platforms) Closesrust-lang#13545 (std: Remove pub use globs) Closesrust-lang#13530 (test: Un-ignore smallest-hello-world.rs) Closesrust-lang#13529 (std: Un-ignore some float tests on windows) Closesrust-lang#13528 (green: Add a helper macro for booting libgreen) Closesrust-lang#13526 (Remove RUST_LOG="::help" from the docs) Closesrust-lang#13524 (dist: Make Windows installer uninstall first. Closesrust-lang#9563) Closesrust-lang#13521 (Change AUTHORS section in the man pages) Closesrust-lang#13519 (Update GitHub's Rust projects page.) Closesrust-lang#13518 (mk: Change windows to install from stage2) Closesrust-lang#13516 (liburl doc: insert missing hyphen) Closesrust-lang#13514 (rustdoc: Better sorting criteria for searching.) Closesrust-lang#13512 (native: Fix a race in select()) Closesrust-lang#13506 (Use the unsigned integer types for bitwise intrinsics.) Closesrust-lang#13502 (Add a default impl for Set::is_superset)
arcnmx pushed a commit
to arcnmx/rust
that referenced
this pull request
Jan 9, 2023
…gation-resolution, r=lnicola Apply fallback before final obligation resolution Fixesrust-lang#13249Fixesrust-lang#13518 We've been applying fallback to type variables independently even when there are some unresolved obligations that associate them. This PR applies fallback to unresolved scalar type variables before the final attempt of resolving obligations, which enables us to infer more. Unlike rustc, which has separate storages for each kind of type variables, we currently don't have a way to retrieve only integer/float type variables without folding/visiting every single type we've inferred. I've repurposed `TypeVariableData` as bitflags that also hold the kind of the type variable it's referring to so that we can "reconstruct" scalar type variables from their indices. This PR increases the number of ??ty for rust-analyzer repo not because we regress and fail to infer the existing code but because we fail to infer the new code. It seems we have problems inferring some functions bitflags produces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, windows was installed from stage3 to guarantee convergence between
the host and target artifacts, but syntax extensions on all platforms are
currently relying on convergence, so special casing this one platform has become
less relevant over time.
This will also have the added benefit of dealing with #13474 and #13491. These
issues will be closed after next next nightly is confirmed to fix them.