Uh oh!
There was an error while loading. Please reload this page.
Remove RUST_LOG="::help" from the docs - #13526
Closed
tbu- wants to merge 1 commit into
Closed
Conversation
This feature is no longer present in the current version, it was removed along with the crate map.
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 16, 2014
Closesrust-lang#13546 (workcache: Don't assume gcc exists on all platforms) Closesrust-lang#13545 (std: Remove pub use globs) Closesrust-lang#13530 (test: Un-ignore smallest-hello-world.rs) Closesrust-lang#13529 (std: Un-ignore some float tests on windows) Closesrust-lang#13528 (green: Add a helper macro for booting libgreen) Closesrust-lang#13526 (Remove RUST_LOG="::help" from the docs) Closesrust-lang#13524 (dist: Make Windows installer uninstall first. Closesrust-lang#9563) Closesrust-lang#13521 (Change AUTHORS section in the man pages) Closesrust-lang#13519 (Update GitHub's Rust projects page.) Closesrust-lang#13518 (mk: Change windows to install from stage2) Closesrust-lang#13516 (liburl doc: insert missing hyphen) Closesrust-lang#13514 (rustdoc: Better sorting criteria for searching.) Closesrust-lang#13512 (native: Fix a race in select()) Closesrust-lang#13506 (Use the unsigned integer types for bitwise intrinsics.) Closesrust-lang#13502 (Add a default impl for Set::is_superset)
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 10, 2024
Don't warn on proc macro generated code in `needless_return` Fixesrust-lang#13458Fixesrust-lang#13457Fixesrust-lang#13467Fixesrust-lang#13479Fixesrust-lang#13481Fixesrust-lang#13526Fixesrust-lang#13486 The fix is unfortunately a little more convoluted than just simply adding a `is_from_proc_macro`. That check *does* fix the issue, however it also introduces a bunch of false negatives in the tests, specifically when the returned expression is in a different syntax context, e.g. `return format!(..)`. The proc macro check builds up a start and end pattern based on the HIR nodes and compares it to a snippet of the span, however that would currently fail for `return format!(..)` because we would have the patterns `("return", <something inside of the format macro>)`, which doesn't compare equal. So we now return an empty string pattern for when it's in a different syntax context. "Hide whitespace" helps a bit for reviewing the proc macro detection change changelog: none
rust-cloud-vmsBot
pushed a commit
to liwagu/rust
that referenced
this pull request
Oct 10, 2024
Don't warn on proc macro generated code in `needless_return` Fixesrust-lang#13458Fixesrust-lang#13457Fixesrust-lang#13467Fixesrust-lang#13479Fixesrust-lang#13481Fixesrust-lang#13526Fixesrust-lang#13486 The fix is unfortunately a little more convoluted than just simply adding a `is_from_proc_macro`. That check *does* fix the issue, however it also introduces a bunch of false negatives in the tests, specifically when the returned expression is in a different syntax context, e.g. `return format!(..)`. The proc macro check builds up a start and end pattern based on the HIR nodes and compares it to a snippet of the span, however that would currently fail for `return format!(..)` because we would have the patterns `("return", <something inside of the format macro>)`, which doesn't compare equal. So we now return an empty string pattern for when it's in a different syntax context. "Hide whitespace" helps a bit for reviewing the proc macro detection change changelog: none
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 18, 2024
Don't warn on proc macro generated code in `needless_return` Fixesrust-lang#13458Fixesrust-lang#13457Fixesrust-lang#13467Fixesrust-lang#13479Fixesrust-lang#13481Fixesrust-lang#13526Fixesrust-lang#13486 The fix is unfortunately a little more convoluted than just simply adding a `is_from_proc_macro`. That check *does* fix the issue, however it also introduces a bunch of false negatives in the tests, specifically when the returned expression is in a different syntax context, e.g. `return format!(..)`. The proc macro check builds up a start and end pattern based on the HIR nodes and compares it to a snippet of the span, however that would currently fail for `return format!(..)` because we would have the patterns `("return", <something inside of the format macro>)`, which doesn't compare equal. So we now return an empty string pattern for when it's in a different syntax context. "Hide whitespace" helps a bit for reviewing the proc macro detection change changelog: none
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 18, 2024
Don't warn on proc macro generated code in `needless_return` Fixesrust-lang#13458Fixesrust-lang#13457Fixesrust-lang#13467Fixesrust-lang#13479Fixesrust-lang#13481Fixesrust-lang#13526Fixesrust-lang#13486 The fix is unfortunately a little more convoluted than just simply adding a `is_from_proc_macro`. That check *does* fix the issue, however it also introduces a bunch of false negatives in the tests, specifically when the returned expression is in a different syntax context, e.g. `return format!(..)`. The proc macro check builds up a start and end pattern based on the HIR nodes and compares it to a snippet of the span, however that would currently fail for `return format!(..)` because we would have the patterns `("return", <something inside of the format macro>)`, which doesn't compare equal. So we now return an empty string pattern for when it's in a different syntax context. "Hide whitespace" helps a bit for reviewing the proc macro detection change changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is no longer present in the current version, it was removed along
with the crate map.