Uh oh!
There was an error while loading. Please reload this page.
green: Add a helper macro for booting libgreen - #13528
Closed
alexcrichton wants to merge 1 commit into
Closed
Conversation
This one-liner should help booting libgreen with librustuv without having to worry about all the fiddly bits of argc/argv and whatnot.
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 16, 2014
Closesrust-lang#13546 (workcache: Don't assume gcc exists on all platforms) Closesrust-lang#13545 (std: Remove pub use globs) Closesrust-lang#13530 (test: Un-ignore smallest-hello-world.rs) Closesrust-lang#13529 (std: Un-ignore some float tests on windows) Closesrust-lang#13528 (green: Add a helper macro for booting libgreen) Closesrust-lang#13526 (Remove RUST_LOG="::help" from the docs) Closesrust-lang#13524 (dist: Make Windows installer uninstall first. Closesrust-lang#9563) Closesrust-lang#13521 (Change AUTHORS section in the man pages) Closesrust-lang#13519 (Update GitHub's Rust projects page.) Closesrust-lang#13518 (mk: Change windows to install from stage2) Closesrust-lang#13516 (liburl doc: insert missing hyphen) Closesrust-lang#13514 (rustdoc: Better sorting criteria for searching.) Closesrust-lang#13512 (native: Fix a race in select()) Closesrust-lang#13506 (Use the unsigned integer types for bitwise intrinsics.) Closesrust-lang#13502 (Add a default impl for Set::is_superset)
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 18, 2024
Improved wording of or_fun_call lint
The current wording (e.g. ``use of `ok_or` followed by a function call``) is potentially confusing (at least it confused me) by suggesting that the function that follows the (in this case) `ok_or` is the problem and not the function that is an argument to it.
The code in my program that triggered the confusing message is the following:
```rust
let file_id = buf
.lines()
.next()
.ok_or((
InternalError::ProblemReadingFromInbox,
anyhow!("No first line in inbox response ({file:?}): {buf:?}"),
))
.html_context(stream, lang)?;
```
I thought that `html_context` was the problem and that I should do something along the following lines:
```rust
let file_id = buf
.lines()
.next()
.ok_or_else(
(
InternalError::ProblemReadingFromInbox,
anyhow!("No first line in inbox response ({file:?}): {buf:?}"),
),
html_context(stream, lang),
)?
```
This is of course wrong. My confusion was only cleared up through the help message indicating what I should try instead.
If someone has a better idea of a replacement wording (currently e.g. ``` function call inside of `ok_or` ```), I'm all ears.
changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one-liner should help booting libgreen with librustuv without having to
worry about all the fiddly bits of argc/argv and whatnot.