Uh oh!
There was an error while loading. Please reload this page.
fix(rustdoc): Fixed stability version in rustdoc - #137320
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
GuillaumeGomez
approved these changes
Feb 22, 2025
GuillaumeGomez
commented
Feb 22, 2025
Member
Looks good to me, thanks! I'll just let @notriddle take a look first before approving. |
This comment was marked as duplicate.
This comment was marked as duplicate.
notriddle
requested changes
Feb 22, 2025
Uh oh!
There was an error while loading. Please reload this page.
tapanprakashtforce-pushed
the
fix-doc-version-stability
branch
from
February 23, 2025 17:03
2440ec4 to
afc89a1Comparenotriddle
approved these changes
Feb 24, 2025
tapanprakasht
commented
Feb 25, 2025
ContributorAuthor
@GuillaumeGomez or @notriddle I see the PR is approved now. Can you merge the changes if everything okay? |
GuillaumeGomez
commented
Feb 25, 2025
Member
We were just waiting for CI to pass. Thanks for the fix! @bors r=notriddle rollup |
bors
commented
Feb 25, 2025
Collaborator
yotamofek
requested changes
Feb 25, 2025
Uh oh!
There was an error while loading. Please reload this page.
fmease added a commit
to fmease/rust
that referenced
this pull request
Feb 26, 2025
…ility, r=notriddle fix(rustdoc): Fixed stability version in rustdoc Tries to fixrust-lang#137141 Fixed by adding checks glob exports
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 13 pull requests Successful merges: - rust-lang#136576 (pass optimization level to llvm-bitcode-linker) - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc) - rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis) - rust-lang#137529 (remove few unused args) - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099)) - rust-lang#137559 (run some tests on emscripten again) - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`) - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type) - rust-lang#137604 (trait_sel: resolve vars in host effects) - rust-lang#137609 (Complete the list of resources used in rustdoc output) - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of) - rust-lang#137614 (fix doc in library/core/src/pin.rs) - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 14 pull requests Successful merges: - rust-lang#136576 (pass optimization level to llvm-bitcode-linker) - rust-lang#137154 (Add UTF-8 validation fast paths in `Wtf8Buf`) - rust-lang#137311 (Enable `f16` for MIPS) - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc) - rust-lang#137529 (remove few unused args) - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099)) - rust-lang#137559 (run some tests on emscripten again) - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`) - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type) - rust-lang#137604 (trait_sel: resolve vars in host effects) - rust-lang#137609 (Complete the list of resources used in rustdoc output) - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of) - rust-lang#137614 (fix doc in library/core/src/pin.rs) - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup merge of rust-lang#137320 - tapanprakasht:fix-doc-version-stability, r=notriddle fix(rustdoc): Fixed stability version in rustdoc Tries to fixrust-lang#137141 Fixed by adding checks glob exports
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Mar 7, 2025
…llaumeGomez `librustdoc`: clippy fixes First commit is all machine-generated fixes, next two are some more lints fixed by hand/misc. cleanups Inspired by the redundant `.and_then()` added in rust-lang#137320 , and [this comment](rust-lang#138090 (comment)) r? `@GuillaumeGomez`
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2025
…llaumeGomez `librustdoc`: clippy fixes First commit is all machine-generated fixes, next two are some more lints fixed by hand/misc. cleanups Inspired by the redundant `.and_then()` added in rust-lang#137320 , and [this comment](rust-lang#138090 (comment)) r? ``@GuillaumeGomez``
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2025
…llaumeGomez `librustdoc`: clippy fixes First commit is all machine-generated fixes, next two are some more lints fixed by hand/misc. cleanups Inspired by the redundant `.and_then()` added in rust-lang#137320 , and [this comment](rust-lang#138090 (comment)) r? ```@GuillaumeGomez```
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
Rollup merge of rust-lang#138107 - yotamofek:pr/rustdoc/clippy, r=GuillaumeGomez `librustdoc`: clippy fixes First commit is all machine-generated fixes, next two are some more lints fixed by hand/misc. cleanups Inspired by the redundant `.and_then()` added in rust-lang#137320 , and [this comment](rust-lang#138090 (comment)) r? ```@GuillaumeGomez```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to fix#137141
Fixed by adding checks glob exports