Skip to content

Complete the list of resources used in rustdoc output - #137609

Merged
bors merged 2 commits into
rust-lang:masterfrom
ColinPitrat:master
Feb 26, 2025
Merged

Complete the list of resources used in rustdoc output#137609
bors merged 2 commits into
rust-lang:masterfrom
ColinPitrat:master

Conversation

@ColinPitrat

Copy link
Copy Markdown
Contributor

The Nanum Barun Gothic Font was missing in the list and should clearly be mentionned.

Arguably referencing the Rust logos is not really necessary as the file mentions "third party resources" but it doesn't hurt and should make things clearer for anybody who wants to publish their Rust doc.

@rustbot

This comment was marked as outdated.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Feb 25, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Feb 25, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit eaf8fc5 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2025
fmease added a commit to fmease/rust that referenced this pull request Feb 26, 2025
Complete the list of resources used in rustdoc output
The Nanum Barun Gothic Font was missing in the list and should clearly be mentionned.
Arguably referencing the Rust logos is not really necessary as the file mentions "third party resources" but it doesn't hurt and should make things clearer for anybody who wants to publish their Rust doc.
@fmeasefmease mentioned this pull request Feb 26, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
Rollup of 13 pull requests
Successful merges:
- rust-lang#136576 (pass optimization level to llvm-bitcode-linker)
- rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc)
- rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
- rust-lang#137529 (remove few unused args)
- rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099))
- rust-lang#137559 (run some tests on emscripten again)
- rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`)
- rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type)
- rust-lang#137604 (trait_sel: resolve vars in host effects)
- rust-lang#137609 (Complete the list of resources used in rustdoc output)
- rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of)
- rust-lang#137614 (fix doc in library/core/src/pin.rs)
- rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute)
r? `@ghost`
`@rustbot` modify labels: rollup
@fmeasefmease mentioned this pull request Feb 26, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
Rollup of 14 pull requests
Successful merges:
- rust-lang#136576 (pass optimization level to llvm-bitcode-linker)
- rust-lang#137154 (Add UTF-8 validation fast paths in `Wtf8Buf`)
- rust-lang#137311 (Enable `f16` for MIPS)
- rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc)
- rust-lang#137529 (remove few unused args)
- rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099))
- rust-lang#137559 (run some tests on emscripten again)
- rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`)
- rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type)
- rust-lang#137604 (trait_sel: resolve vars in host effects)
- rust-lang#137609 (Complete the list of resources used in rustdoc output)
- rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of)
- rust-lang#137614 (fix doc in library/core/src/pin.rs)
- rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a82ad94 into rust-lang:masterFeb 26, 2025
@rustbotrustbot added this to the 1.87.0 milestone Feb 26, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
Rollup merge of rust-lang#137609 - ColinPitrat:master, r=GuillaumeGomez
Complete the list of resources used in rustdoc output
The Nanum Barun Gothic Font was missing in the list and should clearly be mentionned.
Arguably referencing the Rust logos is not really necessary as the file mentions "third party resources" but it doesn't hurt and should make things clearer for anybody who wants to publish their Rust doc.
@fmeasefmease assigned GuillaumeGomez and unassigned fmeaseAug 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ColinPitrat@rustbot@GuillaumeGomez@bors@fmease