Skip to content

ssa/mono: deduplicate type_has_metadata - #137601

Merged
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:deduplicate-type-has-metadata
Feb 26, 2025
Merged

ssa/mono: deduplicate type_has_metadata#137601
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:deduplicate-type-has-metadata

Conversation

@davidtwco

@davidtwcodavidtwco commented Feb 25, 2025

Copy link
Copy Markdown
Member

The implementation of the type_has_metadata function is duplicated in rustc_codegen_ssa and rustc_monomorphize, so move this to rustc_middle.

@davidtwco
ssa/mono: deduplicate type_has_metadata
5afa6a1
The implementation of the `type_has_metadata` function is duplicated in
`rustc_codegen_ssa` and `rustc_monomorphize`, so move this to
`rustc_middle`.
@rustbot

rustbot commented Feb 25, 2025

Copy link
Copy Markdown
Collaborator

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2025
@fmease

fmease commented Feb 25, 2025

Copy link
Copy Markdown
Member

Thanks! @bors r+ rollup

@bors

bors commented Feb 25, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit ba935ac has been approved by fmease

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2025
bjorn3
bjorn3 reviewed Feb 25, 2025
View reviewed changes
Comment threadcompiler/rustc_codegen_ssa/src/traits/type_.rs Outdated
@fmease

fmease commented Feb 25, 2025

Copy link
Copy Markdown
Member

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2025
@davidtwco
davidtwcoforce-pushed the deduplicate-type-has-metadata branch from ba935ac to 7a6c75bCompareFebruary 25, 2025 11:14
@fmease

fmease commented Feb 25, 2025•
edited
Loading

Copy link
Copy Markdown
Member

r=fmease,bjorn3 with bjorn3's suggestion applied and CI green

@davidtwco
davidtwcoforce-pushed the deduplicate-type-has-metadata branch from 7a6c75b to 5afa6a1CompareFebruary 25, 2025 11:27
@davidtwco

davidtwco commented Feb 25, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r=fmease,bjorn3 rollup

@bors

bors commented Feb 25, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5afa6a1 has been approved by fmease,bjorn3

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2025
fmease added a commit to fmease/rust that referenced this pull request Feb 26, 2025
@fmease
Rollup merge ofrust-lang#137601- davidtwco:deduplicate-type-has-met…
a9f5a2a
…adata, r=fmease,bjorn3
ssa/mono: deduplicate `type_has_metadata`
The implementation of the `type_has_metadata` function is duplicated in `rustc_codegen_ssa` and `rustc_monomorphize`, so move this to `rustc_middle`.
@fmeasefmease mentioned this pull request Feb 26, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@bors
Auto merge ofrust-lang#137649- fmease:rollup-59lpxdh, r=fmease
fa98c79
Rollup of 13 pull requests
Successful merges:
- rust-lang#136576 (pass optimization level to llvm-bitcode-linker)
- rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc)
- rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
- rust-lang#137529 (remove few unused args)
- rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099))
- rust-lang#137559 (run some tests on emscripten again)
- rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`)
- rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type)
- rust-lang#137604 (trait_sel: resolve vars in host effects)
- rust-lang#137609 (Complete the list of resources used in rustdoc output)
- rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of)
- rust-lang#137614 (fix doc in library/core/src/pin.rs)
- rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute)
r? `@ghost`
`@rustbot` modify labels: rollup
@fmeasefmease mentioned this pull request Feb 26, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@bors
Auto merge ofrust-lang#137651- fmease:rollup-s3s7m6f, r=fmease
2b3cef8
Rollup of 14 pull requests
Successful merges:
- rust-lang#136576 (pass optimization level to llvm-bitcode-linker)
- rust-lang#137154 (Add UTF-8 validation fast paths in `Wtf8Buf`)
- rust-lang#137311 (Enable `f16` for MIPS)
- rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc)
- rust-lang#137529 (remove few unused args)
- rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099))
- rust-lang#137559 (run some tests on emscripten again)
- rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`)
- rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type)
- rust-lang#137604 (trait_sel: resolve vars in host effects)
- rust-lang#137609 (Complete the list of resources used in rustdoc output)
- rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of)
- rust-lang#137614 (fix doc in library/core/src/pin.rs)
- rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 51085b2 into rust-lang:masterFeb 26, 2025
@rustbotrustbot added this to the 1.87.0 milestone Feb 26, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@rust-timer
Unrolled build forrust-lang#137601
5c9f439
Rollup merge of rust-lang#137601 - davidtwco:deduplicate-type-has-metadata, r=fmease,bjorn3
ssa/mono: deduplicate `type_has_metadata`
The implementation of the `type_has_metadata` function is duplicated in `rustc_codegen_ssa` and `rustc_monomorphize`, so move this to `rustc_middle`.
@davidtwco
davidtwco deleted the deduplicate-type-has-metadata branch February 26, 2025 10:30
@oli-obkoli-obk mentioned this pull request May 27, 2025
Merged
@davidtwcodavidtwco mentioned this pull request Jul 24, 2025
Open
22 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes
@bjorn3bjorn3bjorn3 left review comments

Assignees

@fmeasefmease

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@fmease@bors@bjorn3