Remove the omit_gdb_pretty_printer_section attribute by bjorn3 · Pull Request #144738 · rust-lang/rust

bjorn3 · 2025-07-31T14:57:55Z

Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.

rustbot · 2025-07-31T14:58:00Z

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bjorn3 · 2025-07-31T14:58:04Z

cc #143679 (comment)

rustbot · 2025-07-31T14:58:04Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

bjorn3 · 2025-07-31T15:06:49Z

Almost all tests pass without //@ no-debug-pretty-printers, but I kept them just in case it is actually load bearing for some tests.

jieyouxu

Thanks, one doc request

jieyouxu · 2025-07-31T15:13:53Z

r? jieyouxu

jieyouxu · 2025-07-31T15:51:28Z

@rustbot author

rustbot · 2025-07-31T16:09:34Z

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

bjorn3 · 2025-07-31T16:10:04Z

@rustbot ready

jieyouxu · 2025-07-31T16:12:35Z

Thanks, you can r=me after PR CI is green.

bjorn3 · 2025-07-31T17:24:51Z

@bors r=jieyouxu

bors · 2025-07-31T17:24:54Z

📌 Commit d8ee663 has been approved by jieyouxu

It is now in the queue for this repository.

…, r=<try> Remove the omit_gdb_pretty_printer_section attribute try-job: aarch64-apple

rust-bors · 2025-08-01T18:04:47Z

⌛ Trying commit cd8ad69 with merge d8e8166…

To cancel the try build, run the command @bors try cancel.

rust-bors · 2025-08-01T19:38:15Z

☀️ Try build successful (CI)
Build commit: d8e8166 (d8e816683a8fbdbe659206e25da866730fc2d6e9, parent: 4b55fe199cfe9c710555a5af7f2a49491ad38254)

rustbot · 2025-08-01T20:03:40Z

Unknown labels: T-bootstrap, A-LLVM, A-attributes, A-testsuite, A-rustc-dev-guide, A-compiletest

Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.

rustbot · 2025-08-01T20:05:11Z

Unknown labels: A-attributes, A-testsuite, A-compiletest, T-bootstrap, A-rustc-dev-guide, A-LLVM

bjorn3 · 2025-08-01T20:05:30Z

Turns out the tests were expecting pretty printers to always be on for LLDB. I've made the test directive only apply to GDB and renamed it accordingly.

bjorn3 · 2025-08-01T20:05:48Z

@rustbot ready

jieyouxu

Thanks

jieyouxu · 2025-08-02T10:10:07Z

Normally I would bump the p on this PR because it has a lot of test changes and so is conflict-prone, but there's quite a few backports / release process PRs in queue so I didn't want to do that.

@bors r+

bors · 2025-08-02T10:10:10Z

📌 Commit ae2f8d9 has been approved by jieyouxu

It is now in the queue for this repository.

…ter_section, r=jieyouxu Remove the omit_gdb_pretty_printer_section attribute Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.

Rollup of 11 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144650 (Additional tce tests) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) Failed merges: - #144794 (Port `#[coroutine]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup

…ter_section, r=jieyouxu Remove the omit_gdb_pretty_printer_section attribute Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.

Rollup of 12 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144070 (Implement `hash_map` macro ) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) - #144851 (Forbid tail calling intrinsics) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144738 - bjorn3:remove_omit_gdb_pretty_printer_section, r=jieyouxu Remove the omit_gdb_pretty_printer_section attribute Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.

Rollup of 12 pull requests Successful merges: - rust-lang/rust#142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - rust-lang/rust#144070 (Implement `hash_map` macro ) - rust-lang/rust#144738 (Remove the omit_gdb_pretty_printer_section attribute) - rust-lang/rust#144790 (Multiple bounds checking elision failures) - rust-lang/rust#144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - rust-lang/rust#144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - rust-lang/rust#144816 (Update E0562 to account for the new impl trait positions) - rust-lang/rust#144822 (Return a struct with named fields from `hash_owner_nodes`) - rust-lang/rust#144824 (Updated test links in compiler) - rust-lang/rust#144829 (Use full flag name in strip command for Darwin) - rust-lang/rust#144843 (Weekly `cargo update`) - rust-lang/rust#144851 (Forbid tail calling intrinsics) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned lcnr Jul 31, 2025

bjorn3 force-pushed the remove_omit_gdb_pretty_printer_section branch from c76e848 to 6ecc1c3Compare July 31, 2025 14:58

bjorn3 mentioned this pull request Jul 31, 2025
Preserve the .debug_gdb_scripts section #143679
Merged

jieyouxu approved these changes Jul 31, 2025
View reviewed changes

Comment threadsrc/tools/compiletest/src/runtest/debuginfo.rs Outdated

rustbot assigned jieyouxu and unassigned lcnr Jul 31, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-rustc-dev-guide Area: rustc-dev-guide and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2025

bjorn3 mentioned this pull request Jul 31, 2025
Remove -Zthinlto #144744
Closed

rust-borsBot added a commit that referenced this pull request Aug 1, 2025
Auto merge of#144738- bjorn3:remove_omit_gdb_pretty_printer_section…
d8e8166
…, r=<try> Remove the omit_gdb_pretty_printer_section attribute try-job: aarch64-apple

bjorn3 force-pushed the remove_omit_gdb_pretty_printer_section branch from cd8ad69 to 3d234c7Compare August 1, 2025 20:03

bjorn3 force-pushed the remove_omit_gdb_pretty_printer_section branch from 3d234c7 to ae2f8d9Compare August 1, 2025 20:05

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2025

jieyouxu approved these changes Aug 2, 2025
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2025

samueltardieu mentioned this pull request Aug 3, 2025
Rollup of 11 pull requests #144860
Closed

This was referenced Aug 3, 2025
Rollup of 11 pull requests #144868
Closed
Rollup of 12 pull requests #144869
Merged

bors merged commit 3823f0b into rust-lang:masterAug 4, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 4, 2025

bjorn3 deleted the remove_omit_gdb_pretty_printer_section branch August 4, 2025 07:58

Uh oh!

Uh oh!

Conversation

bjorn3 commented Jul 31, 2025

Uh oh!

rustbot commented Jul 31, 2025

Uh oh!

bjorn3 commented Jul 31, 2025

Uh oh!

rustbot commented Jul 31, 2025

Uh oh!

bjorn3 commented Jul 31, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu commented Jul 31, 2025

Uh oh!

jieyouxu commented Jul 31, 2025

Uh oh!

rustbot commented Jul 31, 2025

Uh oh!

bjorn3 commented Jul 31, 2025

Uh oh!

jieyouxu commented Jul 31, 2025

Uh oh!

bjorn3 commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

rust-borsBot commented Aug 1, 2025

Uh oh!

rust-borsBot commented Aug 1, 2025

Uh oh!

rustbot commented Aug 1, 2025

Uh oh!

rustbot commented Aug 1, 2025

Uh oh!

bjorn3 commented Aug 1, 2025

Uh oh!

bjorn3 commented Aug 1, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 2, 2025

Uh oh!

bors commented Aug 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants