Skip to content

Interner arg to EarlyBinder does not affect auto traits - #144808

Merged
bors merged 1 commit into
rust-lang:masterfrom
Veykril:push-uttkuyswqnzt
Aug 4, 2025
Merged

Interner arg to EarlyBinder does not affect auto traits#144808
bors merged 1 commit into
rust-lang:masterfrom
Veykril:push-uttkuyswqnzt

Conversation

@Veykril

@VeykrilVeykril commented Aug 2, 2025

Copy link
Copy Markdown
Member

Conceptually EarlyBinder does not contain an Interner so it shouldn't tell Rust it does via PhantomData. This is necessary for rust-analyzer as it stores EarlyBinders in query results which require Sync, placing restrictions on our interner setup.

r? compiler-errors

@Veykril
Interner arg to EarlyBinder does not affect auto traits
2f60cef
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`.
This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
@rustbot

rustbot commented Aug 2, 2025

Copy link
Copy Markdown
Collaborator

compiler-errors is not on the review rotation at the moment.
They may take a while to respond.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 2, 2025
@compiler-errors

compiler-errors commented Aug 2, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Aug 2, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2f60cef has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 3, 2025
@Zalathar
Rollup merge ofrust-lang#144808- Veykril:push-uttkuyswqnzt, r=compi…
a994da9
…ler-errors
`Interner` arg to `EarlyBinder` does not affect auto traits
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
r? compiler-errors
@ZalatharZalathar mentioned this pull request Aug 3, 2025
Closed
bors added a commit that referenced this pull request Aug 3, 2025
@bors
Auto merge of#144844- Zalathar:rollup-2csfgl2, r=Zalathar
05a2257
Rollup of 14 pull requests
Successful merges:
- #143857 (Port #[macro_export] to the new attribute parsing infrastructure)
- #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition)
- #144070 (Implement `hash_map` macro )
- #144322 (Add lint against dangling pointers from local variables)
- #144443 (Make target pointer width in target json an integer)
- #144667 (`AlignmentEnum` should just be `repr(usize)` now)
- #144779 (Implement debugging output of the bootstrap Step graph into a DOT file)
- #144790 (Multiple bounds checking elision failures)
- #144794 (Port `#[coroutine]` to the new attribute system)
- #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits)
- #144816 (Update E0562 to account for the new impl trait positions)
- #144822 (Return a struct with named fields from `hash_owner_nodes`)
- #144824 (Updated test links in compiler)
- #144829 (Use full flag name in strip command for Darwin)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 3, 2025
@Zalathar
Rollup merge ofrust-lang#144808- Veykril:push-uttkuyswqnzt, r=compi…
e426e3c
…ler-errors
`Interner` arg to `EarlyBinder` does not affect auto traits
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
r? compiler-errors
@ZalatharZalathar mentioned this pull request Aug 3, 2025
Closed
bors added a commit that referenced this pull request Aug 3, 2025
@bors
Auto merge of#144845- Zalathar:rollup-g8dizgm, r=Zalathar
922a42b
Rollup of 13 pull requests
Successful merges:
- #143857 (Port #[macro_export] to the new attribute parsing infrastructure)
- #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition)
- #144070 (Implement `hash_map` macro )
- #144322 (Add lint against dangling pointers from local variables)
- #144443 (Make target pointer width in target json an integer)
- #144667 (`AlignmentEnum` should just be `repr(usize)` now)
- #144790 (Multiple bounds checking elision failures)
- #144794 (Port `#[coroutine]` to the new attribute system)
- #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits)
- #144816 (Update E0562 to account for the new impl trait positions)
- #144822 (Return a struct with named fields from `hash_owner_nodes`)
- #144824 (Updated test links in compiler)
- #144829 (Use full flag name in strip command for Darwin)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 3, 2025
@Zalathar
Rollup merge ofrust-lang#144808- Veykril:push-uttkuyswqnzt, r=compi…
2603e61
…ler-errors
`Interner` arg to `EarlyBinder` does not affect auto traits
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
r? compiler-errors
@ZalatharZalathar mentioned this pull request Aug 3, 2025
Closed
bors added a commit that referenced this pull request Aug 3, 2025
@bors
Auto merge of#144846- Zalathar:rollup-j31vgyh, r=Zalathar
c2aa633
Rollup of 13 pull requests
Successful merges:
- #143857 (Port #[macro_export] to the new attribute parsing infrastructure)
- #144070 (Implement `hash_map` macro )
- #144322 (Add lint against dangling pointers from local variables)
- #144667 (`AlignmentEnum` should just be `repr(usize)` now)
- #144678 (Make no_mangle on foreign items explicit instead of implicit)
- #144790 (Multiple bounds checking elision failures)
- #144794 (Port `#[coroutine]` to the new attribute system)
- #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding)
- #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits)
- #144816 (Update E0562 to account for the new impl trait positions)
- #144822 (Return a struct with named fields from `hash_owner_nodes`)
- #144824 (Updated test links in compiler)
- #144829 (Use full flag name in strip command for Darwin)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 3, 2025
@Zalathar
Rollup merge ofrust-lang#144808- Veykril:push-uttkuyswqnzt, r=compi…
f497e6d
…ler-errors
`Interner` arg to `EarlyBinder` does not affect auto traits
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
r? compiler-errors
@ZalatharZalathar mentioned this pull request Aug 3, 2025
Closed
bors added a commit that referenced this pull request Aug 3, 2025
@bors
Auto merge of#144850- Zalathar:rollup-cs1fmbn, r=Zalathar
13cfdd8
Rollup of 13 pull requests
Successful merges:
- #143857 (Port #[macro_export] to the new attribute parsing infrastructure)
- #144070 (Implement `hash_map` macro )
- #144322 (Add lint against dangling pointers from local variables)
- #144667 (`AlignmentEnum` should just be `repr(usize)` now)
- #144706 (Do not give function allocations alignment in consteval and Miri.)
- #144790 (Multiple bounds checking elision failures)
- #144794 (Port `#[coroutine]` to the new attribute system)
- #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding)
- #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits)
- #144816 (Update E0562 to account for the new impl trait positions)
- #144822 (Return a struct with named fields from `hash_owner_nodes`)
- #144824 (Updated test links in compiler)
- #144829 (Use full flag name in strip command for Darwin)
r? `@ghost`
`@rustbot` modify labels: rollup
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 3, 2025
@samueltardieu
Rollup merge ofrust-lang#144808- Veykril:push-uttkuyswqnzt, r=compi…
e9737df
…ler-errors
`Interner` arg to `EarlyBinder` does not affect auto traits
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
r? compiler-errors
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 3, 2025
@samueltardieu
Rollup merge ofrust-lang#144808- Veykril:push-uttkuyswqnzt, r=compi…
d4fa2b1
…ler-errors
`Interner` arg to `EarlyBinder` does not affect auto traits
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
r? compiler-errors
@samueltardieusamueltardieu mentioned this pull request Aug 3, 2025
Closed
bors added a commit that referenced this pull request Aug 3, 2025
@bors
Auto merge of#144860- samueltardieu:rollup-3i49mfl, r=samueltardieu
f9cd680
Rollup of 11 pull requests
Successful merges:
- #142678 (Misc cleanups of `generic_arg_infer` related HIR logic)
- #144650 (Additional tce tests)
- #144738 (Remove the omit_gdb_pretty_printer_section attribute)
- #144790 (Multiple bounds checking elision failures)
- #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding)
- #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits)
- #144816 (Update E0562 to account for the new impl trait positions)
- #144822 (Return a struct with named fields from `hash_owner_nodes`)
- #144824 (Updated test links in compiler)
- #144829 (Use full flag name in strip command for Darwin)
- #144843 (Weekly `cargo update`)
Failed merges:
- #144794 (Port `#[coroutine]` to the new attribute system)
r? `@ghost`
`@rustbot` modify labels: rollup
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 3, 2025
@samueltardieu
Rollup merge ofrust-lang#144808- Veykril:push-uttkuyswqnzt, r=compi…
79f00a8
…ler-errors
`Interner` arg to `EarlyBinder` does not affect auto traits
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
r? compiler-errors
This was referenced Aug 3, 2025
Closed
Merged
bors added a commit that referenced this pull request Aug 3, 2025
@bors
Auto merge of#144869- samueltardieu:rollup-3ba3m47, r=samueltardieu
383b9c4
Rollup of 12 pull requests
Successful merges:
- #142678 (Misc cleanups of `generic_arg_infer` related HIR logic)
- #144070 (Implement `hash_map` macro )
- #144738 (Remove the omit_gdb_pretty_printer_section attribute)
- #144790 (Multiple bounds checking elision failures)
- #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding)
- #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits)
- #144816 (Update E0562 to account for the new impl trait positions)
- #144822 (Return a struct with named fields from `hash_owner_nodes`)
- #144824 (Updated test links in compiler)
- #144829 (Use full flag name in strip command for Darwin)
- #144843 (Weekly `cargo update`)
- #144851 (Forbid tail calling intrinsics)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f3297d8 into rust-lang:masterAug 4, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 4, 2025
rust-timer added a commit that referenced this pull request Aug 4, 2025
@rust-timer
Unrolled build for#144808
749d4eb
Rollup merge of #144808 - Veykril:push-uttkuyswqnzt, r=compiler-errors
`Interner` arg to `EarlyBinder` does not affect auto traits
Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.
r? compiler-errors
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 4, 2025
@bors
Auto merge of #144869 - samueltardieu:rollup-3ba3m47, r=samueltardieu
14b7b0b
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142678 (Misc cleanups of `generic_arg_infer` related HIR logic)
- rust-lang/rust#144070 (Implement `hash_map` macro )
- rust-lang/rust#144738 (Remove the omit_gdb_pretty_printer_section attribute)
- rust-lang/rust#144790 (Multiple bounds checking elision failures)
- rust-lang/rust#144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding)
- rust-lang/rust#144808 (`Interner` arg to `EarlyBinder` does not affect auto traits)
- rust-lang/rust#144816 (Update E0562 to account for the new impl trait positions)
- rust-lang/rust#144822 (Return a struct with named fields from `hash_owner_nodes`)
- rust-lang/rust#144824 (Updated test links in compiler)
- rust-lang/rust#144829 (Use full flag name in strip command for Darwin)
- rust-lang/rust#144843 (Weekly `cargo update`)
- rust-lang/rust#144851 (Forbid tail calling intrinsics)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errorscompiler-errors

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Veykril@rustbot@compiler-errors@bors