compiletest: Preliminary cleanup of `ProcRes` printing/unwinding by Zalathar · Pull Request #144805 · rust-lang/rust

Zalathar · 2025-08-02T03:46:30Z

While experimenting with changes to how compiletest handles output capture, error reporting, and unwinding, I repeatedly ran in to difficulties with this core code for reporting test failures caused by a subprocess.

There should be no change in compiletest output.

r? jieyouxu

rustbot · 2025-08-02T03:46:35Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-08-02T03:46:37Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

jieyouxu

Thanks

jieyouxu · 2025-08-02T07:17:26Z

@bors r+ rollup

bors · 2025-08-02T07:17:28Z

📌 Commit b178525 has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2025-08-02T07:38:11Z

Unfortunately this probably conflicts with #144747, feel free to r=me after rebase.

Rollup of 18 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #135771 ([rustdoc] Add support for associated items in "jump to def" feature) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #143771 (Constify some more `Result` functions) - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #144185 (Document guarantees of poisoning) - #144395 (update fortanix tests) - #144478 (Improve formatting of doc code blocks) - #144614 (Fortify RemoveUnneededDrops test.) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - #144756 (detect infinite recursion with tail calls in ctfe) - #144766 (Add human readable name "Cygwin") - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) - #144786 (Cleanup the definition of `group_type`) - #144796 (Add my previous commit name to .mailmap) - #144797 (Update safety comment for new_unchecked in niche_types) Failed merges: - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) r? `@ghost` `@rustbot` modify labels: rollup

This method now returns a string instead of printing directly to (possibly-captured) stdout.

This reduces the amount of "hidden" printing in error-reporting code, which will be helpful when overhauling compiletest's error handling and output capture.

Zalathar · 2025-08-03T03:49:47Z

Rebased to resolve conflicts with #144747.

@bors r=jieyouxu

bors · 2025-08-03T03:49:50Z

📌 Commit 1063b0f has been approved by jieyouxu

It is now in the queue for this repository.

compiletest: Preliminary cleanup of `ProcRes` printing/unwinding While experimenting with changes to how compiletest handles output capture, error reporting, and unwinding, I repeatedly ran in to difficulties with this core code for reporting test failures caused by a subprocess. There should be no change in compiletest output. r? jieyouxu

Rollup of 13 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #144070 (Implement `hash_map` macro ) - #144322 (Add lint against dangling pointers from local variables) - #144667 (`AlignmentEnum` should just be `repr(usize)` now) - #144678 (Make no_mangle on foreign items explicit instead of implicit) - #144790 (Multiple bounds checking elision failures) - #144794 (Port `#[coroutine]` to the new attribute system) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) r? `@ghost` `@rustbot` modify labels: rollup

compiletest: Preliminary cleanup of `ProcRes` printing/unwinding While experimenting with changes to how compiletest handles output capture, error reporting, and unwinding, I repeatedly ran in to difficulties with this core code for reporting test failures caused by a subprocess. There should be no change in compiletest output. r? jieyouxu

Rollup of 13 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #144070 (Implement `hash_map` macro ) - #144322 (Add lint against dangling pointers from local variables) - #144667 (`AlignmentEnum` should just be `repr(usize)` now) - #144706 (Do not give function allocations alignment in consteval and Miri.) - #144790 (Multiple bounds checking elision failures) - #144794 (Port `#[coroutine]` to the new attribute system) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) r? `@ghost` `@rustbot` modify labels: rollup

compiletest: Preliminary cleanup of `ProcRes` printing/unwinding While experimenting with changes to how compiletest handles output capture, error reporting, and unwinding, I repeatedly ran in to difficulties with this core code for reporting test failures caused by a subprocess. There should be no change in compiletest output. r? jieyouxu

Rollup of 11 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144650 (Additional tce tests) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) Failed merges: - #144794 (Port `#[coroutine]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup

compiletest: Preliminary cleanup of `ProcRes` printing/unwinding While experimenting with changes to how compiletest handles output capture, error reporting, and unwinding, I repeatedly ran in to difficulties with this core code for reporting test failures caused by a subprocess. There should be no change in compiletest output. r? jieyouxu

Rollup of 12 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144070 (Implement `hash_map` macro ) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) - #144851 (Forbid tail calling intrinsics) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144805 - Zalathar:proc-res, r=jieyouxu compiletest: Preliminary cleanup of `ProcRes` printing/unwinding While experimenting with changes to how compiletest handles output capture, error reporting, and unwinding, I repeatedly ran in to difficulties with this core code for reporting test failures caused by a subprocess. There should be no change in compiletest output. r? jieyouxu

Rollup of 12 pull requests Successful merges: - rust-lang/rust#142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - rust-lang/rust#144070 (Implement `hash_map` macro ) - rust-lang/rust#144738 (Remove the omit_gdb_pretty_printer_section attribute) - rust-lang/rust#144790 (Multiple bounds checking elision failures) - rust-lang/rust#144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - rust-lang/rust#144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - rust-lang/rust#144816 (Update E0562 to account for the new impl trait positions) - rust-lang/rust#144822 (Return a struct with named fields from `hash_owner_nodes`) - rust-lang/rust#144824 (Updated test links in compiler) - rust-lang/rust#144829 (Use full flag name in strip command for Darwin) - rust-lang/rust#144843 (Weekly `cargo update`) - rust-lang/rust#144851 (Forbid tail calling intrinsics) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Aug 2, 2025

jieyouxu approved these changes Aug 2, 2025
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2025

samueltardieu mentioned this pull request Aug 2, 2025
Rollup of 18 pull requests #144810
Closed

Zalathar added 3 commits August 3, 2025 13:38

Change ProcRes::print_info to format_info
2ddf0ca
This method now returns a string instead of printing directly to (possibly-captured) stdout.

Consolidate all ProcRes unwinds into one code path
d1d44d4

Change TestCx::error to error_prefix, which returns a string
1063b0f
This reduces the amount of "hidden" printing in error-reporting code, which will be helpful when overhauling compiletest's error handling and output capture.

Zalathar force-pushed the proc-res branch from b178525 to 1063b0fCompare August 3, 2025 03:48

Zalathar mentioned this pull request Aug 3, 2025
Rollup of 13 pull requests #144846
Closed

Zalathar mentioned this pull request Aug 3, 2025
Rollup of 13 pull requests #144850
Closed

samueltardieu mentioned this pull request Aug 3, 2025
Rollup of 11 pull requests #144860
Closed

This was referenced Aug 3, 2025
Rollup of 11 pull requests #144868
Closed
Rollup of 12 pull requests #144869
Merged

bors merged commit 84b6025 into rust-lang:masterAug 4, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 4, 2025

Zalathar deleted the proc-res branch August 4, 2025 01:27

Navigation Menu

Uh oh!

Uh oh!

compiletest: Preliminary cleanup of `ProcRes` printing/unwinding - #144805

compiletest: Preliminary cleanup of `ProcRes` printing/unwinding#144805
bors merged 3 commits into
rust-lang:masterfrom
Zalathar:proc-res

Zalathar commented Aug 2, 2025

Uh oh!

rustbot commented Aug 2, 2025

Uh oh!

rustbot commented Aug 2, 2025

Uh oh!

jieyouxu left a comment

Uh oh!

jieyouxu commented Aug 2, 2025

Uh oh!

bors commented Aug 2, 2025

Uh oh!

jieyouxu commented Aug 2, 2025

Uh oh!

Zalathar commented Aug 3, 2025

Uh oh!

bors commented Aug 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Aug 2, 2025

Uh oh!

rustbot commented Aug 2, 2025

Uh oh!

rustbot commented Aug 2, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 2, 2025

Uh oh!

bors commented Aug 2, 2025

Uh oh!

jieyouxu commented Aug 2, 2025

Uh oh!

Zalathar commented Aug 3, 2025

Uh oh!

bors commented Aug 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants