Skip to content

Fix some crash-test directives - #147122

Merged
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:crash-directives
Sep 29, 2025
Merged

Fix some crash-test directives#147122
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:crash-directives

Conversation

@Zalathar

@ZalatharZalathar commented Sep 28, 2025•
edited
Loading

Copy link
Copy Markdown
Member
  • 120175 fails to crash for non-ELF targets; presumably this wasn't noticed because the CI jobs don't enable rustc assertions for non-ELF hosts.
  • 34127, 125722, and 131292 have only-x86_64, which is overly specific.
    • Unnecessary x86 directives cause friction for contributors using aarch64, especially now that many PR CI jobs also use aarch64.

r? ghost

@rustbot

rustbot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2025
@Zalathar

Zalathar commented Sep 28, 2025

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=aarch64-apple,aarch64-msvc-1,test-various,i686-gnu-1,i686-msvc-1

rust-borsBot added a commit that referenced this pull request Sep 28, 2025
@rust-bors
Auto merge of#147122- Zalathar:crash-directives, r=<try>
c5ca529
Fix some crash-test directives
try-job: aarch64-apple
try-job: aarch64-msvc-1
try-job: test-various
try-job: i686-gnu-1
try-job: i686-msvc-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-langrust-lang deleted a comment from rust-borsBotSep 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-borsBot commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

💔 Test for c5ca529 failed: CI. Failed jobs:

@Zalathar

Zalathar commented Sep 28, 2025

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=aarch64-msvc-1,test-various,i686-gnu-1,i686-msvc-1

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot added a commit that referenced this pull request Sep 28, 2025
@rust-bors
Auto merge of#147122- Zalathar:crash-directives, r=<try>
2453306
Fix some crash-test directives
try-job: aarch64-msvc-1
try-job: test-various
try-job: i686-gnu-1
try-job: i686-msvc-1
@rust-bors

rust-borsBot commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 2453306 (2453306c3d5eb6553917bf5f7b328b41d16f2092, parent: 4ffeda10e10d4fa0c8edbd0dd9642d8ae7d3e66e)

@cjgillot

cjgillot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

r=me once you're convinced by CI

@rustbot

rustbot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Zalathar

Zalathar commented Sep 29, 2025

Copy link
Copy Markdown
MemberAuthor

Removed the changes to tests/crashes/120175.rs, because #146513 did a more accurate job of updating that test.

@bors r=cjgillot rollup

@bors

bors commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit b71c469 has been approved by cjgillot

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2025
@ZalatharZalathar mentioned this pull request Sep 29, 2025
Merged
bors added a commit that referenced this pull request Sep 29, 2025
@bors
Auto merge of#147140- Zalathar:rollup-rtnqek7, r=Zalathar
7af913f
Rollup of 7 pull requests
Successful merges:
- #133477 (Detect tuple structs that are unconstructable due to re-export)
- #146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- #146979 (constify Default on Nanoseconds)
- #147092 (Do not compute optimized MIR if code does not type-check.)
- #147112 (all 48 keywords in just 300 characters)
- #147122 (Fix some crash-test directives)
- #147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1ef1d3b into rust-lang:masterSep 29, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 29, 2025
rust-timer added a commit that referenced this pull request Sep 29, 2025
@rust-timer
Unrolled build for#147122
5abe50e
Rollup merge of #147122 - Zalathar:crash-directives, r=cjgillot
Fix some crash-test directives
- 120175 fails to crash for non-ELF targets; presumably this wasn't noticed because the CI jobs don't enable rustc assertions for non-ELF hosts.
- 34127, 125722, and 131292 have `only-x86_64`, which is overly specific.
- Unnecessary x86 directives cause friction for contributors using aarch64, especially now that many PR CI jobs also use aarch64.
r? ghost
@Zalathar
Zalathar deleted the crash-directives branch September 29, 2025 08:52
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@bors
Auto merge ofrust-lang#147140- Zalathar:rollup-rtnqek7, r=Zalathar
1051518
Rollup of 7 pull requests
Successful merges:
- rust-lang#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang#146979 (constify Default on Nanoseconds)
- rust-lang#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang#147112 (all 48 keywords in just 300 characters)
- rust-lang#147122 (Fix some crash-test directives)
- rust-lang#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #147140 - Zalathar:rollup-rtnqek7, r=Zalathar
29f714f
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang/rust#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang/rust#146979 (constify Default on Nanoseconds)
- rust-lang/rust#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang/rust#147112 (all 48 keywords in just 300 characters)
- rust-lang/rust#147122 (Fix some crash-test directives)
- rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #147140 - Zalathar:rollup-rtnqek7, r=Zalathar
c4f246f
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang/rust#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang/rust#146979 (constify Default on Nanoseconds)
- rust-lang/rust#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang/rust#147112 (all 48 keywords in just 300 characters)
- rust-lang/rust#147122 (Fix some crash-test directives)
- rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147140 - Zalathar:rollup-rtnqek7, r=Zalathar
75fe70c
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang/rust#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang/rust#146979 (constify Default on Nanoseconds)
- rust-lang/rust#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang/rust#147112 (all 48 keywords in just 300 characters)
- rust-lang/rust#147122 (Fix some crash-test directives)
- rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147140 - Zalathar:rollup-rtnqek7, r=Zalathar
c0a881a
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang/rust#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang/rust#146979 (constify Default on Nanoseconds)
- rust-lang/rust#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang/rust#147112 (all 48 keywords in just 300 characters)
- rust-lang/rust#147122 (Fix some crash-test directives)
- rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Zalathar@rustbot@rust-log-analyzer@cjgillot@bors