Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #147140
Merged
Merged
Conversation
When a tuple-struct is re-exported that has inaccessible fields at the `use` scope, the type's constructor cannot be accessed through that re-export. We now account for this case and extend the resulting resolution error. We also check if the constructor would be accessible directly, not through the re-export, and if so, we suggest using the full path instead. ``` error[E0423]: cannot initialize a tuple struct which contains private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:12:33 | LL | let crate::Foo(x) = crate::Foo(42); | ^^^^^^^^^^ | note: the type is accessed through this re-export, but the type's constructor is not visible in this import's scope due to private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:3:9 | LL | pub use my_mod::Foo; | ^^^^^^^^^^^ help: the type can be constructed directly, because its fields are available from the current scope | LL | let crate::Foo(x) = crate::my_mod::Foo(42); | ~~~~~~~~~~~~~~~~~~ ``` Fixrust-lang#133343.
Detect tuple structs that are unconstructable due to re-export When a tuple-struct is re-exported that has inaccessible fields at the `use` scope, the type's constructor cannot be accessed through that re-export. We now account for this case and extend the resulting resolution error. We also check if the constructor would be accessible directly, not through the re-export, and if so, we suggest using the full path instead. ``` error[E0423]: cannot initialize a tuple struct which contains private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:12:33 | LL | let crate::Foo(x) = crate::Foo(42); | ^^^^^^^^^^ | note: the type is accessed through this re-export, but the type's constructor is not visible in this import's scope due to private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:3:9 | LL | pub use my_mod::Foo; | ^^^^^^^^^^^ help: the type can be constructed directly, because its fields are available from the current scope | LL | let crate::Foo(x) = crate::my_mod::Foo(42); | ~~~~~~~~~~~~~~~~~~ ``` Fixrust-lang#133343.
compiletest: Remove old-output-capture and become a stage0 bootstrap tool The new compiletest output-capture system became the default in rust-lang#146574, and no problems have been reported since. This PR therefore removes the old output-capture implementation from compiletest, and adjusts bootstrap to always build and test compiletest as a stage0 bootstrap tool. In other words, compiletest no longer relies on any unstable features (such as `libtest` or `internal_output_capture`), and is now written entirely in stable Rust! The compiletest self-tests still need access to an in-tree rustc, in order to obtain information via `rustc --print`, so we interpret `--stage` as indicating the stage of that secondary compiler, but always use the stage0 compiler to build compiletest itself. r? Kobzol
…crum constify Default on Nanoseconds
…iler-errors Do not compute optimized MIR if code does not type-check. Since rust-lang#128612, we compute optimized MIR when `-Zvalidate-mir` is present. This is done as part of required analyses, even if type-checking fails. This causes ICEs, as most of the mir-opt pipeline expects well-formed code. Fixesrust-lang#129095Fixesrust-lang#134174Fixesrust-lang#134654Fixesrust-lang#135570Fixesrust-lang#136381Fixesrust-lang#137468Fixesrust-lang#144491Fixesrust-lang#147011 This does not fix issue rust-lang#137190, as it ICEs without `-Zvalidate-mir`. r? ``@compiler-errors``
all 48 keywords in just 300 characters new test case in, all 48 keywords in just 300 characters https://doc.rust-lang.org/reference/keywords.html
Fix some crash-test directives - 120175 fails to crash for non-ELF targets; presumably this wasn't noticed because the CI jobs don't enable rustc assertions for non-ELF hosts. - 34127, 125722, and 131292 have `only-x86_64`, which is overly specific. - Unnecessary x86 directives cause friction for contributors using aarch64, especially now that many PR CI jobs also use aarch64. r? ghost
…orn3 Add a leading dash to linker plugin arguments in the gcc codegen Fixrust-lang#130583 r? ``@bjorn3``
Zalathar
commented
Sep 29, 2025
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Sep 29, 2025
Collaborator
bors
commented
Sep 29, 2025
Collaborator
bors
commented
Sep 29, 2025
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Sep 29, 2025
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 772f380092 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 772f380 (parent) -> 7af913f (this PR) Test differencesShow 155 test diffsStage 0
Stage 1
Stage 2
(and 55 additional test diffs) Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7af913fc90968844286e5ff6675ab66afa98cdc6 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
rust-timer
commented
Sep 29, 2025
Collaborator
Finished benchmarking commit (7af913f): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.6%, secondary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -4.2%, secondary -1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 469.945s -> 469.301s (-0.14%) |
panstromek
commented
Oct 6, 2025
Contributor
perf triage: Based on perf runs on respective PRs, this seems to be #133477. #147092 was tested but regressions on that are noise and don't match this PR. Other PR's don't touch benchmarked code. This could also be noise, since the results somewhat fit a bimodal pattern and changes are tiny, but detailed results show increases in number of executed visibility related queries. I left a comment on #133477 @rustbot label: +perf-regression-triaged |
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Oct 9, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#133477 (Detect tuple structs that are unconstructable due to re-export) - rust-lang#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool) - rust-lang#146979 (constify Default on Nanoseconds) - rust-lang#147092 (Do not compute optimized MIR if code does not type-check.) - rust-lang#147112 (all 48 keywords in just 300 characters) - rust-lang#147122 (Fix some crash-test directives) - rust-lang#147127 (Add a leading dash to linker plugin arguments in the gcc codegen) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup