Skip to content

Add a leading dash to linker plugin arguments in the gcc codegen - #147127

Merged
bors merged 1 commit into
rust-lang:masterfrom
antoyo:fix/gcc-linker-plugin
Sep 29, 2025
Merged

Add a leading dash to linker plugin arguments in the gcc codegen#147127
bors merged 1 commit into
rust-lang:masterfrom
antoyo:fix/gcc-linker-plugin

Conversation

@antoyo

@antoyoantoyo commented Sep 28, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

@rustbot

rustbot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2025
@antoyo

antoyo commented Sep 28, 2025

Copy link
Copy Markdown
ContributorAuthor

I am unable to test that this actually works since a get a segfault in GCC that I have a hard time reproducing when not running cargo, so I'm not sure how to debug.
My attempts at running the commands manually seem to work, so there's something weird going on here.

I suggest anyway that we start with this: maybe I'll be able to get further on the cg_gcc side.

@antoyo
antoyoforce-pushed the fix/gcc-linker-plugin branch from 4535bde to 5aa7fb7CompareSeptember 28, 2025 16:16
bjorn3
bjorn3 approved these changes Sep 28, 2025
View reviewed changes

@bjorn3bjorn3 left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the suggestions applied

View changes since this review

Comment threadcompiler/rustc_codegen_ssa/src/traits/backend.rs
Comment threadcompiler/rustc_codegen_ssa/src/back/linker.rs Outdated
@antoyo
antoyoforce-pushed the fix/gcc-linker-plugin branch from 5aa7fb7 to 7fcbc5eCompareSeptember 28, 2025 17:57
@bjorn3

bjorn3 commented Sep 28, 2025

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7fcbc5e has been approved by bjorn3

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 29, 2025
@Zalathar
Rollup merge ofrust-lang#147127- antoyo:fix/gcc-linker-plugin, r=bj…
2cc598f
…orn3
Add a leading dash to linker plugin arguments in the gcc codegen
Fixrust-lang#130583
r? `@bjorn3`
@ZalatharZalathar mentioned this pull request Sep 29, 2025
Closed
bors added a commit that referenced this pull request Sep 29, 2025
@bors
Auto merge of#147139- Zalathar:rollup-2r4qvkh, r=Zalathar
4fa13b8
Rollup of 6 pull requests
Successful merges:
- #133477 (Detect tuple structs that are unconstructable due to re-export)
- #140916 (Fix unuseful span in type error in some format_args!() invocations)
- #146979 (constify Default on Nanoseconds)
- #147090 (Skip stack overflow handler for panic=immediate-abort)
- #147092 (Do not compute optimized MIR if code does not type-check.)
- #147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Sep 29, 2025
Merged
bors added a commit that referenced this pull request Sep 29, 2025
@bors
Auto merge of#147140- Zalathar:rollup-rtnqek7, r=Zalathar
7af913f
Rollup of 7 pull requests
Successful merges:
- #133477 (Detect tuple structs that are unconstructable due to re-export)
- #146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- #146979 (constify Default on Nanoseconds)
- #147092 (Do not compute optimized MIR if code does not type-check.)
- #147112 (all 48 keywords in just 300 characters)
- #147122 (Fix some crash-test directives)
- #147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit af8af6c into rust-lang:masterSep 29, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Sep 29, 2025
@rust-timer
Unrolled build for#147127
a1c98ef
Rollup merge of #147127 - antoyo:fix/gcc-linker-plugin, r=bjorn3
Add a leading dash to linker plugin arguments in the gcc codegen
Fix#130583
r? ``@bjorn3``
@rustbotrustbot added this to the 1.92.0 milestone Sep 29, 2025
tautschnig added a commit to tautschnig/kani that referenced this pull request Sep 30, 2025
@tautschnig
Upgrade Rust toolchain to 2025-09-30
b184f66
Relevant upstream PRs:
- rust-lang/rust#147127 (Add a leading dash to
linker plugin arguments in the gcc codegen)
Resolves: model-checking#4387
@tautschnigtautschnig mentioned this pull request Sep 30, 2025
Merged
tautschnig added a commit to tautschnig/kani that referenced this pull request Sep 30, 2025
@tautschnig
Upgrade Rust toolchain to 2025-09-30
4fcc826
Relevant upstream PRs:
- rust-lang/rust#147127 (Add a leading dash to
linker plugin arguments in the gcc codegen)
Resolves: model-checking#4387
github-merge-queueBot pushed a commit to model-checking/kani that referenced this pull request Sep 30, 2025
@tautschnig
Upgrade Rust toolchain to 2025-09-30 (#4388)
4b4a653
Relevant upstream PRs:
- rust-lang/rust#147127 (Add a leading dash to
linker plugin arguments in the gcc codegen)
Resolves: #4387
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@bors
Auto merge ofrust-lang#147140- Zalathar:rollup-rtnqek7, r=Zalathar
1051518
Rollup of 7 pull requests
Successful merges:
- rust-lang#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang#146979 (constify Default on Nanoseconds)
- rust-lang#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang#147112 (all 48 keywords in just 300 characters)
- rust-lang#147122 (Fix some crash-test directives)
- rust-lang#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request Nov 4, 2025
@Zalathar
Rollup merge ofrust-lang#147127- antoyo:fix/gcc-linker-plugin, r=bj…
867a310
…orn3
Add a leading dash to linker plugin arguments in the gcc codegen
Fixrust-lang#130583
r? ``@bjorn3``
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #147140 - Zalathar:rollup-rtnqek7, r=Zalathar
29f714f
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang/rust#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang/rust#146979 (constify Default on Nanoseconds)
- rust-lang/rust#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang/rust#147112 (all 48 keywords in just 300 characters)
- rust-lang/rust#147122 (Fix some crash-test directives)
- rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #147140 - Zalathar:rollup-rtnqek7, r=Zalathar
c4f246f
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang/rust#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang/rust#146979 (constify Default on Nanoseconds)
- rust-lang/rust#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang/rust#147112 (all 48 keywords in just 300 characters)
- rust-lang/rust#147122 (Fix some crash-test directives)
- rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147140 - Zalathar:rollup-rtnqek7, r=Zalathar
75fe70c
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang/rust#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang/rust#146979 (constify Default on Nanoseconds)
- rust-lang/rust#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang/rust#147112 (all 48 keywords in just 300 characters)
- rust-lang/rust#147122 (Fix some crash-test directives)
- rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147140 - Zalathar:rollup-rtnqek7, r=Zalathar
c0a881a
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#133477 (Detect tuple structs that are unconstructable due to re-export)
- rust-lang/rust#146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
- rust-lang/rust#146979 (constify Default on Nanoseconds)
- rust-lang/rust#147092 (Do not compute optimized MIR if code does not type-check.)
- rust-lang/rust#147112 (all 48 keywords in just 300 characters)
- rust-lang/rust#147122 (Fix some crash-test directives)
- rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3bjorn3bjorn3 approved these changes

Assignees

@bjorn3bjorn3

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

-plugin-opt linker flags require a leading dash when using GCC as a linker

4 participants

@antoyo@rustbot@bjorn3@bors