Forbid `//@ compile-flags: -Cincremental=` in tests by Zalathar · Pull Request #147221 · rust-lang/rust

Zalathar · 2025-10-01T12:21:00Z

Tests should not try to manually enable incremental compilation with -Cincremental, because that typically results in stray directories being created in the repository root.

Also, if the incremental directory is not cleared, there is a risk of interference between successive runs of the same test.

Instead, use the //@ incremental directive, which instructs compiletest to handle the details of passing -Cincremental with a fresh directory.

rustbot · 2025-10-01T12:21:05Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2025-10-01T12:21:07Z

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Zalathar · 2025-10-01T12:21:36Z

Currently blocked on #147217, which fixes the offending test.

@rustbot blocked

lqd

👍 , r=me when unblocked

View changes since this review

jieyouxu · 2025-10-01T13:29:04Z

We should also change ui tests to not run tests under... weird places, but that's for another PR.

bjorn3 · 2025-10-01T13:55:27Z

This fixes #128057.

Tests should not try to manually enable incremental compilation with `-Cincremental`, because that typically results in stray directories being created in the repository root. Instead, use the `//@ incremental` directive, which instructs compiletest to handle the details of passing `-Cincremental` with a fresh directory.

rustbot · 2025-10-02T01:52:40Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Zalathar · 2025-10-02T01:53:32Z

@bors r=lqd rollup

bors · 2025-10-02T01:53:36Z

📌 Commit 59c4dfe has been approved by lqd

It is now in the queue for this repository.

Zalathar · 2025-10-02T01:55:49Z

r? lqd

Forbid `//@ compile-flags: -Cincremental=` in tests Tests should not try to manually enable incremental compilation with `-Cincremental`, because that typically results in stray directories being created in the repository root. Also, if the incremental directory is not cleared, there is a risk of interference between successive runs of the same test. Instead, use the `//@ incremental` directive, which instructs compiletest to handle the details of passing `-Cincremental` with a fresh directory.

Rollup of 10 pull requests Successful merges: - #146281 (Support `#[rustc_align_static]` inside `thread_local!`) - #146535 (mbe: Implement `unsafe` attribute rules) - #146585 (indexing: reword help) - #147004 (Tweak handling of "struct like start" where a struct isn't supported) - #147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - #147225 (Don't enable shared memory by default with Wasm atomics) - #147227 (implement `Box::take`) - #147231 (Extending `#[rustc_force_inline]` to be applicable to inherent methods) - #147233 (Initialize llvm submodule if not already the case to run citool) - #147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Forbid `//@ compile-flags: -Cincremental=` in tests Tests should not try to manually enable incremental compilation with `-Cincremental`, because that typically results in stray directories being created in the repository root. Also, if the incremental directory is not cleared, there is a risk of interference between successive runs of the same test. Instead, use the `//@ incremental` directive, which instructs compiletest to handle the details of passing `-Cincremental` with a fresh directory.

Rollup of 9 pull requests Successful merges: - #146281 (Support `#[rustc_align_static]` inside `thread_local!`) - #146535 (mbe: Implement `unsafe` attribute rules) - #146585 (indexing: reword help) - #147004 (Tweak handling of "struct like start" where a struct isn't supported) - #147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - #147225 (Don't enable shared memory by default with Wasm atomics) - #147227 (implement `Box::take`) - #147233 (Initialize llvm submodule if not already the case to run citool) - #147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147221 - Zalathar:incremental, r=lqd Forbid `//@ compile-flags: -Cincremental=` in tests Tests should not try to manually enable incremental compilation with `-Cincremental`, because that typically results in stray directories being created in the repository root. Also, if the incremental directory is not cleared, there is a risk of interference between successive runs of the same test. Instead, use the `//@ incremental` directive, which instructs compiletest to handle the details of passing `-Cincremental` with a fresh directory.

Rollup of 9 pull requests Successful merges: - rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`) - rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules) - rust-lang/rust#146585 (indexing: reword help) - rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported) - rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics) - rust-lang/rust#147227 (implement `Box::take`) - rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool) - rust-lang/rust#147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Forbid `//@ compile-flags: -Cincremental=` in tests Tests should not try to manually enable incremental compilation with `-Cincremental`, because that typically results in stray directories being created in the repository root. Also, if the incremental directory is not cleared, there is a risk of interference between successive runs of the same test. Instead, use the `//@ incremental` directive, which instructs compiletest to handle the details of passing `-Cincremental` with a fresh directory.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#146281 (Support `#[rustc_align_static]` inside `thread_local!`) - rust-lang#146535 (mbe: Implement `unsafe` attribute rules) - rust-lang#146585 (indexing: reword help) - rust-lang#147004 (Tweak handling of "struct like start" where a struct isn't supported) - rust-lang#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - rust-lang#147225 (Don't enable shared memory by default with Wasm atomics) - rust-lang#147227 (implement `Box::take`) - rust-lang#147233 (Initialize llvm submodule if not already the case to run citool) - rust-lang#147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Forbid `//@ compile-flags: -Cincremental=` in tests Tests should not try to manually enable incremental compilation with `-Cincremental`, because that typically results in stray directories being created in the repository root. Also, if the incremental directory is not cleared, there is a risk of interference between successive runs of the same test. Instead, use the `//@ incremental` directive, which instructs compiletest to handle the details of passing `-Cincremental` with a fresh directory.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#146281 (Support `#[rustc_align_static]` inside `thread_local!`) - rust-lang#146535 (mbe: Implement `unsafe` attribute rules) - rust-lang#146585 (indexing: reword help) - rust-lang#147004 (Tweak handling of "struct like start" where a struct isn't supported) - rust-lang#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - rust-lang#147225 (Don't enable shared memory by default with Wasm atomics) - rust-lang#147227 (implement `Box::take`) - rust-lang#147233 (Initialize llvm submodule if not already the case to run citool) - rust-lang#147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`) - rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules) - rust-lang/rust#146585 (indexing: reword help) - rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported) - rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics) - rust-lang/rust#147227 (implement `Box::take`) - rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool) - rust-lang/rust#147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned SparrowLii Oct 1, 2025

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2025

lqd approved these changes Oct 1, 2025
View reviewed changes

This comment has been minimized.
Sign in to view

cyrgani linked an issue Oct 1, 2025 that may be closed by this pull request
compiletest: -Cincremental in ui tests dump incr build output to source directories #128057
Closed

Zalathar force-pushed the incremental branch from 7bc2241 to 59c4dfeCompare October 2, 2025 01:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 2, 2025

rustbot assigned lqd and unassigned SparrowLii Oct 2, 2025

Zalathar mentioned this pull request Oct 2, 2025
Rollup of 10 pull requests #147253
Closed

matthiaskrgr mentioned this pull request Oct 2, 2025
Rollup of 9 pull requests #147256
Closed

jhpratt mentioned this pull request Oct 2, 2025
Rollup of 10 pull requests #147260
Closed

matthiaskrgr mentioned this pull request Oct 2, 2025
Rollup of 9 pull requests #147261
Merged

bors merged commit b78b107 into rust-lang:masterOct 2, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Oct 2, 2025

Zalathar deleted the incremental branch October 2, 2025 23:06

github-actionsBot mentioned this pull request Oct 3, 2025
Toolchain upgrade to nightly-2025-10-09 flux-rs/flux#1271
Merged

Navigation Menu

Uh oh!

Uh oh!

Forbid `//@ compile-flags: -Cincremental=` in tests - #147221

Forbid `//@ compile-flags: -Cincremental=` in tests#147221
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:incremental

Zalathar commented Oct 1, 2025•
edited
Loading

Uh oh!

rustbot commented Oct 1, 2025

Uh oh!

rustbot commented Oct 1, 2025

Uh oh!

Zalathar commented Oct 1, 2025

Uh oh!

lqd left a comment •
edited
Loading

Uh oh!

This comment has been minimized.

jieyouxu commented Oct 1, 2025

Uh oh!

bjorn3 commented Oct 1, 2025

Uh oh!

rustbot commented Oct 2, 2025

Uh oh!

Zalathar commented Oct 2, 2025

Uh oh!

bors commented Oct 2, 2025

Uh oh!

Zalathar commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Oct 1, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 1, 2025

Uh oh!

rustbot commented Oct 1, 2025

Uh oh!

Zalathar commented Oct 1, 2025

Uh oh!

lqd left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

jieyouxu commented Oct 1, 2025

Uh oh!

bjorn3 commented Oct 1, 2025

Uh oh!

rustbot commented Oct 2, 2025

Uh oh!

Zalathar commented Oct 2, 2025

Uh oh!

bors commented Oct 2, 2025

Uh oh!

Zalathar commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Zalathar commented Oct 1, 2025•
edited
Loading

lqd left a comment •
edited
Loading