implement `Box::take` - #147227

Merged

bors merged 1 commit into

rust-lang:masterfrom

edwloef:box_take

Oct 2, 2025

edwloef commented Oct 1, 2025

Contributor

Tracking issue: #147212

I'm not entirely sure about the wording of the doc comment, if anyone has any suggestions that'd be great :)

rustbot assigned joboet

rustbot added S-waiting-on-review T-libs labels

rustbot commented Oct 1, 2025

Collaborator

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

edwloef mentioned this pull request

Tracking Issue for Box::take#147212

Open

4 tasks

rust-lang deleted a comment from bors

joboet reviewed

View reviewed changes

joboet left a comment •
edited by rustbot
Loading

Member

The current wording is great! I'd maybe add a note (and a line in the example) about using Box::write to reinitialise the Box, as these functions are meant to be used together.

View changes since this review

implement Box::take

8dfea22

camsteffen reviewed

View reviewed changes

library/alloc/src/boxed.rs

+ let (raw, alloc) = Box::into_raw_with_allocator(boxed);
+ let value = raw.read();
+ let uninit = Box::from_raw_in(raw.cast::<mem::MaybeUninit<T>>(), alloc);
+ (value, uninit)

camsteffenOct 1, 2025

Contributor

Could you use Box::into_non_null_with_allocator and NonNull::cast_uninit?

edwloefOct 2, 2025

ContributorAuthor

Sure! However since this has already been r+'ed, I think I'll save that change for the inevitable renaming of the function, since as far as I can tell the semantics are identical from the outside.

Qelxiros mentioned this pull request

smart pointer (try_)map #144420

Merged

joboet commented Oct 1, 2025

Member

Thanks!
@bors r+ rollup

bors commented Oct 1, 2025

Collaborator

📌 Commit 8dfea22 has been approved by joboet

It is now in the queue for this repository.

bors added S-waiting-on-bors and removed S-waiting-on-review labels

Zalathar added a commit to Zalathar/rust that referenced this pull request

Rollup merge ofrust-lang#147227- edwloef:box_take, r=joboet

3c117b3

implement `Box::take`
Tracking issue: rust-lang#147212
I'm not entirely sure about the wording of the doc comment, if anyone has any suggestions that'd be great :)

Zalathar mentioned this pull request

Rollup of 10 pull requests #147253

Closed

bors added a commit that referenced this pull request

Auto merge of#147253- Zalathar:rollup-1yk4sc5, r=Zalathar

a9f0a72

Rollup of 10 pull requests
Successful merges:
- #146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- #146535 (mbe: Implement `unsafe` attribute rules)
- #146585 (indexing: reword help)
- #147004 (Tweak handling of "struct like start" where a struct isn't supported)
- #147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- #147225 (Don't enable shared memory by default with Wasm atomics)
- #147227 (implement `Box::take`)
- #147231 (Extending `#[rustc_force_inline]` to be applicable to inherent methods)
- #147233 (Initialize llvm submodule if not already the case to run citool)
- #147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#147227- edwloef:box_take, r=joboet

3f952f1

implement `Box::take`
Tracking issue: rust-lang#147212
I'm not entirely sure about the wording of the doc comment, if anyone has any suggestions that'd be great :)

matthiaskrgr mentioned this pull request

Rollup of 9 pull requests #147256

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request

Rollup merge ofrust-lang#147227- edwloef:box_take, r=joboet

fa0690b

implement `Box::take`
Tracking issue: rust-lang#147212
I'm not entirely sure about the wording of the doc comment, if anyone has any suggestions that'd be great :)

jhpratt mentioned this pull request

Rollup of 10 pull requests #147260

Closed

matthiaskrgr mentioned this pull request

Rollup of 9 pull requests #147261

Merged

bors added a commit that referenced this pull request

Auto merge of#147261- matthiaskrgr:rollup-yh3fgvc, r=matthiaskrgr

94ecb52

Rollup of 9 pull requests
Successful merges:
- #146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- #146535 (mbe: Implement `unsafe` attribute rules)
- #146585 (indexing: reword help)
- #147004 (Tweak handling of "struct like start" where a struct isn't supported)
- #147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- #147225 (Don't enable shared memory by default with Wasm atomics)
- #147227 (implement `Box::take`)
- #147233 (Initialize llvm submodule if not already the case to run citool)
- #147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

bors merged commit fbe6834 into rust-lang:master

10 checks passed

rustbot added this to the 1.92.0 milestone

rust-timer added a commit that referenced this pull request

Unrolled build for#147227

5d2eee8

Rollup merge of #147227 - edwloef:box_take, r=joboet
implement `Box::take`
Tracking issue: #147212
I'm not entirely sure about the wording of the doc comment, if anyone has any suggestions that'd be great :)

edwloef deleted the box_take branch

October 2, 2025 20:47

github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request

Auto merge of #147261 - matthiaskrgr:rollup-yh3fgvc, r=matthiaskrgr

2dc5a03

Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules)
- rust-lang/rust#146585 (indexing: reword help)
- rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported)
- rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics)
- rust-lang/rust#147227 (implement `Box::take`)
- rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool)
- rust-lang/rust#147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

github-actionsBot mentioned this pull request

Toolchain upgrade to nightly-2025-10-09 flux-rs/flux#1271

Merged

github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Rollup merge ofrust-lang#147227- edwloef:box_take, r=joboet

c11ef47

implement `Box::take`
Tracking issue: rust-lang#147212
I'm not entirely sure about the wording of the doc comment, if anyone has any suggestions that'd be great :)

rust-cloud-vmsBot pushed a commit to makai410/rustc_public that referenced this pull request

Auto merge of #147261 - matthiaskrgr:rollup-yh3fgvc, r=matthiaskrgr

18ef0ab

Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules)
- rust-lang/rust#146585 (indexing: reword help)
- rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported)
- rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics)
- rust-lang/rust#147227 (implement `Box::take`)
- rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool)
- rust-lang/rust#147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request

Auto merge of #147261 - matthiaskrgr:rollup-yh3fgvc, r=matthiaskrgr

51b8e57

Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules)
- rust-lang/rust#146585 (indexing: reword help)
- rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported)
- rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics)
- rust-lang/rust#147227 (implement `Box::take`)
- rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool)
- rust-lang/rust#147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

makai410 pushed a commit to makai410/rust that referenced this pull request

Rollup merge ofrust-lang#147227- edwloef:box_take, r=joboet

9404b72

implement `Box::take`
Tracking issue: rust-lang#147212
I'm not entirely sure about the wording of the doc comment, if anyone has any suggestions that'd be great :)

makai410 pushed a commit to makai410/rust that referenced this pull request

Auto merge ofrust-lang#147261- matthiaskrgr:rollup-yh3fgvc, r=matth…

1910099

…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- rust-lang#146535 (mbe: Implement `unsafe` attribute rules)
- rust-lang#146585 (indexing: reword help)
- rust-lang#147004 (Tweak handling of "struct like start" where a struct isn't supported)
- rust-lang#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- rust-lang#147225 (Don't enable shared memory by default with Wasm atomics)
- rust-lang#147227 (implement `Box::take`)
- rust-lang#147233 (Initialize llvm submodule if not already the case to run citool)
- rust-lang#147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

makai410 pushed a commit to makai410/rust that referenced this pull request

Rollup merge ofrust-lang#147227- edwloef:box_take, r=joboet

be12ed0

implement `Box::take`
Tracking issue: rust-lang#147212
I'm not entirely sure about the wording of the doc comment, if anyone has any suggestions that'd be great :)

makai410 pushed a commit to makai410/rust that referenced this pull request

Auto merge ofrust-lang#147261- matthiaskrgr:rollup-yh3fgvc, r=matth…

0b6033d

…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- rust-lang#146535 (mbe: Implement `unsafe` attribute rules)
- rust-lang#146585 (indexing: reword help)
- rust-lang#147004 (Tweak handling of "struct like start" where a struct isn't supported)
- rust-lang#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- rust-lang#147225 (Don't enable shared memory by default with Wasm atomics)
- rust-lang#147227 (implement `Box::take`)
- rust-lang#147233 (Initialize llvm submodule if not already the case to run citool)
- rust-lang#147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

edwloef mentioned this pull request

Refactor Box::take#148867

Merged

Zalathar added a commit to Zalathar/rust that referenced this pull request

Rollup merge ofrust-lang#148867- edwloef:refactor-box-take, r=joboet

4d32047

Refactor `Box::take`
as per rust-lang#147227 (comment)

Zalathar added a commit to Zalathar/rust that referenced this pull request

Rollup merge ofrust-lang#148867- edwloef:refactor-box-take, r=joboet

ffcbeab

Refactor `Box::take`
as per rust-lang#147227 (comment)

Zalathar added a commit to Zalathar/rust that referenced this pull request

Rollup merge ofrust-lang#148867- edwloef:refactor-box-take, r=joboet

34de4ac

Refactor `Box::take`
as per rust-lang#147227 (comment)

Zalathar added a commit to Zalathar/rust that referenced this pull request

Rollup merge ofrust-lang#148867- edwloef:refactor-box-take, r=joboet

ad91711

Refactor `Box::take`
as per rust-lang#147227 (comment)

rust-timer added a commit that referenced this pull request

Unrolled build for#148867

0fd9213

Rollup merge of #148867 - edwloef:refactor-box-take, r=joboet
Refactor `Box::take`
as per #147227 (comment)

makai410 pushed a commit to makai410/rustc_public that referenced this pull request

Auto merge of #147261 - matthiaskrgr:rollup-yh3fgvc, r=matthiaskrgr

f3b87db

Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules)
- rust-lang/rust#146585 (indexing: reword help)
- rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported)
- rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics)
- rust-lang/rust#147227 (implement `Box::take`)
- rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool)
- rust-lang/rust#147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Rollup merge ofrust-lang#148867- edwloef:refactor-box-take, r=joboet

871a4b3

Refactor `Box::take`
as per rust-lang#147227 (comment)

makai410 pushed a commit to makai410/rustc_public that referenced this pull request

Auto merge of #147261 - matthiaskrgr:rollup-yh3fgvc, r=matthiaskrgr

c6af5de

Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`)
- rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules)
- rust-lang/rust#146585 (indexing: reword help)
- rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported)
- rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests)
- rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics)
- rust-lang/rust#147227 (implement `Box::take`)
- rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool)
- rust-lang/rust#147236 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsT-libs