Initialize llvm submodule if not already the case to run citool by GuillaumeGomez · Pull Request #147233 · rust-lang/rust

GuillaumeGomez · 2025-10-01T15:40:43Z

While working on #146414, I ran the following command (to run CI docker locally):

cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc

However, since I didn't have src/llvm submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience.

r? @Kobzol

Kobzol · 2025-10-01T21:31:34Z

In theory we should be initializing all the submodules to match what CI does, but I think that this is good enough. Thanks!

@bors r+ rollup

bors · 2025-10-01T21:31:38Z

📌 Commit 4baf920 has been approved by Kobzol

It is now in the queue for this repository.

…it, r=Kobzol Initialize llvm submodule if not already the case to run citool While working on rust-lang#146414, I ran the following command (to run CI docker locally): ``` cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc ``` However, since I didn't have `src/llvm` submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience. r? `@Kobzol`

Rollup of 10 pull requests Successful merges: - #146281 (Support `#[rustc_align_static]` inside `thread_local!`) - #146535 (mbe: Implement `unsafe` attribute rules) - #146585 (indexing: reword help) - #147004 (Tweak handling of "struct like start" where a struct isn't supported) - #147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - #147225 (Don't enable shared memory by default with Wasm atomics) - #147227 (implement `Box::take`) - #147231 (Extending `#[rustc_force_inline]` to be applicable to inherent methods) - #147233 (Initialize llvm submodule if not already the case to run citool) - #147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

…it, r=Kobzol Initialize llvm submodule if not already the case to run citool While working on rust-lang#146414, I ran the following command (to run CI docker locally): ``` cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc ``` However, since I didn't have `src/llvm` submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience. r? ``@Kobzol``

…it, r=Kobzol Initialize llvm submodule if not already the case to run citool While working on rust-lang#146414, I ran the following command (to run CI docker locally): ``` cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc ``` However, since I didn't have `src/llvm` submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience. r? `@Kobzol`

GuillaumeGomez · 2025-10-02T09:35:59Z

Ah I see. Gonna send a follow-up to update all submodules then.

Kobzol · 2025-10-02T09:43:00Z

Ideally we would just run the same bash script as we do on CI, or vice-versa implement the submodule sync logic in citool, to avoid having it on two places (well, three, it's also in bootstrap). But that's more work.

IMO it's not really needed to add this to citool at this point.

GuillaumeGomez · 2025-10-02T09:45:09Z

Well, it would likely take me 20 minutes to implement it so I'd say it's worth it. We can also write a standalone file to include! in both bootstrap in citool to do this to prevent code duplication.

Rollup of 9 pull requests Successful merges: - #146281 (Support `#[rustc_align_static]` inside `thread_local!`) - #146535 (mbe: Implement `unsafe` attribute rules) - #146585 (indexing: reword help) - #147004 (Tweak handling of "struct like start" where a struct isn't supported) - #147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - #147225 (Don't enable shared memory by default with Wasm atomics) - #147227 (implement `Box::take`) - #147233 (Initialize llvm submodule if not already the case to run citool) - #147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147233 - GuillaumeGomez:citool-submodule-init, r=Kobzol Initialize llvm submodule if not already the case to run citool While working on #146414, I ran the following command (to run CI docker locally): ``` cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc ``` However, since I didn't have `src/llvm` submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience. r? ``@Kobzol``

Rollup of 9 pull requests Successful merges: - rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`) - rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules) - rust-lang/rust#146585 (indexing: reword help) - rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported) - rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics) - rust-lang/rust#147227 (implement `Box::take`) - rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool) - rust-lang/rust#147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

…it, r=Kobzol Initialize llvm submodule if not already the case to run citool While working on rust-lang#146414, I ran the following command (to run CI docker locally): ``` cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc ``` However, since I didn't have `src/llvm` submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience. r? ``@Kobzol``

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#146281 (Support `#[rustc_align_static]` inside `thread_local!`) - rust-lang#146535 (mbe: Implement `unsafe` attribute rules) - rust-lang#146585 (indexing: reword help) - rust-lang#147004 (Tweak handling of "struct like start" where a struct isn't supported) - rust-lang#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - rust-lang#147225 (Don't enable shared memory by default with Wasm atomics) - rust-lang#147227 (implement `Box::take`) - rust-lang#147233 (Initialize llvm submodule if not already the case to run citool) - rust-lang#147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

…it, r=Kobzol Initialize llvm submodule if not already the case to run citool While working on rust-lang#146414, I ran the following command (to run CI docker locally): ``` cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc ``` However, since I didn't have `src/llvm` submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience. r? ``@Kobzol``

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#146281 (Support `#[rustc_align_static]` inside `thread_local!`) - rust-lang#146535 (mbe: Implement `unsafe` attribute rules) - rust-lang#146585 (indexing: reword help) - rust-lang#147004 (Tweak handling of "struct like start" where a struct isn't supported) - rust-lang#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - rust-lang#147225 (Don't enable shared memory by default with Wasm atomics) - rust-lang#147227 (implement `Box::take`) - rust-lang#147233 (Initialize llvm submodule if not already the case to run citool) - rust-lang#147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - rust-lang/rust#146281 (Support `#[rustc_align_static]` inside `thread_local!`) - rust-lang/rust#146535 (mbe: Implement `unsafe` attribute rules) - rust-lang/rust#146585 (indexing: reword help) - rust-lang/rust#147004 (Tweak handling of "struct like start" where a struct isn't supported) - rust-lang/rust#147221 (Forbid `//@ compile-flags: -Cincremental=` in tests) - rust-lang/rust#147225 (Don't enable shared memory by default with Wasm atomics) - rust-lang/rust#147227 (implement `Box::take`) - rust-lang/rust#147233 (Initialize llvm submodule if not already the case to run citool) - rust-lang/rust#147236 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez added 2 commits October 1, 2025 17:36

Switch citool to 2024 edition
6961953

Initialize llvm submodule if not already the case to run citool
4baf920

rustbot assigned Kobzol Oct 1, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2025

Zalathar mentioned this pull request Oct 2, 2025
Rollup of 10 pull requests #147253
Closed

matthiaskrgr mentioned this pull request Oct 2, 2025
Rollup of 9 pull requests #147256
Closed

jhpratt mentioned this pull request Oct 2, 2025
Rollup of 10 pull requests #147260
Closed

matthiaskrgr mentioned this pull request Oct 2, 2025
Rollup of 9 pull requests #147261
Merged

bors merged commit f4dcfa6 into rust-lang:masterOct 2, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Oct 2, 2025

GuillaumeGomez deleted the citool-submodule-init branch October 2, 2025 14:21

github-actionsBot mentioned this pull request Oct 3, 2025
Toolchain upgrade to nightly-2025-10-09 flux-rs/flux#1271
Merged

Navigation Menu

Uh oh!

Uh oh!

Initialize llvm submodule if not already the case to run citool - #147233

Initialize llvm submodule if not already the case to run citool#147233
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:citool-submodule-init

GuillaumeGomez commented Oct 1, 2025

Uh oh!

Kobzol commented Oct 1, 2025

Uh oh!

bors commented Oct 1, 2025

Uh oh!

GuillaumeGomez commented Oct 2, 2025

Uh oh!

Kobzol commented Oct 2, 2025

Uh oh!

GuillaumeGomez commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Oct 1, 2025

Uh oh!

Kobzol commented Oct 1, 2025

Uh oh!

bors commented Oct 1, 2025

Uh oh!

GuillaumeGomez commented Oct 2, 2025

Uh oh!

Kobzol commented Oct 2, 2025

Uh oh!

GuillaumeGomez commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants