Uh oh!
There was an error while loading. Please reload this page.
cg_llvm: Use helper methods for all calls to LLVMMDNodeInContext2 - #147259
Merged
Conversation
rustbot
commented
Oct 2, 2025
Collaborator
r? @nnethercote rustbot has assigned @nnethercote. Use |
nnethercote
approved these changes
Oct 2, 2025
nnethercote
commented
Oct 2, 2025
Contributor
@bors r+ rollup |
bors
commented
Oct 2, 2025
Collaborator
bors added a commit
that referenced
this pull request
Oct 3, 2025
Rollup of 6 pull requests Successful merges: - #141839 (make rust-analyzer use a dedicated build directory) - #146166 (Implement range support in `//@ edition`) - #147259 (cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2`) - #147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign) - #147268 (add arm-maintainers to various targets) - #147270 (Move doc_cfg-specific code into `cfg.rs`) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Oct 3, 2025
Rollup merge of #147259 - Zalathar:node-in-context, r=nnethercote cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2` Originally I was only planning on extracting an `md_node_in_context` method, but then I noticed that all callers of `LLVMMDNodeInContext2` could be covered by a small number of additional helper methods. There should be no change in compiler output.
Zalathar
commented
Oct 3, 2025
MemberAuthor
Bors hasn't noticed that this was merged. @bors r- |
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Oct 6, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#141839 (make rust-analyzer use a dedicated build directory) - rust-lang/rust#146166 (Implement range support in `//@ edition`) - rust-lang/rust#147259 (cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2`) - rust-lang/rust#147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign) - rust-lang/rust#147268 (add arm-maintainers to various targets) - rust-lang/rust#147270 (Move doc_cfg-specific code into `cfg.rs`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I was only planning on extracting an
md_node_in_contextmethod, but then I noticed that all callers ofLLVMMDNodeInContext2could be covered by a small number of additional helper methods.There should be no change in compiler output.