Skip to content

add arm-maintainers to various targets - #147268

Merged
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:add-arm-maintainers-to-targets
Oct 3, 2025
Merged

add arm-maintainers to various targets#147268
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:add-arm-maintainers-to-targets

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Add the @rust-lang/arm-maintainers team as maintainers to the following targets:

  • aarch64-unknown-linux-gnu
  • aarch64-unknown-none/aarch64-unknown-none-softfloat
  • aarch64-unknown-uefi
  • armv7-unknown-linux-gnueabi/armv7-unknown-linux-gnueabihf
  • armv7a-none-eabi/armv7a-none-eabihf
  • armv7r-none-eabi/armv7r-none-abihf
  • armv8r-none-eabihf
  • thumbv7em-none-eabi/thumbv7em-none-eabihf
  • thumbv7m-none-eabi
  • thumbv8m.base-none-eabi
  • thumbv8m.main-none-eabi/thumbv8m.main-none-eabihf

cc @thejpster

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@davidtwco
davidtwcoforce-pushed the add-arm-maintainers-to-targets branch from cf19522 to 5e40e7dCompareOctober 2, 2025 12:47
@rust-log-analyzer

This comment was marked as outdated.

@thejpster

Copy link
Copy Markdown
Contributor

Dodging Arm Big Endian I totally get, but no love for thumbv6m-none-eabi for the Arm Cortex-M0+?

@davidtwco

Copy link
Copy Markdown
MemberAuthor

Dodging Arm Big Endian I totally get, but no love for thumbv6m-none-eabi for the Arm Cortex-M0+?

These are all the targets we're going to add ourselves to at the moment.

@davidtwco
davidtwcoforce-pushed the add-arm-maintainers-to-targets branch from 5e40e7d to 7715c0dCompareOctober 2, 2025 14:42
lqd
lqd approved these changes Oct 2, 2025

@lqdlqd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. r=me when green (just for the hyperlinks checks)

View changes since this review

@davidtwco

Copy link
Copy Markdown
MemberAuthor

r? @lqd

@bors r+ rollup

@bors

bors commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7715c0d has been approved by davidtwco

It is now in the queue for this repository.

@rustbotrustbot assigned lqd and unassigned fee1-deadOct 2, 2025
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2025
@davidtwco

Copy link
Copy Markdown
MemberAuthor

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 2, 2025
@davidtwco

Copy link
Copy Markdown
MemberAuthor

@bors r=lqd

@bors

bors commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7715c0d has been approved by lqd

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 2, 2025
@ZalatharZalathar mentioned this pull request Oct 2, 2025
bors added a commit that referenced this pull request Oct 3, 2025
Rollup of 6 pull requests
Successful merges:
- #141839 (make rust-analyzer use a dedicated build directory)
- #146166 (Implement range support in `//@ edition`)
- #147259 (cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2`)
- #147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign)
- #147268 (add arm-maintainers to various targets)
- #147270 (Move doc_cfg-specific code into `cfg.rs`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 87c7946 into rust-lang:masterOct 3, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 3, 2025
rust-timer added a commit that referenced this pull request Oct 3, 2025
Rollup merge of #147268 - davidtwco:add-arm-maintainers-to-targets, r=lqd
add arm-maintainers to various targets
Add the ``@rust-lang/arm-maintainers`` team as maintainers to the following targets:
- `aarch64-unknown-linux-gnu`
- `aarch64-unknown-none`/`aarch64-unknown-none-softfloat`
- `aarch64-unknown-uefi`
- `armv7-unknown-linux-gnueabi`/`armv7-unknown-linux-gnueabihf`
- `armv7a-none-eabi`/`armv7a-none-eabihf`
- `armv7r-none-eabi`/`armv7r-none-abihf`
- `armv8r-none-eabihf`
- `thumbv7em-none-eabi`/`thumbv7em-none-eabihf`
- `thumbv7m-none-eabi`
- `thumbv8m.base-none-eabi`
- `thumbv8m.main-none-eabi`/`thumbv8m.main-none-eabihf`
cc `@thejpster`
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Oct 6, 2025
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#141839 (make rust-analyzer use a dedicated build directory)
- rust-lang/rust#146166 (Implement range support in `//@ edition`)
- rust-lang/rust#147259 (cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2`)
- rust-lang/rust#147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign)
- rust-lang/rust#147268 (add arm-maintainers to various targets)
- rust-lang/rust#147270 (Move doc_cfg-specific code into `cfg.rs`)
r? `@ghost`
`@rustbot` modify labels: rollup
@davidtwco
davidtwco deleted the add-arm-maintainers-to-targets branch October 6, 2025 13:08

## Target maintainers

- [@rust-lang/arm-maintainers][arm_maintainers] ([rust@arm.com][arm_email])

@RalfJungRalfJungFeb 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent was for this point to be something one can copy-paste into a github discussion to ping the right people (see #139028). That doesn't work with @rust-lang/arm-maintainers, there is no such team on Github. Any chance we could fix that? Not sure what the best way is, but manually copy-pasting 5 separate names if I need to ping ARM folks doesn't seem necessary.

@lqdlqdFeb 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to add that myself, members don't have rights to add teams to the repo; apart infra and admins, who knows whether/how team handles sync and if it could use that; and there's still the old @rustbot ping arm notification that's different from the team above...

@davidtwcodavidtwcoFeb 23, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot ping arm does include this group, and should be sufficient for pinging us, as well as others interested in helping with Arm targets. The distinction between arm-maintainers and arm is just that arm-maintainers are the people who work for Arm on Rust, but arm is a superset of arm-maintainers.

@RalfJungRalfJungFeb 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The teams repo supports GH syncs so the arm-maintainers "team" could easily be reflected as a GH group. Or we use the ping group, though if that has more people in it that didn't agree to be target maintainers maybe that overshoots?

Anyway, all I am saying is that this page should uphold the general invariant to provide a little snippet of text I can just copy-paste into github to ping the right people.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, all I am saying is that this page should uphold the general invariant to provide a little snippet of text I can just copy-paste into github to ping the right people.

Submitted #153720 to address this

davidtwco added a commit to davidtwco/rust that referenced this pull request Mar 11, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 11, 2026
… r=RalfJung
doc/rustc: clarify how to contact arm-maintainers
Addresses feedback from rust-lang#147268 (comment)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 11, 2026
… r=RalfJung
doc/rustc: clarify how to contact arm-maintainers
Addresses feedback from rust-lang#147268 (comment)
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 12, 2026
doc/rustc: clarify how to contact arm-maintainers
Addresses feedback from rust-lang/rust#147268 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@davidtwco@rustbot@rust-log-analyzer@thejpster@bors@lqd@RalfJung@fee1-dead