Uh oh!
There was an error while loading. Please reload this page.
add arm-maintainers to various targets - #147268
Conversation
rustbot
commented
Oct 2, 2025
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
rustbot
commented
Oct 2, 2025
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
This comment has been minimized.
This comment has been minimized.
cf19522 to
5e40e7dCompare
This comment was marked as outdated.
This comment was marked as outdated.
thejpster
commented
Oct 2, 2025
Dodging Arm Big Endian I totally get, but no love for |
davidtwco
commented
Oct 2, 2025
These are all the targets we're going to add ourselves to at the moment. |
Uh oh!
There was an error while loading. Please reload this page.
5e40e7d to
7715c0dComparedavidtwco
commented
Oct 2, 2025
bors
commented
Oct 2, 2025
davidtwco
commented
Oct 2, 2025
@bors r- |
davidtwco
commented
Oct 2, 2025
@bors r=lqd |
bors
commented
Oct 2, 2025
Rollup of 6 pull requests Successful merges: - #141839 (make rust-analyzer use a dedicated build directory) - #146166 (Implement range support in `//@ edition`) - #147259 (cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2`) - #147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign) - #147268 (add arm-maintainers to various targets) - #147270 (Move doc_cfg-specific code into `cfg.rs`) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
Rollup merge of #147268 - davidtwco:add-arm-maintainers-to-targets, r=lqd add arm-maintainers to various targets Add the ``@rust-lang/arm-maintainers`` team as maintainers to the following targets: - `aarch64-unknown-linux-gnu` - `aarch64-unknown-none`/`aarch64-unknown-none-softfloat` - `aarch64-unknown-uefi` - `armv7-unknown-linux-gnueabi`/`armv7-unknown-linux-gnueabihf` - `armv7a-none-eabi`/`armv7a-none-eabihf` - `armv7r-none-eabi`/`armv7r-none-abihf` - `armv8r-none-eabihf` - `thumbv7em-none-eabi`/`thumbv7em-none-eabihf` - `thumbv7m-none-eabi` - `thumbv8m.base-none-eabi` - `thumbv8m.main-none-eabi`/`thumbv8m.main-none-eabihf` cc `@thejpster`
Rollup of 6 pull requests Successful merges: - rust-lang/rust#141839 (make rust-analyzer use a dedicated build directory) - rust-lang/rust#146166 (Implement range support in `//@ edition`) - rust-lang/rust#147259 (cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2`) - rust-lang/rust#147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign) - rust-lang/rust#147268 (add arm-maintainers to various targets) - rust-lang/rust#147270 (Move doc_cfg-specific code into `cfg.rs`) r? `@ghost` `@rustbot` modify labels: rollup
| ## Target maintainers | ||
| - [@rust-lang/arm-maintainers][arm_maintainers] ([rust@arm.com][arm_email]) |
There was a problem hiding this comment.
The intent was for this point to be something one can copy-paste into a github discussion to ping the right people (see #139028). That doesn't work with @rust-lang/arm-maintainers, there is no such team on Github. Any chance we could fix that? Not sure what the best way is, but manually copy-pasting 5 separate names if I need to ping ARM folks doesn't seem necessary.
There was a problem hiding this comment.
I don't know how to add that myself, members don't have rights to add teams to the repo; apart infra and admins, who knows whether/how team handles sync and if it could use that; and there's still the old @rustbot ping arm notification that's different from the team above...
There was a problem hiding this comment.
@rustbot ping arm does include this group, and should be sufficient for pinging us, as well as others interested in helping with Arm targets. The distinction between arm-maintainers and arm is just that arm-maintainers are the people who work for Arm on Rust, but arm is a superset of arm-maintainers.
There was a problem hiding this comment.
The teams repo supports GH syncs so the arm-maintainers "team" could easily be reflected as a GH group. Or we use the ping group, though if that has more people in it that didn't agree to be target maintainers maybe that overshoots?
Anyway, all I am saying is that this page should uphold the general invariant to provide a little snippet of text I can just copy-paste into github to ping the right people.
There was a problem hiding this comment.
Anyway, all I am saying is that this page should uphold the general invariant to provide a little snippet of text I can just copy-paste into github to ping the right people.
Submitted #153720 to address this
Addresses feedback from <rust-lang#147268 (comment)>
… r=RalfJung doc/rustc: clarify how to contact arm-maintainers Addresses feedback from rust-lang#147268 (comment)
… r=RalfJung doc/rustc: clarify how to contact arm-maintainers Addresses feedback from rust-lang#147268 (comment)
doc/rustc: clarify how to contact arm-maintainers Addresses feedback from rust-lang/rust#147268 (comment)
Add the
@rust-lang/arm-maintainersteam as maintainers to the following targets:aarch64-unknown-linux-gnuaarch64-unknown-none/aarch64-unknown-none-softfloataarch64-unknown-uefiarmv7-unknown-linux-gnueabi/armv7-unknown-linux-gnueabihfarmv7a-none-eabi/armv7a-none-eabihfarmv7r-none-eabi/armv7r-none-abihfarmv8r-none-eabihfthumbv7em-none-eabi/thumbv7em-none-eabihfthumbv7m-none-eabithumbv8m.base-none-eabithumbv8m.main-none-eabi/thumbv8m.main-none-eabihfcc @thejpster