Skip to content

Trivial code cleanup in resolve - #147367

Merged
bors merged 1 commit into
rust-lang:masterfrom
chenyukang:yukang-trivial-cleanup
Oct 5, 2025
Merged

Trivial code cleanup in resolve#147367
bors merged 1 commit into
rust-lang:masterfrom
chenyukang:yukang-trivial-cleanup

Conversation

@chenyukang

@chenyukangchenyukang commented Oct 5, 2025

Copy link
Copy Markdown
Member

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2025
@rustbot

rustbot commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

jieyouxu
jieyouxu approved these changes Oct 5, 2025
View reviewed changes

@jieyouxujieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu

jieyouxu commented Oct 5, 2025

Copy link
Copy Markdown
Member

r=me once PR CI is green.

@chenyukang

chenyukang commented Oct 5, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@bors

bors commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 95445f9 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025
@ZalatharZalathar mentioned this pull request Oct 5, 2025
Merged
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of#147371- Zalathar:rollup-897uitw, r=Zalathar
bcbbdcb
Rollup of 5 pull requests
Successful merges:
- #144908 (Fix doctest output json)
- #147262 (Make #[link="dl"] an FCW rather than an error)
- #147364 (update autodiff testcases)
- #147367 (Trivial code cleanup in resolve)
- #147369 (Fill out AVR target metadata)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 94e0499 into rust-lang:masterOct 5, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 5, 2025
rust-timer added a commit that referenced this pull request Oct 5, 2025
@rust-timer
Unrolled build for#147367
941d281
Rollup merge of #147367 - chenyukang:yukang-trivial-cleanup, r=jieyouxu
Trivial code cleanup in resolve
r? `@jieyouxu`
@bors

bors commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 95445f9 with merge bcbbdcb...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

4 participants

@chenyukang@rustbot@jieyouxu@bors