Rollup of 5 pull requests by Zalathar · Pull Request #147371 · rust-lang/rust

Zalathar · 2025-10-05T11:15:08Z

Successful merges:

Fix doctest output json #144908 (Fix doctest output json)
Make #[link="dl"] an FCW rather than an error #147262 (Make #[link="dl"] an FCW rather than an error)
update autodiff testcases #147364 (update autodiff testcases)
Trivial code cleanup in resolve #147367 (Trivial code cleanup in resolve)
Fill out AVR target metadata #147369 (Fill out AVR target metadata)

r? @ghost
@rustbot modify labels: rollup

…cified

This will make `-Zbuild-std` automatically build the right crates, notably not building `std` by default, which will both be useful for users and also fix the build for https://does-it-build.noratrieb.dev.

…json, r=fmease Fix doctest output json Fixesrust-lang#144798. Hopefully it will work with the new changes in `libtest` without needing to do both at once. This PR moves the `rustdoc` merged doctest extra information directly into `libtest` to ensure they share the same rendering to prevent the bug uncovered in rust-lang#144798. cc `@lolbinary` (as you reviewed the first PR) And since we're making changes to `libtest`: r? `@Amanieu`

Make #[link="dl"] an FCW rather than an error Fixesrust-lang#147254 I forgot to implement the T-lang decision in rust-lang#143193 (comment), this implements that decision r? ``@jdonszelmann`` Can be reviewed commit-by-commit This needs a beta backport

…eyouxu update autodiff testcases unblock EnzymeAD/Enzyme#2430 (again). Just as I landed a fix for the last test, this one broke. The test should now be fine if the name mangling hash changes again. Also removed an outdated fixme that's not needed since moving autodiff to an intrinsic. The test currently just checks that it compiles, I'll add more precise checks once we actually run this in CI. r? compiler

… r=jieyouxu Trivial code cleanup in resolve r? `@jieyouxu`

Fill out AVR target metadata This will make `-Zbuild-std` automatically build the right crates, notably not building `std` by default, which will both be useful for users and also fix the build for https://does-it-build.noratrieb.dev, which currently tries to build std: http://localhost:3000/build?nightly=2025-07-12&target=avr-none&mode=std. cc `@Patryk27` but I don't think this necessarily needs your approval

Zalathar · 2025-10-05T11:15:46Z

Rollup of everything.

@bors r+ rollup=never p=5

bors · 2025-10-05T11:15:49Z

📌 Commit 21b5d6b has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-10-05T12:43:03Z

⌛ Testing commit 21b5d6b with merge bcbbdcb...

bors · 2025-10-05T15:51:55Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing bcbbdcb to master...

rust-timer · 2025-10-05T15:53:22Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#144908	Fix doctest output json	`c0c06e426bfb30327763e1a92f5b5ff0fb9b6518` (link)
#147262	Make #[link="dl"] an FCW rather than an error	`08d9bc5988b5b841dc2326019df91594ebe9a384` (link)
#147364	update autodiff testcases	`948c179938662f75bc3db7a4c1a67163752bc4a0` (link)
#147367	Trivial code cleanup in resolve	`941d2816544ac228c66ab61e45d4273564fc0ec7` (link)
#147369	Fill out AVR target metadata	`0c778ae6c94675adb771bc227cf2cfddb2d69f3b` (link)

previous master: e2c96cc06b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-05T15:54:41Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e2c96cc (parent) -> bcbbdcb (this PR)

Test differences

Show 10 test diffs

Stage 1

[run-make] tests/run-make/rustdoc-doctest-output-format: [missing] -> pass (J1)
[ui] tests/ui/attributes/link-dl.rs#allowed: [missing] -> pass (J1)
[ui] tests/ui/attributes/link-dl.rs#default_fcw: [missing] -> pass (J1)

Stage 2

[run-make] tests/run-make/rustdoc-doctest-output-format: [missing] -> ignore (ignored when cross-compiling) (J0)
[run-make] tests/run-make/rustdoc-doctest-output-format: [missing] -> pass (J2)
[ui] tests/ui/attributes/link-dl.rs#allowed: [missing] -> pass (J3)
[ui] tests/ui/attributes/link-dl.rs#default_fcw: [missing] -> pass (J3)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard bcbbdcb8522fd3cb4a8dde62313b251ab107694d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 7266.9s -> 8757.8s (20.5%)
x86_64-rust-for-linux: 2639.4s -> 3102.0s (17.5%)
x86_64-gnu-llvm-20: 2384.4s -> 2759.8s (15.7%)
x86_64-gnu-debug: 6265.2s -> 7246.1s (15.7%)
i686-gnu-nopt-1: 7098.1s -> 8014.2s (12.9%)
aarch64-gnu-llvm-20-2: 2161.1s -> 2431.7s (12.5%)
i686-gnu-1: 7320.8s -> 8211.6s (12.2%)
aarch64-gnu-debug: 3850.7s -> 4304.8s (11.8%)
dist-x86_64-apple: 6388.6s -> 7058.2s (10.5%)
x86_64-gnu-stable: 6795.1s -> 7468.1s (9.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-05T17:03:12Z

Finished benchmarking commit (bcbbdcb): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

Max RSS (memory usage)

Results (secondary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-4.2%, -2.4%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.388s -> 472.313s (0.20%)
Artifact size: 388.34 MiB -> 388.36 MiB (0.00%)

GuillaumeGomezand others added 12 commits October 3, 2025 18:02

Display merged doctests times as expected depending on the format spe…
5888945
…cified

Add failing regression test for #[link="dl"]
5c95f8b

Make #[link="dl"] a warning rather than an error
1c85a1d

solve autodiffv2.rs FIXME and make identical_fnc test more robust
7c8fe29

Add regression test for rustdoc output format
99c7959

Trivial code cleanup in resolve
95445f9

Fill out AVR target metadata
9ccaf08
This will make `-Zbuild-std` automatically build the right crates, notably not building `std` by default, which will both be useful for users and also fix the build for https://does-it-build.noratrieb.dev.

Rollup merge ofrust-lang#147367- chenyukang:yukang-trivial-cleanup,…
94e0499
… r=jieyouxu Trivial code cleanup in resolve r? `@jieyouxu`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 5, 2025

bors merged commit bcbbdcb into rust-lang:masterOct 5, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 5, 2025

Zalathar deleted the rollup-897uitw branch October 5, 2025 22:18

Navigation Menu

Uh oh!

Uh oh!

Rollup of 5 pull requests - #147371

Rollup of 5 pull requests#147371
bors merged 12 commits into
rust-lang:masterfrom
Zalathar:rollup-897uitw

Zalathar commented Oct 5, 2025•
edited by rustbot
Loading

Uh oh!

Zalathar commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 5, 2025

Uh oh!

github-actionsBot commented Oct 5, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Oct 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Oct 5, 2025• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 5, 2025

Uh oh!

github-actionsBot commented Oct 5, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 5, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Zalathar commented Oct 5, 2025•
edited by rustbot
Loading