Add Command::get_resolved_envs by schneems · Pull Request #149362 · rust-lang/rust

schneems · 2025-11-26T23:05:35Z

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

Discussed in:

Tracking issue: Introduce a interfaces to expose the current Command captured env var logic #149070 (partially closes)
ACP: Fix: Introduce an interface to expose the current Command captured env var logic libs-team#194

rustbot · 2025-11-26T23:42:28Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bors · 2025-11-27T08:59:06Z

☔ The latest upstream changes (presumably #149368) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum

r=me with nit fixed (and commit squashed for that nit)

I also added a few unresolved questions to the tracking issue but I don't think they're blockers for merging the initial implementation.

View changes since this review

bors · 2025-12-15T08:22:43Z

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

rustbot · 2026-03-02T06:42:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Mark-Simulacrum

@bors r+

View changes since this review

rust-bors · 2026-05-09T17:25:32Z

📌 Commit 5ed5b26 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…s, r=Mark-Simulacrum Add Command::get_resolved_envs This addition allows an end-user to inspect the environment variables that are visible to the process when it boots. Discussed in: - Tracking issue: rust-lang#149070 (partially closes) - ACP: rust-lang/libs-team#194

Rollup of 5 pull requests Successful merges: - #148214 (Consider `Result<T, Uninhabited>` and `ControlFlow<Uninhabited, T>` to be equivalent to `T` for must use lint) - #149362 (Add Command::get_resolved_envs) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters)

…s, r=Mark-Simulacrum Add Command::get_resolved_envs This addition allows an end-user to inspect the environment variables that are visible to the process when it boots. Discussed in: - Tracking issue: rust-lang#149070 (partially closes) - ACP: rust-lang/libs-team#194

…uwer Rollup of 10 pull requests Successful merges: - #148214 (Consider `Result<T, Uninhabited>` and `ControlFlow<Uninhabited, T>` to be equivalent to `T` for must use lint) - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller)

Rollup of 11 pull requests Successful merges: - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #156169 (Change `SwitchInt` handling in dataflow analysis.) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller) - #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)

rust-bors · 2026-05-10T03:15:12Z

⌛ Testing commit 5ed5b26 with merge ac1b714...

Workflow: https://github.com/rust-lang/rust/actions/runs/25618499543

…imulacrum Add Command::get_resolved_envs This addition allows an end-user to inspect the environment variables that are visible to the process when it boots. Discussed in: - Tracking issue: #149070 (partially closes) - ACP: rust-lang/libs-team#194

matthiaskrgr · 2026-05-10T03:28:26Z

@bors yield

rust-bors · 2026-05-10T03:28:29Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/25618499543

The next pull request likely to be tested is #156378.

Rollup of 11 pull requests Successful merges: - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #156169 (Change `SwitchInt` handling in dataflow analysis.) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller) - #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)

rust-bors · 2026-05-10T05:45:27Z

⌛ Testing commit 5ed5b26 with merge 1965cb2...

Workflow: https://github.com/rust-lang/rust/actions/runs/25621076193

…imulacrum Add Command::get_resolved_envs This addition allows an end-user to inspect the environment variables that are visible to the process when it boots. Discussed in: - Tracking issue: #149070 (partially closes) - ACP: rust-lang/libs-team#194

matthiaskrgr · 2026-05-10T06:05:44Z

@bors yield

rust-bors · 2026-05-10T06:05:48Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/25621076193

The next pull request likely to be tested is #156378.

Rollup of 11 pull requests Successful merges: - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #156169 (Change `SwitchInt` handling in dataflow analysis.) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller) - #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 26, 2025

schneems marked this pull request as ready for review November 26, 2025 23:42

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025

rustbot assigned Mark-Simulacrum Nov 26, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 26, 2025