Rollup of 11 pull requests by matthiaskrgr · Pull Request #156378 · rust-lang/rust

matthiaskrgr · 2026-05-10T01:17:05Z

Successful merges:

Add Command::get_resolved_envs #149362 (Add Command::get_resolved_envs)
Add str::word_to_titlecase() to alloc #155705 (Add str::word_to_titlecase() to alloc)
Add mention of sendfile(2) and splice(2) to fs::copy() documentation. #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.)
Update a bunch of bootstrap dependencies to remove windows-target #156006 (Update a bunch of bootstrap dependencies to remove windows-target)
Change SwitchInt handling in dataflow analysis. #156169 (Change SwitchInt handling in dataflow analysis.)
Add regression test for issue 144329 #155188 (Add regression test for issue 144329)
error on empty export_name #155515 (error on empty export_name)
validate #[link_name = "..."] & #[link(name = "...")] parameters #155817 (validate #[link_name = "..."] & #[link(name = "...")] parameters)
remove turbofish notation + use None / Some instead of Option:: (in match documentation) #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation))
mark some panicking methods around Duration as track_caller #156133 (mark some panicking methods around Duration as track_caller)
rustc_attr_parsing: add AcceptContext::expect_string_literal #156363 (rustc_attr_parsing: add AcceptContext::expect_string_literal)

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

specifically, do not allow NULL bytes and the empty string

We call `get_switch_int_data` once for the switch and then pass that data to `apply_switch_int_edge_effect` for each switch target. The only case in practice is `MaybePlacesSwitchIntData` which does an awkward thing, maintaining an index into the discriminants and updating it on each call to `apply_switch_int_edge_effect`. This commit changes things to do more work up front in `get_switch_int_data`, in order to then do less work in `apply_switch_int_edge_effect`. This avoids the need for the `variants` and `next_discr` methods and the discriminants index. Overall it's a little simpler.

* Add `str::word_to_titlecase()` to `alloc` * Address review comment

* Add mention of sendfile(2) and splice(2) to fs::copy() documentation. * Oxford comma fix

…s, r=Mark-Simulacrum Add Command::get_resolved_envs This addition allows an end-user to inspect the environment variables that are visible to the process when it boots. Discussed in: - Tracking issue: rust-lang#149070 (partially closes) - ACP: rust-lang/libs-team#194

@rustbot

… r=Mark-Simulacrum Add `str::word_to_titlecase()` to `alloc` A small addition to rust-lang#153892. Hasn't gone through ACP, so needs libs-API signoff. @rustbot label A-Unicode T-libs-api

…riplett Add mention of sendfile(2) and splice(2) to fs::copy() documentation. Fixesrust-lang#155968 by adding mention of sendfile(2) and splice(2) from io::copy()

…=Mark-Simulacrum Update a bunch of bootstrap dependencies to remove windows-target Follow up to rust-lang#155444

@cjgillot

…ff, r=cjgillot Change `SwitchInt` handling in dataflow analysis. We call `get_switch_int_data` once for the switch and then pass that data to `apply_switch_int_edge_effect` for each switch target. The only case in practice is `MaybePlacesSwitchIntData` which does an awkward thing, maintaining an index into the discriminants and updating it on each call to `apply_switch_int_edge_effect`. This commit changes things to do more work up front in `get_switch_int_data`, in order to then do less work in `apply_switch_int_edge_effect`. This avoids the need for the `variants` and `next_discr` methods and the discriminants index. Overall it's a little simpler. r? @cjgillot

…lacrum Add regression test for issue 144329 Closesrust-lang#144329.

…r=jdonszelmann error on empty `export_name` fixesrust-lang#155495 Using an empty string as the name makes LLVM make up a name. However this name can be inconsistent between compilation units, which is UB and can cause linking errors, and some parts of LLVM just crash on the empty name (see the linked issue). As far as we know there is only one valid pattern that could use this, a `#[used]` static that is not referenced by the program at all. That is not UB, but the `export_name` is not required for that to work, just normal rust name mangling would do fine. Technically this is a breaking change, but it seems unlikely that this actually breaks code in the wild that wasn't already broken. I'll leave it up to T-lang to determine what is required here (crater run, FCW, ...), but my gut feeling is that we could just merge this and nobody would notice.

…=mejrs validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters fixesrust-lang#155776fixesrust-lang#155484 specifically, do not allow NULL bytes and the empty string in `#[link_name = "..."]` and `#[link(name = "...")]`. Like some of the others I think this formally needs to be looked at by T-lang because these errors would not show up if not linking. The LLVM erorr on `#[linke_name = "\0"]` is emitted here, it is not e.g. target-specific. https://github.com/llvm/llvm-project/blob/d593279c0b2891f0b0c8af3f70a1a0383b4ad1b5/llvm/lib/IR/Value.cpp#L336-L342 On `#[link(name = "")]` we already error today. A NULL byte in `#[link(name = "\0")]` is caught by the linker (https://godbolt.org/z/vnz9sYbPs), using `#[link_name = ""]` makes LLVM generate a name (https://godbolt.org/z/1hWEo4cxf) which is not useful and likely to cause linker errors. r? jdonszelmann

…acrum remove turbofish notation + use None / Some instead of Option:: (in match documentation)

…r=Mark-Simulacrum mark some panicking methods around Duration as track_caller Currently when they panic it looks like this ``` 0.005045 ---- instant_checked_duration_since_nopanic stdout ---- 0.000039 0.000009 thread 'instant_checked_duration_since_nopanic' (2) panicked at /home/runner/work/miri-test-libstd/miri-test-libstd/rust-src-patched/library/std/src/time.rs:445:33: 0.000007 overflow when subtracting duration from instant 0.000006 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace 0.000007 note: in Miri, you may have to set `MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to have an effect ``` That's pretty useless. Also fix the panic message while we are at it.

…literal, r=JonathanBrouwer `rustc_attr_parsing`: add `AcceptContext::expect_string_literal`

Rollup of 11 pull requests Successful merges: - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #156169 (Change `SwitchInt` handling in dataflow analysis.) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller) - #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)

rust-log-analyzer · 2026-05-10T03:14:08Z

The job x86_64-gnu-llvm-21-1 failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)

test expr_store::tests::body::array_element_cfg ... ok
test expr_store::scope::tests::while_let_adds_binding ... ok
test expr_store::tests::body::async_fn_weird_param_patterns ... ok
test expr_store::tests::body::block::inner_item_smoke ... ok
error: test failed, to rerun pass `-p hir-def --lib`
Caused by:
process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/hir_def-c439368f2b64a049 '--skip=tests::smoke_test_real_sysroot_cargo' --skip=check_code_formatting -Z unstable-options --format json` (signal: 11, SIGSEGV: invalid memory reference)
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 1:05:42
local time: Sun May 10 03:13:51 UTC 2026
network time: Sun, 10 May 2026 03:13:52 GMT
##[error]Process completed with exit code 1.

rust-bors · 2026-05-10T03:15:10Z

💔 Test for 488aaf6 failed: CI. Failed job:

auto - x86_64-gnu-llvm-21-1 (web logs, enhanced plaintext logs)

matthiaskrgr · 2026-05-10T03:27:52Z

@bors retry

Rollup of 11 pull requests Successful merges: - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #156169 (Change `SwitchInt` handling in dataflow analysis.) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller) - #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)

rust-log-analyzer · 2026-05-10T05:44:49Z

The job dist-x86_64-netbsd failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-05-10T05:45:25Z

💔 Test for 16efdfa failed: CI. Failed job:

auto - dist-x86_64-netbsd (web logs, enhanced plaintext logs)

matthiaskrgr · 2026-05-10T06:05:02Z

@bors retry

rust-bors · 2026-05-10T09:27:49Z

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 3h 21m 45s
Pushing d1961be to main...

github-actions · 2026-05-10T09:30:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ce89c89 (parent) -> d1961be (this PR)

Test differences

Show 346 test diffs

Stage 1

[ui] tests/ui/attributes/invalid-export-name.rs: [missing] -> pass (J0)
[ui] tests/ui/attributes/invalid-link-name.rs: [missing] -> pass (J0)
[codegen] tests/codegen-llvm/issues/issue-144329-niched-option-check.rs: [missing] -> pass (J2)

Stage 2

[codegen] tests/codegen-llvm/issues/issue-144329-niched-option-check.rs: [missing] -> pass (J1)
[ui] tests/ui/attributes/invalid-export-name.rs: [missing] -> pass (J3)
[ui] tests/ui/attributes/invalid-link-name.rs: [missing] -> pass (J3)

Additionally, 340 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d1961bebe091816d8ce9771f29ad471dda398f5d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-llvm-mingw: 1h 28m -> 1h 56m (+31.2%)
x86_64-rust-for-linux: 47m 43s -> 34m 45s (-27.2%)
x86_64-gnu: 2h 21m -> 1h 46m (-25.2%)
armhf-gnu: 1h 7m -> 1h 23m (+23.4%)
optional-x86_64-gnu-parallel-frontend: 1h 49m -> 2h 15m (+23.0%)
i686-msvc-1: 3h 2m -> 2h 23m (-21.4%)
x86_64-msvc-2: 2h 31m -> 1h 59m (-21.0%)
dist-x86_64-apple: 2h 9m -> 1h 48m (-16.4%)
x86_64-gnu-aux: 1h 47m -> 2h 4m (+16.3%)
dist-aarch64-msvc: 1h 38m -> 1h 53m (+15.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-05-10T09:31:03Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149362	Add Command::get_resolved_envs	`f2b4b967fa93e468d6aef1ae5aefdad0a5d2c02b` (link)
#155188	Add regression test for issue 144329	`932c24b4f62b13c0f66edffdc5402f97b278a362` (link)
#155515	error on empty `export_name`	`45a57c655ea0cb45b91b51ea2dfbeb54281b45de` (link)
#155705	Add `str::word_to_titlecase()` to `alloc`	`a8e597004fc1cc8f8433b96d33db7b26f6f86319` (link)
#155817	validate `#[link_name = "..."]` & `#[link(name = "...")]` p…	`a6023f4e23d7482c4b730fd67174f493e1a38178` (link)
#155970	Add mention of sendfile(2) and splice(2) to fs::copy() docu…	`aeaffe02924ccb8ad336e2f53643395237e0c9db` (link)
#156006	Update a bunch of bootstrap dependencies to remove windows-…	`36ed88bafc81b853566984c9d2d8b18c316b30e0` (link)
#156107	remove turbofish notation + use None / Some instead of Opti…	`d94019d3aa562cb884e0d587f0394bd031934c1d` (link)
#156133	mark some panicking methods around Duration as track_caller	`ca161f098f237263c3dd33352aa4d6c9dbefa2e5` (link)
#156169	Change `SwitchInt` handling in dataflow analysis.	`797fc5b3597e2bd8380c7d3e5418445b0f1f4536` (link)
#156363	`rustc_attr_parsing`: add `AcceptContext::expect_string_lit…	`29b4222118c3491a82d51611f079421c9564bcf2` (link)

previous master: ce89c89857

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-05-10T10:08:59Z

Finished benchmarking commit (d1961be): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.5%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	11.1%	[11.1%, 11.1%]	1
Regressions ❌ (secondary)	1.8%	[1.8%, 1.8%]	1
Improvements ✅ (primary)	-3.0%	[-4.1%, -1.0%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[-4.1%, 11.1%]	4

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary 0.2%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.4%]	8
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	31
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.1%, 0.4%]	8

Bootstrap: 498.161s -> 499.009s (0.17%)
Artifact size: 397.12 MiB -> 397.20 MiB (0.02%)

schneemsand others added 24 commits March 2, 2026 14:42

Add Command::get_resolved_envs
5ed5b26
This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

error on empty export_name
d0ea88e

validate link name parameter
c08b9ab
specifically, do not allow NULL bytes and the empty string

Add regression test for issue 144329
fd2e542

Update a bunch of bootstrap dependencies to remove windows-target
7eb6a20

remove turbofish notation + use None / Some instead of Option::
a80af22

mark some panicking methods around Duration as track_caller
09dc7fc

replace leftover call to ArgParser::list with AcceptContext::expect_lits
a275453

rustc_attr_parsing: improve error message for codegen attributes
9097f5b

rustc_attr_parsing: add AcceptContext::expect_string_literal
dcdba78

Add str::word_to_titlecase() to alloc
40da877
* Add `str::word_to_titlecase()` to `alloc` * Address review comment

Add mention of sendfile(2) and splice(2) to fs::copy() documentation.
f4adc40
* Add mention of sendfile(2) and splice(2) to fs::copy() documentation. * Oxford comma fix

Rollup merge ofrust-lang#155705- Jules-Bertholet:word-to-titlecase,…
2728204
… r=Mark-Simulacrum Add `str::word_to_titlecase()` to `alloc` A small addition to rust-lang#153892. Hasn't gone through ACP, so needs libs-API signoff. @rustbot label A-Unicode T-libs-api

Rollup merge ofrust-lang#155970- tomilepp:issue-155968-fix, r=josht…
9165dbf
…riplett Add mention of sendfile(2) and splice(2) to fs::copy() documentation. Fixesrust-lang#155968 by adding mention of sendfile(2) and splice(2) from io::copy()

Rollup merge ofrust-lang#156006- bjorn3:bootstrap_no_import_libs, r…
0711aa9
…=Mark-Simulacrum Update a bunch of bootstrap dependencies to remove windows-target Follow up to rust-lang#155444

Rollup merge ofrust-lang#155188- DaniPopes:144329-test, r=Mark-Simu…
dd0746b
…lacrum Add regression test for issue 144329 Closesrust-lang#144329.

Rollup merge ofrust-lang#156107- Cheese-Space:patch-1, r=Mark-Simul…
6fffff9
…acrum remove turbofish notation + use None / Some instead of Option:: (in match documentation)

Rollup merge ofrust-lang#156363- scrabsha:attributes/expect-string-…
ddecb76
…literal, r=JonathanBrouwer `rustc_attr_parsing`: add `AcceptContext::expect_string_literal`

rust-borsBot added the rollup A PR which is a rollup label May 10, 2026

This comment has been minimized.
Sign in to view

rust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2026

rust-borsBot mentioned this pull request May 10, 2026
Add Command::get_resolved_envs #149362
Merged

This comment has been minimized.
Sign in to view

rust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2026

This comment has been minimized.
Sign in to view

rust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2026

rust-borsBot merged commit d1961be into rust-lang:mainMay 10, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone May 10, 2026

This was referenced May 10, 2026
Implement String::make_(upp|low)ercase #135888
Open
move check_ffi_pure to attribute parser #156219
Draft

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented May 10, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 10, 2026

Uh oh!

rust-borsBot commented May 10, 2026

Uh oh!

matthiaskrgr commented May 10, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 10, 2026

Uh oh!

rust-borsBot commented May 10, 2026

Uh oh!

matthiaskrgr commented May 10, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented May 10, 2026

Uh oh!

Uh oh!

github-actionsBot commented May 10, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 10, 2026

Uh oh!

rust-timer commented May 10, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants