Skip to content

Add str::word_to_titlecase() to alloc - #155705

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Jules-Bertholet:word-to-titlecase
May 10, 2026
Merged

Add str::word_to_titlecase() to alloc#155705
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Jules-Bertholet:word-to-titlecase

Conversation

@Jules-Bertholet

@Jules-BertholetJules-Bertholet commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

A small addition to #153892.

Hasn't gone through ACP, so needs libs-API signoff.

@rustbot label A-Unicode T-libs-api

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 23, 2026
@rustbot

rustbot commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 6 candidates
  • Random selection from Mark-Simulacrum, jhpratt

@rustbotrustbot added A-Unicode Area: Unicode T-libs-api [DEPRECATED; DO NOT USE] labels Apr 23, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-SimulacrumMark-Simulacrum added S-waiting-on-t-libs-api [DEPRECATED; DO NOT USE] and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2026
@Jules-Bertholet
Jules-Bertholetforce-pushed the word-to-titlecase branch 2 times, most recently from 2753869 to 3a6aeb6CompareApril 26, 2026 14:55
the8472
the8472 reviewed Apr 28, 2026
View reviewed changes
Comment threadlibrary/alloc/src/str.rs Outdated
@the8472

the8472 commented Apr 28, 2026

Copy link
Copy Markdown
Member

We discussed it during today's libs-api meeting. We didn't do an in-depth review, but we're generally ok with having this on unstable.

Also, the issue title was confusing since it adds a String method, not one on char.

@Jules-BertholetJules-Bertholet changed the title Add char::word_to_titlecase() to allocAdd str::word_to_titlecase() to allocApr 28, 2026
@Jules-Bertholet

Jules-Bertholet commented Apr 28, 2026

Copy link
Copy Markdown
ContributorAuthor

Also, the issue title was confusing since it adds a String method, not one on char.

🤦 Sorry…

@Jules-Bertholet

Jules-Bertholet commented Apr 29, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready
@rustbot label -S-waiting-on-t-libs-api

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-t-libs-api [DEPRECATED; DO NOT USE] labels Apr 29, 2026
@Mark-Simulacrum

Mark-Simulacrum commented May 9, 2026

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Add str::word_to_titlecase() to alloc
40da877
* Add `str::word_to_titlecase()` to `alloc`
* Address review comment
@rust-bors

rust-borsBot commented May 9, 2026

Copy link
Copy Markdown
Contributor

🔨 2 commits were squashed into 40da877.

@rust-bors
rust-borsBotforce-pushed the word-to-titlecase branch from d0b432b to 40da877CompareMay 9, 2026 17:42
@Mark-Simulacrum

Mark-Simulacrum commented May 9, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-borsBot commented May 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 40da877 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#155705- Jules-Bertholet:word-to-titlecase,…
f15f605
… r=Mark-Simulacrum
Add `str::word_to_titlecase()` to `alloc`
A small addition to rust-lang#153892.
Hasn't gone through ACP, so needs libs-API signoff.
@rustbot label A-Unicode T-libs-api
@JonathanBrouwerJonathanBrouwer mentioned this pull request May 9, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#155705- Jules-Bertholet:word-to-titlecase,…
78bcf61
… r=Mark-Simulacrum
Add `str::word_to_titlecase()` to `alloc`
A small addition to rust-lang#153892.
Hasn't gone through ACP, so needs libs-API signoff.
@rustbot label A-Unicode T-libs-api
@JonathanBrouwerJonathanBrouwer mentioned this pull request May 9, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request May 9, 2026
@bors
Auto merge of#156374- JonathanBrouwer:rollup-Orm2U9C, r=JonathanBro…
d9b9e50
…uwer
Rollup of 10 pull requests
Successful merges:
- #148214 (Consider `Result<T, Uninhabited>` and `ControlFlow<Uninhabited, T>` to be equivalent to `T` for must use lint)
- #149362 (Add Command::get_resolved_envs)
- #155705 (Add `str::word_to_titlecase()` to `alloc`)
- #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.)
- #156006 (Update a bunch of bootstrap dependencies to remove windows-target)
- #155188 (Add regression test for issue 144329)
- #155515 (error on empty `export_name`)
- #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters)
- #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation))
- #156133 (mark some panicking methods around Duration as track_caller)
@matthiaskrgrmatthiaskrgr mentioned this pull request May 10, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request May 10, 2026
@bors
Auto merge of#156378- matthiaskrgr:rollup-NO89xfV, r=matthiaskrgr
488aaf6
Rollup of 11 pull requests
Successful merges:
- #149362 (Add Command::get_resolved_envs)
- #155705 (Add `str::word_to_titlecase()` to `alloc`)
- #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.)
- #156006 (Update a bunch of bootstrap dependencies to remove windows-target)
- #156169 (Change `SwitchInt` handling in dataflow analysis.)
- #155188 (Add regression test for issue 144329)
- #155515 (error on empty `export_name`)
- #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters)
- #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation))
- #156133 (mark some panicking methods around Duration as track_caller)
- #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)
rust-borsBot pushed a commit that referenced this pull request May 10, 2026
@bors
Auto merge of#156378- matthiaskrgr:rollup-NO89xfV, r=matthiaskrgr
16efdfa
Rollup of 11 pull requests
Successful merges:
- #149362 (Add Command::get_resolved_envs)
- #155705 (Add `str::word_to_titlecase()` to `alloc`)
- #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.)
- #156006 (Update a bunch of bootstrap dependencies to remove windows-target)
- #156169 (Change `SwitchInt` handling in dataflow analysis.)
- #155188 (Add regression test for issue 144329)
- #155515 (error on empty `export_name`)
- #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters)
- #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation))
- #156133 (mark some panicking methods around Duration as track_caller)
- #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)
rust-borsBot pushed a commit that referenced this pull request May 10, 2026
@bors
Auto merge of#156378- matthiaskrgr:rollup-NO89xfV, r=matthiaskrgr
d1961be
Rollup of 11 pull requests
Successful merges:
- #149362 (Add Command::get_resolved_envs)
- #155705 (Add `str::word_to_titlecase()` to `alloc`)
- #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.)
- #156006 (Update a bunch of bootstrap dependencies to remove windows-target)
- #156169 (Change `SwitchInt` handling in dataflow analysis.)
- #155188 (Add regression test for issue 144329)
- #155515 (error on empty `export_name`)
- #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters)
- #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation))
- #156133 (mark some panicking methods around Duration as track_caller)
- #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)
@rust-bors
rust-borsBot merged commit 2728204 into rust-lang:mainMay 10, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone May 10, 2026
rust-timer added a commit that referenced this pull request May 10, 2026
@rust-timer
Unrolled build for#155705
a8e5970
Rollup merge of #155705 - Jules-Bertholet:word-to-titlecase, r=Mark-Simulacrum
Add `str::word_to_titlecase()` to `alloc`
A small addition to #153892.
Hasn't gone through ACP, so needs libs-API signoff.
@rustbot label A-Unicode T-libs-api
@Jules-Bertholet
Jules-Bertholet deleted the word-to-titlecase branch May 10, 2026 15:09
@Jules-BertholetJules-Bertholet mentioned this pull request May 10, 2026
Open
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the8472the8472the8472 left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

A-UnicodeArea: UnicodeS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Jules-Bertholet@rustbot@rust-log-analyzer@the8472@Mark-Simulacrum