typeck: Make it clearer that `check_pat_lit` only handles literal patterns by Zalathar · Pull Request #150688 · rust-lang/rust

Zalathar · 2026-01-05T03:03:47Z

Nowadays, the hir::PatExprKind enum guarantees that “expressions” in patterns can only be paths or literals.

PatExprKind::Path is already handled by the previous match arm, so we can make this match arm explicitly match on PatExprKind::Lit without losing exhaustiveness.

There should be no actual change to compiler behaviour.

rustbot · 2026-01-05T03:03:52Z

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Zalathar · 2026-02-06T05:13:18Z

Rerolling since Sparrow is known to be busy.

r? compiler

petrochenkov · 2026-02-09T14:19:00Z

@bors r+ rollup

rust-bors · 2026-02-09T14:19:04Z

📌 Commit 069302f has been approved by petrochenkov

It is now in the queue for this repository.

…nkov typeck: Make it clearer that `check_pat_lit` only handles literal patterns Nowadays, the `hir::PatExprKind` enum guarantees that “expressions” in patterns can only be paths or literals. `PatExprKind::Path` is already handled by the previous match arm, so we can make this match arm explicitly match on `PatExprKind::Lit` without losing exhaustiveness. There should be no actual change to compiler behaviour.

JonathanBrouwer · 2026-02-09T15:25:30Z

@bors r-
#152391 (comment)

rust-bors · 2026-02-09T15:25:40Z

Commit 069302f has been unapproved.

This PR was contained in a rollup (#152391), which was also unapproved.

rustbot · 2026-02-10T00:56:56Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Zalathar · 2026-02-10T01:48:20Z

Rebased to adjust import of assert_matches! after compiler: Temporarily re-export assert_matches! to reduce stabilization churn #151359.

@bors r=petrochenkov

rust-bors · 2026-02-10T01:48:23Z

📌 Commit 90fd768 has been approved by petrochenkov

It is now in the queue for this repository.

…nkov typeck: Make it clearer that `check_pat_lit` only handles literal patterns Nowadays, the `hir::PatExprKind` enum guarantees that “expressions” in patterns can only be paths or literals. `PatExprKind::Path` is already handled by the previous match arm, so we can make this match arm explicitly match on `PatExprKind::Lit` without losing exhaustiveness. There should be no actual change to compiler behaviour.

Rollup of 7 pull requests Successful merges: - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)

…nkov typeck: Make it clearer that `check_pat_lit` only handles literal patterns Nowadays, the `hir::PatExprKind` enum guarantees that “expressions” in patterns can only be paths or literals. `PatExprKind::Path` is already handled by the previous match arm, so we can make this match arm explicitly match on `PatExprKind::Lit` without losing exhaustiveness. There should be no actual change to compiler behaviour.

…uwer Rollup of 11 pull requests Successful merges: - #152364 (Port a lot of attributes to the new parser) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152355 (Update documentation of rustc_macros) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`) - #152425 (Port #![test_runner] to the attribute parser)

…uwer Rollup of 10 pull requests Successful merges: - #152364 (Port a lot of attributes to the new parser) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152355 (Update documentation of rustc_macros) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)

Rollup merge of #150688 - Zalathar:check-pat-lit, r=petrochenkov typeck: Make it clearer that `check_pat_lit` only handles literal patterns Nowadays, the `hir::PatExprKind` enum guarantees that “expressions” in patterns can only be paths or literals. `PatExprKind::Path` is already handled by the previous match arm, so we can make this match arm explicitly match on `PatExprKind::Lit` without losing exhaustiveness. There should be no actual change to compiler behaviour.

…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#152364 (Port a lot of attributes to the new parser) - rust-lang/rust#151954 (Add help message suggesting explicit reference cast for From/TryFrom) - rust-lang/rust#152148 (Move `impl Interner for TyCtxt` to its own submodule) - rust-lang/rust#152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - rust-lang/rust#152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - rust-lang/rust#152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - rust-lang/rust#150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - rust-lang/rust#152293 (Format heterogeneous try blocks) - rust-lang/rust#152355 (Update documentation of rustc_macros) - rust-lang/rust#152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)

rustbot assigned SparrowLii Jan 5, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2026

rustbot assigned petrochenkov and unassigned SparrowLii Feb 6, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026

JonathanBrouwer mentioned this pull request Feb 9, 2026
Rollup of 12 pull requests #152391
Closed

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 9, 2026

Zalathar force-pushed the check-pat-lit branch from 069302f to cc14db6Compare February 10, 2026 00:56

Make it clearer that check_pat_lit only handles literal patterns
90fd768

Zalathar force-pushed the check-pat-lit branch from cc14db6 to 90fd768Compare February 10, 2026 00:57

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2026

matthiaskrgr mentioned this pull request Feb 10, 2026
Rollup of 7 pull requests #152421
Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026
Rollup of 8 pull requests #152427
Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026
Rollup of 11 pull requests #152429
Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026
Rollup of 11 pull requests #152430
Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026
Rollup of 10 pull requests #152437
Merged

rust-borsBot merged commit b5cf352 into rust-lang:mainFeb 10, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 10, 2026

Zalathar deleted the check-pat-lit branch February 11, 2026 00:46

Navigation Menu

Uh oh!

Uh oh!

typeck: Make it clearer that `check_pat_lit` only handles literal patterns - #150688

typeck: Make it clearer that `check_pat_lit` only handles literal patterns#150688
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Zalathar:check-pat-lit

Zalathar commented Jan 5, 2026

Uh oh!

rustbot commented Jan 5, 2026

Uh oh!

Zalathar commented Feb 6, 2026

Uh oh!

petrochenkov commented Feb 9, 2026

Uh oh!

rust-borsBot commented Feb 9, 2026

Uh oh!

JonathanBrouwer commented Feb 9, 2026

Uh oh!

rust-borsBot commented Feb 9, 2026

Uh oh!

rustbot commented Feb 10, 2026

Uh oh!

Zalathar commented Feb 10, 2026

Uh oh!

rust-borsBot commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Jan 5, 2026

Uh oh!

rustbot commented Jan 5, 2026

Uh oh!

Zalathar commented Feb 6, 2026

Uh oh!

petrochenkov commented Feb 9, 2026

Uh oh!

rust-borsBot commented Feb 9, 2026

Uh oh!

JonathanBrouwer commented Feb 9, 2026

Uh oh!

rust-borsBot commented Feb 9, 2026

Uh oh!

rustbot commented Feb 10, 2026

Uh oh!

Zalathar commented Feb 10, 2026

Uh oh!

rust-borsBot commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants