Skip to content

Port #![test_runner] to the attribute parser - #152425

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Ozzy1423:test-runner
Feb 12, 2026
Merged

Port #![test_runner] to the attribute parser#152425
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Ozzy1423:test-runner

Conversation

@Ozzy1423

Copy link
Copy Markdown
Contributor

Tracking issue: #131229

r? @JonathanBrouwer

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 10, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d215efd has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
…ouwer
Port #![test_runner] to the attribute parser
Tracking issue: rust-lang#131229
r? @JonathanBrouwer
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
…ouwer
Port #![test_runner] to the attribute parser
Tracking issue: rust-lang#131229
r? @JonathanBrouwer
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
…ouwer
Port #![test_runner] to the attribute parser
Tracking issue: rust-lang#131229
r? @JonathanBrouwer
rust-borsBot pushed a commit that referenced this pull request Feb 10, 2026
…uwer
Rollup of 11 pull requests
Successful merges:
- #152364 (Port a lot of attributes to the new parser)
- #151954 (Add help message suggesting explicit reference cast for From/TryFrom)
- #152148 (Move `impl Interner for TyCtxt` to its own submodule)
- #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds)
- #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`)
- #152417 (Move the needs-drop check for `arena_cache` queries out of macro code)
- #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns)
- #152293 (Format heterogeneous try blocks)
- #152355 (Update documentation of rustc_macros)
- #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)
- #152425 (Port #![test_runner] to the attribute parser)
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors r-
#152430 (comment)
@bors try jobs=dist-x86_64-linux-alt

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2026
@rust-bors

rust-borsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Commit d215efd has been unapproved.

This PR was contained in a rollup (#152430), which was also unapproved.

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Feb 10, 2026
Port #![test_runner] to the attribute parser
try-job: dist-x86_64-linux-alt
@rust-bors

rust-borsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 705c0bd failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors try jobs=dist-x86_64-linux-alt

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Feb 11, 2026
Port #![test_runner] to the attribute parser
try-job: dist-x86_64-linux-alt
@rust-bors

rust-borsBot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 914b037 (914b0372586975529f9bd34314c0669c64debc69, parent: d34f1f931489618efffc4007e6b6bdb9e10f6467)

@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-borsBot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d1f11fd has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 12, 2026
…ouwer
Port #![test_runner] to the attribute parser
Tracking issue: rust-lang#131229
r? @JonathanBrouwer
@jhprattjhpratt mentioned this pull request Feb 12, 2026
rust-borsBot pushed a commit that referenced this pull request Feb 12, 2026
Rollup of 17 pull requests
Successful merges:
- #142415 (Add note when inherent impl for a alias type defined outside of the crate)
- #142680 (Fix passing/returning structs with the 64-bit SPARC ABI)
- #150768 (Don't compute FnAbi for LLVM intrinsics in backends)
- #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes)
- #151814 (layout: handle rigid aliases without params)
- #151863 (Borrowck: simplify diagnostics for placeholders)
- #152159 (Add note for `?Sized` params in int-ptr casts diag)
- #152434 (Clarify names of `QueryVTable` functions for "executing" a query)
- #152478 (Remove tm_factory field from CodegenContext)
- #152498 (Partially revert "resolve: Update `NameBindingData::vis` in place")
- #152316 (fix: add continue)
- #152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter)
- #152425 (Port #![test_runner] to the attribute parser)
- #152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif)
- #152485 (fix issue#152482)
- #152495 (Clean up some subdiagnostics)
- #152502 (Implement `BinaryHeap::from_raw_vec`)
@rust-bors
rust-borsBot merged commit 9cbcd11 into rust-lang:mainFeb 12, 2026
12 checks passed
@rustbotrustbot added this to the 1.95.0 milestone Feb 12, 2026
rust-timer added a commit that referenced this pull request Feb 12, 2026
Rollup merge of #152425 - Ozzy1423:test-runner, r=JonathanBrouwer
Port #![test_runner] to the attribute parser
Tracking issue: #131229
r? @JonathanBrouwer
@Ozzy1423
Ozzy1423 deleted the test-runner branch February 12, 2026 17:06
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 16, 2026
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#142415 (Add note when inherent impl for a alias type defined outside of the crate)
- rust-lang/rust#142680 (Fix passing/returning structs with the 64-bit SPARC ABI)
- rust-lang/rust#150768 (Don't compute FnAbi for LLVM intrinsics in backends)
- rust-lang/rust#151152 (Add FCW for derive helper attributes that will conflict with built-in attributes)
- rust-lang/rust#151814 (layout: handle rigid aliases without params)
- rust-lang/rust#151863 (Borrowck: simplify diagnostics for placeholders)
- rust-lang/rust#152159 (Add note for `?Sized` params in int-ptr casts diag)
- rust-lang/rust#152434 (Clarify names of `QueryVTable` functions for "executing" a query)
- rust-lang/rust#152478 (Remove tm_factory field from CodegenContext)
- rust-lang/rust#152498 (Partially revert "resolve: Update `NameBindingData::vis` in place")
- rust-lang/rust#152316 (fix: add continue)
- rust-lang/rust#152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter)
- rust-lang/rust#152425 (Port #![test_runner] to the attribute parser)
- rust-lang/rust#152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif)
- rust-lang/rust#152485 (fix issue#152482)
- rust-lang/rust#152495 (Clean up some subdiagnostics)
- rust-lang/rust#152502 (Implement `BinaryHeap::from_raw_vec`)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Ozzy1423@rustbot@JonathanBrouwer@rust-log-analyzer