Move `impl Interner for TyCtxt` to its own submodule by Zalathar · Pull Request #152148 · rust-lang/rust

Zalathar · 2026-02-05T02:29:24Z

This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large rustc_middle::ty::context module.

The trait and its impl were introduced by Move things to rustc_type_ir #97287.

There should be no change to compiler behaviour.

rustbot · 2026-02-05T02:29:29Z

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Zalathar · 2026-02-05T02:41:30Z

I had been looking into whether it's feasible to extract TyCtxt and GlobalCtxt into their own module (since context.rs is so big and incoherent), when I stumbled upon this other chunk of extractable code.

petrochenkov · 2026-02-09T12:58:22Z

r=me after rebase.
@rustbot author

Requiring `fn` in the macro syntax makes it a little more obvious that the macro declares functions with those names, and makes them easier to grep for.

rustbot · 2026-02-10T01:06:42Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Zalathar · 2026-02-10T01:50:15Z

Rebased to include anon_const_kind, which was added by Implement MVP for opaque generic const arguments #150823.

@bors r=petrochenkov

rust-bors · 2026-02-10T01:50:18Z

📌 Commit b7bfb76 has been approved by petrochenkov

It is now in the queue for this repository.

Move `impl Interner for TyCtxt` to its own submodule This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large `rustc_middle::ty::context` module. - The trait and its impl were introduced by rust-lang#97287. --- There should be no change to compiler behaviour.

Rollup of 7 pull requests Successful merges: - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)

Move `impl Interner for TyCtxt` to its own submodule This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large `rustc_middle::ty::context` module. - The trait and its impl were introduced by rust-lang#97287. --- There should be no change to compiler behaviour.

…uwer Rollup of 11 pull requests Successful merges: - #152364 (Port a lot of attributes to the new parser) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152355 (Update documentation of rustc_macros) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`) - #152425 (Port #![test_runner] to the attribute parser)

…uwer Rollup of 10 pull requests Successful merges: - #152364 (Port a lot of attributes to the new parser) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152355 (Update documentation of rustc_macros) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)

…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#152364 (Port a lot of attributes to the new parser) - rust-lang/rust#151954 (Add help message suggesting explicit reference cast for From/TryFrom) - rust-lang/rust#152148 (Move `impl Interner for TyCtxt` to its own submodule) - rust-lang/rust#152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - rust-lang/rust#152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - rust-lang/rust#152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - rust-lang/rust#150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - rust-lang/rust#152293 (Format heterogeneous try blocks) - rust-lang/rust#152355 (Update documentation of rustc_macros) - rust-lang/rust#152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2026

rustbot assigned petrochenkov Feb 5, 2026

This comment has been minimized.
Sign in to view

Zalathar force-pushed the tcx-interner branch from 47d4b27 to 546edb0Compare February 8, 2026 01:50

This comment has been minimized.
Sign in to view

Zalathar force-pushed the tcx-interner branch from 546edb0 to b50e0b5Compare February 8, 2026 02:40

This comment has been minimized.
Sign in to view

Zalathar force-pushed the tcx-interner branch from b50e0b5 to 2aa9979Compare February 8, 2026 02:52

This comment has been minimized.
Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026

Zalathar added 3 commits February 10, 2026 11:58

Don't import TyCtxt from crate::ty::context
91d47a5

Move impl Interner for TyCtxt to its own submodule
4234d2d

Indicate that bidirectional_lang_item_map! declares functions
b7bfb76
Requiring `fn` in the macro syntax makes it a little more obvious that the macro declares functions with those names, and makes them easier to grep for.

Zalathar force-pushed the tcx-interner branch from 2aa9979 to b7bfb76Compare February 10, 2026 01:06

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2026

matthiaskrgr mentioned this pull request Feb 10, 2026
Rollup of 7 pull requests #152421
Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026
Rollup of 8 pull requests #152427
Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026
Rollup of 11 pull requests #152429
Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026
Rollup of 11 pull requests #152430
Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026
Rollup of 10 pull requests #152437
Merged

rust-borsBot merged commit 2aaf3a1 into rust-lang:mainFeb 10, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 10, 2026

Zalathar deleted the tcx-interner branch February 11, 2026 00:46

Navigation Menu

Uh oh!

Uh oh!

Move `impl Interner for TyCtxt` to its own submodule - #152148

Move `impl Interner for TyCtxt` to its own submodule#152148
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Zalathar:tcx-interner

Zalathar commented Feb 5, 2026•
edited
Loading

Uh oh!

rustbot commented Feb 5, 2026

Uh oh!

Zalathar commented Feb 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Feb 9, 2026

Uh oh!

rustbot commented Feb 10, 2026

Uh oh!

Zalathar commented Feb 10, 2026

Uh oh!

rust-borsBot commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Feb 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 5, 2026

Uh oh!

Zalathar commented Feb 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Feb 9, 2026

Uh oh!

rustbot commented Feb 10, 2026

Uh oh!

Zalathar commented Feb 10, 2026

Uh oh!

rust-borsBot commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Zalathar commented Feb 5, 2026•
edited
Loading