bootstrap: Optionally print a backtrace if a command fails by jyn514 · Pull Request #153992 · rust-lang/rust

jyn514 · 2026-03-17T09:18:56Z

I found this quite useful for debugging why a command was failing eagerly (it turns out that .delay_failure() is ignored if fail_fast is enabled).

rustbot · 2026-03-17T09:19:05Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: bootstrap
bootstrap expanded to 6 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu

Makes sense, thanks

View changes since this review

jieyouxu · 2026-03-17T12:27:13Z

@bors r+ rollup

rust-bors · 2026-03-17T12:27:16Z

📌 Commit e1186d2 has been approved by jieyouxu

It is now in the queue for this repository.

Kobzol · 2026-03-17T12:52:03Z

@bors r-

(sorry, to ask some questions :) )

With this change, it would print a backtrace even when the failure behavior is Ignore, that doesn't seem like something we want?

Also, bootstrap already prints where was the corresponding command created (file + line) and where was it executed (file + line). But I suppose that it wasn't enough for you and you wanted a full backtrace?

jyn514 · 2026-03-17T13:02:50Z

With this change, it would print a backtrace even when the failure behavior is Ignore, that doesn't seem like something we want?

correct, yes. I agree this doesn't make a lot of sense, I'll force off backtraces for Ignore.

Also, bootstrap already prints where was the corresponding command created (file + line) and where was it executed (file + line). But I suppose that it wasn't enough for you and you wanted a full backtrace?

Yes. Specifically I was trying to debug the command infra itself, to figure out why an unsuccessful command exited the process instead of delaying the failure until later.

jieyouxu · 2026-03-17T13:37:50Z

Hm, I wonder if you are looking for sth more like --verbose-always-print-cmd-backtrace 🤔

Kobzol · 2026-03-17T14:27:38Z

I think we already have multiple verbosity levels, so maybe we can enable the backtrace only for -vv? That being said, I like the idea of showing the backtrace (regardless of verbosity level) when RUST_BACKTRACE=1 is enabled.

jyn514 · 2026-03-18T10:15:59Z

pushed some changes, let me know if they look how you expect :)

Kobzol · 2026-03-18T14:31:57Z

Looks good, thanks!

@bors r=jieyouxu,kobzol

rust-bors · 2026-03-18T14:32:04Z

📌 Commit c8a2c46 has been approved by jieyouxu,kobzol

It is now in the queue for this repository.

… r=jieyouxu,kobzol bootstrap: Optionally print a backtrace if a command fails I found this quite useful for debugging why a command was failing eagerly (it turns out that `.delay_failure()` is ignored if `fail_fast` is enabled).

…uwer Rollup of 5 pull requests Successful merges: - #153308 (Add hygiene annotations for tokens in `macro_rules!` bodies) - #153557 (fix inference variables leaking into HIR const literal lowering logic) - #153913 (Fix some suggestions of the `for-loops-over-fallibles` lint) - #153987 (mGCA: Lower const generic args to infer when needed) - #153992 (bootstrap: Optionally print a backtrace if a command fails)

… r=jieyouxu,kobzol bootstrap: Optionally print a backtrace if a command fails I found this quite useful for debugging why a command was failing eagerly (it turns out that `.delay_failure()` is ignored if `fail_fast` is enabled).

JonathanBrouwer · 2026-03-19T12:15:13Z

@bors try jobs=x86_64-gnu-distcheck

bootstrap: Optionally print a backtrace if a command fails try-job: x86_64-gnu-distcheck

JonathanBrouwer · 2026-03-19T12:34:08Z

@bors r-
#154062 (comment)

jyn514 · 2026-03-19T12:38:06Z

I don't think this is related to my change. My guess is #153957.

jyn514 · 2026-03-19T12:38:29Z

see in particular https://triage.rust-lang.org/gha-logs/rust-lang/rust/67727225660#L2026-03-19T12:11:30.8820882Z

jyn514 · 2026-03-19T12:38:39Z

@rustbot ready

JonathanBrouwer · 2026-03-19T12:40:57Z

Ah right, I followed the backtrace to this PR but that's just because this PR adds the backtrace feature :p
A little bit of a dumb move of me
@bors r=jieyouxu,kobzol

rust-bors · 2026-03-19T12:41:00Z

📌 Commit c8a2c46 has been approved by jieyouxu,kobzol

It is now in the queue for this repository.

rust-bors · 2026-03-19T14:31:59Z

☀️ Try build successful (CI)
Build commit: 616883a (616883ab97e2bb9335a3fa226a30e60a28fc426a, parent: 8b86f48958be8c3473c979e0b5504c2d2e0fd4fd)

… r=jieyouxu,kobzol bootstrap: Optionally print a backtrace if a command fails I found this quite useful for debugging why a command was failing eagerly (it turns out that `.delay_failure()` is ignored if `fail_fast` is enabled).

…uwer Rollup of 9 pull requests Successful merges: - #153556 (`impl` restriction lowering) - #153992 (bootstrap: Optionally print a backtrace if a command fails) - #154019 (two smaller feature cleanups) - #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`) - #154075 (Rewrite `query_ensure_result`.) - #154082 (Updates derive_where and removes workaround) - #154084 (Preserve braces around `self` in use tree pretty printing) - #154086 (Insert space after float literal ending with `.` in pretty printer) - #154087 (Fix whitespace after fragment specifiers in macro pretty printing)

… r=jieyouxu,kobzol bootstrap: Optionally print a backtrace if a command fails I found this quite useful for debugging why a command was failing eagerly (it turns out that `.delay_failure()` is ignored if `fail_fast` is enabled).

…uwer Rollup of 12 pull requests Successful merges: - #152909 (sess: `-Zbranch-protection` is a target modifier) - #153556 (`impl` restriction lowering) - #154048 (Don't emit rustdoc `missing_doc_code_examples` lint on impl items) - #153992 (bootstrap: Optionally print a backtrace if a command fails) - #154019 (two smaller feature cleanups) - #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`) - #154075 (Rewrite `query_ensure_result`.) - #154082 (Updates derive_where and removes workaround) - #154084 (Preserve braces around `self` in use tree pretty printing) - #154086 (Insert space after float literal ending with `.` in pretty printer) - #154087 (Fix whitespace after fragment specifiers in macro pretty printing) - #154109 (tests: Add regression test for async closures involving HRTBs)

Rollup of 15 pull requests Successful merges: - #152909 (sess: `-Zbranch-protection` is a target modifier) - #153556 (`impl` restriction lowering) - #154048 (Don't emit rustdoc `missing_doc_code_examples` lint on impl items) - #150935 (Introduce #[diagnostic::on_move(message)]) - #152973 (remove -Csoft-float) - #153862 (Rename `cycle_check` to `find_cycle`) - #153992 (bootstrap: Optionally print a backtrace if a command fails) - #154019 (two smaller feature cleanups) - #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`) - #154075 (Rewrite `query_ensure_result`.) - #154082 (Updates derive_where and removes workaround) - #154084 (Preserve braces around `self` in use tree pretty printing) - #154086 (Insert space after float literal ending with `.` in pretty printer) - #154087 (Fix whitespace after fragment specifiers in macro pretty printing) - #154109 (tests: Add regression test for async closures involving HRTBs)

2227: a whole bunch of signature signing improvements r=Hoverbear a=jyn514 This is a grab-bag of different small fixes, which I'm happy to split up into smaller PRs. I highly encourage reviewing commit-by-commit and reading the commit descriptions. b770889 is being upstreamed in rust-lang/rust#153992. Co-authored-by: Jynn Nelson <jynn.nelson@ferrous-systems.com>

jyn514 marked this pull request as ready for review March 17, 2026 09:19

rustbot assigned jieyouxu Mar 17, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 17, 2026

jyn514 mentioned this pull request Mar 17, 2026
a whole bunch of signature signing improvements ferrocene/ferrocene#2227
Merged

jieyouxu approved these changes Mar 17, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2026

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2026

bootstrap: Optionally print a backtrace if a command fails
c8a2c46

jyn514 force-pushed the jyn/bootstrap-backtrace branch from e1186d2 to c8a2c46Compare March 18, 2026 10:12

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2026

JonathanBrouwer mentioned this pull request Mar 18, 2026
Rollup of 5 pull requests #154047
Closed

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Mar 19, 2026
Auto merge of#153992- ferrocene:jyn/bootstrap-backtrace, r=<try>
616883a
bootstrap: Optionally print a backtrace if a command fails try-job: x86_64-gnu-distcheck

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026

JonathanBrouwer mentioned this pull request Mar 19, 2026
Rollup of 9 pull requests #154102
Closed

JonathanBrouwer mentioned this pull request Mar 19, 2026
Rollup of 12 pull requests #154116
Closed

JonathanBrouwer mentioned this pull request Mar 19, 2026
Rollup of 12 pull requests #154117
Closed

Zalathar mentioned this pull request Mar 20, 2026
Rollup of 15 pull requests #154123
Merged

rust-borsBot merged commit 1f5915e into rust-lang:mainMar 20, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Mar 20, 2026

Uh oh!

Uh oh!

Conversation

jyn514 commented Mar 17, 2026

Uh oh!

rustbot commented Mar 17, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Mar 17, 2026

Uh oh!

rust-borsBot commented Mar 17, 2026

Uh oh!

Kobzol commented Mar 17, 2026

Uh oh!

jyn514 commented Mar 17, 2026

Uh oh!

jieyouxu commented Mar 17, 2026

Uh oh!

Kobzol commented Mar 17, 2026

Uh oh!

jyn514 commented Mar 18, 2026

Uh oh!

Kobzol commented Mar 18, 2026

Uh oh!

rust-borsBot commented Mar 18, 2026

Uh oh!

JonathanBrouwer commented Mar 19, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 19, 2026

Uh oh!

jyn514 commented Mar 19, 2026

Uh oh!

jyn514 commented Mar 19, 2026

Uh oh!

jyn514 commented Mar 19, 2026

Uh oh!

JonathanBrouwer commented Mar 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-borsBot commented Mar 19, 2026

Uh oh!

rust-borsBot commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jieyouxu left a comment •
edited by rustbot
Loading

JonathanBrouwer commented Mar 19, 2026•
edited
Loading