Skip to content

two smaller feature cleanups - #154019

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
cyrgani:feature-clean
Mar 20, 2026
Merged

two smaller feature cleanups#154019
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
cyrgani:feature-clean

Conversation

@cyrgani

@cyrganicyrgani commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Remove an unneeded feature gate for a private macro and sort the used features correctly by whether they are language or library features.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 17, 2026
@rustbot

rustbot commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet

@cyrganicyrgani changed the title Feature cleantwo smaller feature cleanupsMar 17, 2026
@cyrgani

cyrgani commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

Maybe it would be better to remove the separation between lang and libs features at that point and merge them into a single big // tidy-alphabetical-start section?

@bjorn3

bjorn3 commented Mar 18, 2026

Copy link
Copy Markdown
Member

According to #87766 the split between language and library features is for the following reason:

For the language features, we should check with the relevant team(s) if it's okay that we're using the feature in the library, and document with which of them we need to be extra careful and what their pitfalls are.

@joboet

joboet commented Mar 19, 2026

Copy link
Copy Markdown
Member

👍
@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e350a56 has been approved by joboet

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 19, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154019- cyrgani:feature-clean, r=joboet
65c7618
two smaller feature cleanups
Remove an unneeded feature gate for a private macro and sort the used features correctly by whether they are language or library features.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 19, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 19, 2026
@bors
Auto merge of#154102- JonathanBrouwer:rollup-IJPWkxR, r=JonathanBro…
743af56
…uwer
Rollup of 9 pull requests
Successful merges:
- #153556 (`impl` restriction lowering)
- #153992 (bootstrap: Optionally print a backtrace if a command fails)
- #154019 (two smaller feature cleanups)
- #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`)
- #154075 (Rewrite `query_ensure_result`.)
- #154082 (Updates derive_where and removes workaround)
- #154084 (Preserve braces around `self` in use tree pretty printing)
- #154086 (Insert space after float literal ending with `.` in pretty printer)
- #154087 (Fix whitespace after fragment specifiers in macro pretty printing)
rust-borsBot pushed a commit that referenced this pull request Mar 19, 2026
@bors
Auto merge of#154102- JonathanBrouwer:rollup-IJPWkxR, r=JonathanBro…
185535d
…uwer
Rollup of 9 pull requests
Successful merges:
- #153556 (`impl` restriction lowering)
- #153992 (bootstrap: Optionally print a backtrace if a command fails)
- #154019 (two smaller feature cleanups)
- #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`)
- #154075 (Rewrite `query_ensure_result`.)
- #154082 (Updates derive_where and removes workaround)
- #154084 (Preserve braces around `self` in use tree pretty printing)
- #154086 (Insert space after float literal ending with `.` in pretty printer)
- #154087 (Fix whitespace after fragment specifiers in macro pretty printing)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 19, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154019- cyrgani:feature-clean, r=joboet
2aa5f08
two smaller feature cleanups
Remove an unneeded feature gate for a private macro and sort the used features correctly by whether they are language or library features.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 19, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 19, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154019- cyrgani:feature-clean, r=joboet
4ae63ed
two smaller feature cleanups
Remove an unneeded feature gate for a private macro and sort the used features correctly by whether they are language or library features.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 19, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 20, 2026
@bors
Auto merge of#154117- JonathanBrouwer:rollup-IfMXyaG, r=JonathanBro…
f3d65af
…uwer
Rollup of 12 pull requests
Successful merges:
- #152909 (sess: `-Zbranch-protection` is a target modifier)
- #153556 (`impl` restriction lowering)
- #154048 (Don't emit rustdoc `missing_doc_code_examples` lint on impl items)
- #153992 (bootstrap: Optionally print a backtrace if a command fails)
- #154019 (two smaller feature cleanups)
- #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`)
- #154075 (Rewrite `query_ensure_result`.)
- #154082 (Updates derive_where and removes workaround)
- #154084 (Preserve braces around `self` in use tree pretty printing)
- #154086 (Insert space after float literal ending with `.` in pretty printer)
- #154087 (Fix whitespace after fragment specifiers in macro pretty printing)
- #154109 (tests: Add regression test for async closures involving HRTBs)
@ZalatharZalathar mentioned this pull request Mar 20, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 20, 2026
@bors
Auto merge of#154123- Zalathar:rollup-MUEvgV7, r=Zalathar
86c839f
Rollup of 15 pull requests
Successful merges:
- #152909 (sess: `-Zbranch-protection` is a target modifier)
- #153556 (`impl` restriction lowering)
- #154048 (Don't emit rustdoc `missing_doc_code_examples` lint on impl items)
- #150935 (Introduce #[diagnostic::on_move(message)])
- #152973 (remove -Csoft-float)
- #153862 (Rename `cycle_check` to `find_cycle`)
- #153992 (bootstrap: Optionally print a backtrace if a command fails)
- #154019 (two smaller feature cleanups)
- #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`)
- #154075 (Rewrite `query_ensure_result`.)
- #154082 (Updates derive_where and removes workaround)
- #154084 (Preserve braces around `self` in use tree pretty printing)
- #154086 (Insert space after float literal ending with `.` in pretty printer)
- #154087 (Fix whitespace after fragment specifiers in macro pretty printing)
- #154109 (tests: Add regression test for async closures involving HRTBs)
@rust-bors
rust-borsBot merged commit 83d921d into rust-lang:mainMar 20, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 20, 2026
@cyrgani
cyrgani deleted the feature-clean branch March 20, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cyrgani@rustbot@bjorn3@joboet