Skip to content

Updates derive_where and removes workaround - #154082

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
spirali:fix-derive-where
Mar 20, 2026
Merged

Updates derive_where and removes workaround#154082
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
spirali:fix-derive-where

Conversation

@spirali

@spiralispirali commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Updates dependency on derive-where that fixes issue ModProg/derive-where#136 and removes the following workaround:

// FIXME(derive-where#136): Need to use separate `derive_where` for
// `Copy` and `Ord` to prevent the emitted `Clone` and `PartialOrd`
// impls from incorrectly relying on `T: Copy` and `T: Ord`.

r? lcnr

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2026
@lqd

lqd commented Mar 19, 2026

Copy link
Copy Markdown
Member

Nice, thank you! And despite us referencing version 1.2.7 in a handful of crates we're already relying on 1.6.0 in-tree, so this does not even introduce a duplicate version of derive-where.

r? me r=me when green

@rustbotrustbot assigned lqd and unassigned lcnrMar 19, 2026
@lcnr

lcnr commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

@bors r=lqd rollup

@rust-bors

rust-borsBot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bef4b47 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 19, 2026
Updates derive_where and removes workaround
Updates dependency on `derive-where` that fixes issue ModProg/derive-where#136 and removes the following workaround:
```
// FIXME(derive-where#136): Need to use separate `derive_where` for
// `Copy` and `Ord` to prevent the emitted `Clone` and `PartialOrd`
// impls from incorrectly relying on `T: Copy` and `T: Ord`.
```
r? lcnr
rust-borsBot pushed a commit that referenced this pull request Mar 19, 2026
…uwer
Rollup of 9 pull requests
Successful merges:
- #153556 (`impl` restriction lowering)
- #153992 (bootstrap: Optionally print a backtrace if a command fails)
- #154019 (two smaller feature cleanups)
- #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`)
- #154075 (Rewrite `query_ensure_result`.)
- #154082 (Updates derive_where and removes workaround)
- #154084 (Preserve braces around `self` in use tree pretty printing)
- #154086 (Insert space after float literal ending with `.` in pretty printer)
- #154087 (Fix whitespace after fragment specifiers in macro pretty printing)
rust-borsBot pushed a commit that referenced this pull request Mar 19, 2026
…uwer
Rollup of 9 pull requests
Successful merges:
- #153556 (`impl` restriction lowering)
- #153992 (bootstrap: Optionally print a backtrace if a command fails)
- #154019 (two smaller feature cleanups)
- #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`)
- #154075 (Rewrite `query_ensure_result`.)
- #154082 (Updates derive_where and removes workaround)
- #154084 (Preserve braces around `self` in use tree pretty printing)
- #154086 (Insert space after float literal ending with `.` in pretty printer)
- #154087 (Fix whitespace after fragment specifiers in macro pretty printing)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 19, 2026
Updates derive_where and removes workaround
Updates dependency on `derive-where` that fixes issue ModProg/derive-where#136 and removes the following workaround:
```
// FIXME(derive-where#136): Need to use separate `derive_where` for
// `Copy` and `Ord` to prevent the emitted `Clone` and `PartialOrd`
// impls from incorrectly relying on `T: Copy` and `T: Ord`.
```
r? lcnr
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 19, 2026
Updates derive_where and removes workaround
Updates dependency on `derive-where` that fixes issue ModProg/derive-where#136 and removes the following workaround:
```
// FIXME(derive-where#136): Need to use separate `derive_where` for
// `Copy` and `Ord` to prevent the emitted `Clone` and `PartialOrd`
// impls from incorrectly relying on `T: Copy` and `T: Ord`.
```
r? lcnr
rust-borsBot pushed a commit that referenced this pull request Mar 20, 2026
…uwer
Rollup of 12 pull requests
Successful merges:
- #152909 (sess: `-Zbranch-protection` is a target modifier)
- #153556 (`impl` restriction lowering)
- #154048 (Don't emit rustdoc `missing_doc_code_examples` lint on impl items)
- #153992 (bootstrap: Optionally print a backtrace if a command fails)
- #154019 (two smaller feature cleanups)
- #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`)
- #154075 (Rewrite `query_ensure_result`.)
- #154082 (Updates derive_where and removes workaround)
- #154084 (Preserve braces around `self` in use tree pretty printing)
- #154086 (Insert space after float literal ending with `.` in pretty printer)
- #154087 (Fix whitespace after fragment specifiers in macro pretty printing)
- #154109 (tests: Add regression test for async closures involving HRTBs)
@ZalatharZalathar mentioned this pull request Mar 20, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 20, 2026
Rollup of 15 pull requests
Successful merges:
- #152909 (sess: `-Zbranch-protection` is a target modifier)
- #153556 (`impl` restriction lowering)
- #154048 (Don't emit rustdoc `missing_doc_code_examples` lint on impl items)
- #150935 (Introduce #[diagnostic::on_move(message)])
- #152973 (remove -Csoft-float)
- #153862 (Rename `cycle_check` to `find_cycle`)
- #153992 (bootstrap: Optionally print a backtrace if a command fails)
- #154019 (two smaller feature cleanups)
- #154059 (tests: Activate `must_not_suspend` test for `MutexGuard` dropped before `await`)
- #154075 (Rewrite `query_ensure_result`.)
- #154082 (Updates derive_where and removes workaround)
- #154084 (Preserve braces around `self` in use tree pretty printing)
- #154086 (Insert space after float literal ending with `.` in pretty printer)
- #154087 (Fix whitespace after fragment specifiers in macro pretty printing)
- #154109 (tests: Add regression test for async closures involving HRTBs)
@rust-bors
rust-borsBot merged commit ff9a99d into rust-lang:mainMar 20, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@spirali@lqd@lcnr@rustbot