Skip to content

Move tests in the statics category - #154090

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
danieljofficial:move-tests-statics
Mar 25, 2026
Merged

Move tests in the statics category#154090
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
danieljofficial:move-tests-statics

Conversation

@danieljofficial

@danieljofficialdanieljofficial commented Mar 19, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

I have moved some tests I feel belong in the statics directory. Please review and let me know if this is the correct way. I think on the first two files I moved, i forgot to turn off rust analyzer and it probably formatted the files, will this be an issue? Part of 133895

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2026
@rustbot

rustbot commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 15 candidates

@KivooeoKivooeo assigned Kivooeo and unassigned jieyouxuMar 19, 2026
@Kivooeo

Kivooeo commented Mar 22, 2026

Copy link
Copy Markdown
Member

squash all move commits into one big move commit and all bless/comment commits squash into one big edit commit

so you will have one commit containing plain moves and another commit containing changes to files

@rustbot

rustbot commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@danieljofficial

danieljofficial commented Mar 23, 2026

Copy link
Copy Markdown
ContributorAuthor

Moving forward, I believe you'd prefer it this way instead of my initial commitmaxxing? :)

Kivooeo
Kivooeo reviewed Mar 25, 2026
View reviewed changes
Comment threadtests/ui/statics/static-lazy-init-with-arena-set.rs
Comment on lines +3 to +4
//! Tests that lazy static initialization using `Once` and `transmute`
//! works correctly with a struct that has a default type parameter.

@KivooeoKivooeoMar 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove all such comments except this one

@rustbot

rustbot commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@danieljofficial

danieljofficial commented Mar 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Done.

@Kivooeo

Kivooeo commented Mar 25, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bca30d4 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 25, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154090- danieljofficial:move-tests-statics…
94b40ca
…, r=Kivooeo
Move tests in the statics category
I have moved some tests I feel belong in the statics directory. Please review and let me know if this is the correct way. I think on the first two files I moved, i forgot to turn off rust analyzer and it probably formatted the files, will this be an issue?
This was referenced Mar 25, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
@bors
Auto merge of#154384- JonathanBrouwer:rollup-Wou9g2B, r=JonathanBro…
80d0e4b
…uwer
Rollup of 22 pull requests
Successful merges:
- #153049 (Add `-Zsanitize=kernel-hwaddress`)
- #153702 (Add macro matcher for `guard` fragment specifier)
- #154200 (debuginfo: emit DW_TAG_call_site entries)
- #154263 (interpret: when passing an argument fails, point at that argument)
- #154269 (miri recursive validation: only check one layer deep)
- #154313 (Init `self_decl` with a correct visibility)
- #154344 (Update LLVM to 22.1.2)
- #154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- #154351 (Overhaul `Erasable` impls)
- #154363 (delegation: fix zero-args nested delegation ICE)
- #154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- #151148 (Add functions to `GrowableBitSet`)
- #154090 (Move tests in the statics category)
- #154112 (some `tests/ui/macros` cleanup)
- #154131 (begin `tests/ui/structs-enums` cleanup)
- #154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- #154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- #154233 (Move ui/issues tests to relevant subdirectories)
- #154288 (Fix typo in doc comment for `char::to_titlecase`)
- #154355 (delegation: add const type ICE test)
- #154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- #154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
@rust-bors
rust-borsBot merged commit 047dee4 into rust-lang:mainMar 25, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 25, 2026
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 26, 2026
@bors
Auto merge of #154384 - JonathanBrouwer:rollup-Wou9g2B, r=JonathanBro…
9098134
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
- rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
- rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
- rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
- rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
- rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
- rust-lang/rust#154344 (Update LLVM to 22.1.2)
- rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- rust-lang/rust#154351 (Overhaul `Erasable` impls)
- rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
- rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
- rust-lang/rust#154090 (Move tests in the statics category)
- rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
- rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
- rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
- rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
- rust-lang/rust#154355 (delegation: add const type ICE test)
- rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #154384 - JonathanBrouwer:rollup-Wou9g2B, r=JonathanBro…
52a5fa7
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
- rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
- rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
- rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
- rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
- rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
- rust-lang/rust#154344 (Update LLVM to 22.1.2)
- rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- rust-lang/rust#154351 (Overhaul `Erasable` impls)
- rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
- rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
- rust-lang/rust#154090 (Move tests in the statics category)
- rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
- rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
- rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
- rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
- rust-lang/rust#154355 (delegation: add const type ICE test)
- rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KivooeoKivooeoKivooeo left review comments

Assignees

@KivooeoKivooeo

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@danieljofficial@rustbot@Kivooeo@rust-log-analyzer@jieyouxu