Skip to content

delegation: don't propagate synthetic params, remove lifetime hacks - #154364

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-generics-small-fixes
Mar 25, 2026
Merged

delegation: don't propagate synthetic params, remove lifetime hacks#154364
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-generics-small-fixes

Conversation

@aerooneqq

@aerooneqqaerooneqq commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Some small fixes after new delegation lowering was merged: remove lifetime hacks as now we get only early-bound lifetimes from generics, don't propagate synthetic generic params as now we know that they are synthetic. Fixes#143498. Part of #118212.

r? @petrochenkov

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2026
Comment threadtests/ui/delegation/generics/synth-params-ice-143498.rs
@rust-log-analyzer

This comment has been minimized.

@aerooneqqaerooneqq changed the title Delegation: don't propagate synthetic params, remove lifetime hacksdelegation: don't propagate synthetic params, remove lifetime hacksMar 25, 2026
@aerooneqq
aerooneqqforce-pushed the delegation-generics-small-fixes branch from 48edf69 to c2383b5CompareMarch 25, 2026 10:04
@petrochenkovpetrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Mar 25, 2026
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-borsBot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c2383b5 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 25, 2026
…l-fixes, r=petrochenkov
delegation: don't propagate synthetic params, remove lifetime hacks
Some small fixes after new delegation lowering was merged: remove lifetime hacks as now we get only early-bound lifetimes from generics, don't propagate synthetic generic params as now we know that they are synthetic. Fixesrust-lang#143498. Part of rust-lang#118212.
r? @petrochenkov
This was referenced Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- #153049 (Add `-Zsanitize=kernel-hwaddress`)
- #153702 (Add macro matcher for `guard` fragment specifier)
- #154200 (debuginfo: emit DW_TAG_call_site entries)
- #154263 (interpret: when passing an argument fails, point at that argument)
- #154269 (miri recursive validation: only check one layer deep)
- #154313 (Init `self_decl` with a correct visibility)
- #154344 (Update LLVM to 22.1.2)
- #154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- #154351 (Overhaul `Erasable` impls)
- #154363 (delegation: fix zero-args nested delegation ICE)
- #154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- #151148 (Add functions to `GrowableBitSet`)
- #154090 (Move tests in the statics category)
- #154112 (some `tests/ui/macros` cleanup)
- #154131 (begin `tests/ui/structs-enums` cleanup)
- #154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- #154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- #154233 (Move ui/issues tests to relevant subdirectories)
- #154288 (Fix typo in doc comment for `char::to_titlecase`)
- #154355 (delegation: add const type ICE test)
- #154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- #154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
@rust-bors
rust-borsBot merged commit c13e9ec into rust-lang:mainMar 25, 2026
11 checks passed
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 26, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
- rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
- rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
- rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
- rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
- rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
- rust-lang/rust#154344 (Update LLVM to 22.1.2)
- rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- rust-lang/rust#154351 (Overhaul `Erasable` impls)
- rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
- rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
- rust-lang/rust#154090 (Move tests in the statics category)
- rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
- rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
- rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
- rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
- rust-lang/rust#154355 (delegation: add const type ICE test)
- rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
@cuvipercuviper added this to the 1.96.0 milestone Apr 30, 2026
@aerooneqq
aerooneqq deleted the delegation-generics-small-fixes branch May 14, 2026 06:36
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
- rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
- rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
- rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
- rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
- rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
- rust-lang/rust#154344 (Update LLVM to 22.1.2)
- rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- rust-lang/rust#154351 (Overhaul `Erasable` impls)
- rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
- rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
- rust-lang/rust#154090 (Move tests in the statics category)
- rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
- rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
- rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
- rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
- rust-lang/rust#154355 (delegation: add const type ICE test)
- rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: delegation: DefId::expect_local DefId(..) isn't local

5 participants

@aerooneqq@rust-log-analyzer@petrochenkov@cuviper@rustbot