install-template.sh: Optimize by using Bourne shell builtins. - #154358

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
he32:installer-perf-fix-2
Mar 25, 2026
Merged

install-template.sh: Optimize by using Bourne shell builtins.#154358
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
he32:installer-perf-fix-2

Conversation

@he32

@he32he32 commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

This replaces forking separate processes and using "cut" with Bourne shell builtin operations for "remove largest suffix pattern" and "remove smallest prefix pattern" operations.

This is the follow-up of #145809

This replaces forking separate processes and using "cut" with Bourne
shell builtin operations for "remove largest suffix pattern" and
"remove smallest prefix pattern" operations.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 25, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-borsBot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 86aac98 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 25, 2026
install-template.sh: Optimize by using Bourne shell builtins.
This replaces forking separate processes and using "cut" with Bourne shell builtin operations for "remove largest suffix pattern" and "remove smallest prefix pattern" operations.
This is the follow-up of rust-lang#145809
This was referenced Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- #153049 (Add `-Zsanitize=kernel-hwaddress`)
- #153702 (Add macro matcher for `guard` fragment specifier)
- #154200 (debuginfo: emit DW_TAG_call_site entries)
- #154263 (interpret: when passing an argument fails, point at that argument)
- #154269 (miri recursive validation: only check one layer deep)
- #154313 (Init `self_decl` with a correct visibility)
- #154344 (Update LLVM to 22.1.2)
- #154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- #154351 (Overhaul `Erasable` impls)
- #154363 (delegation: fix zero-args nested delegation ICE)
- #154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- #151148 (Add functions to `GrowableBitSet`)
- #154090 (Move tests in the statics category)
- #154112 (some `tests/ui/macros` cleanup)
- #154131 (begin `tests/ui/structs-enums` cleanup)
- #154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- #154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- #154233 (Move ui/issues tests to relevant subdirectories)
- #154288 (Fix typo in doc comment for `char::to_titlecase`)
- #154355 (delegation: add const type ICE test)
- #154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- #154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
@rust-bors
rust-borsBot merged commit 796d52f into rust-lang:mainMar 25, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 25, 2026
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 26, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
- rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
- rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
- rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
- rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
- rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
- rust-lang/rust#154344 (Update LLVM to 22.1.2)
- rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- rust-lang/rust#154351 (Overhaul `Erasable` impls)
- rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
- rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
- rust-lang/rust#154090 (Move tests in the statics category)
- rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
- rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
- rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
- rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
- rust-lang/rust#154355 (delegation: add const type ICE test)
- rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
- rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
- rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
- rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
- rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
- rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
- rust-lang/rust#154344 (Update LLVM to 22.1.2)
- rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- rust-lang/rust#154351 (Overhaul `Erasable` impls)
- rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
- rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
- rust-lang/rust#154090 (Move tests in the statics category)
- rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
- rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
- rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
- rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
- rust-lang/rust#154355 (delegation: add const type ICE test)
- rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@he32@rustbot@jieyouxu
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); })();
Skip to content

install-template.sh: Optimize by using Bourne shell builtins. - #154358

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
he32:installer-perf-fix-2
Mar 25, 2026
Merged

install-template.sh: Optimize by using Bourne shell builtins.#154358
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
he32:installer-perf-fix-2

Conversation

@he32

@he32he32 commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

This replaces forking separate processes and using "cut" with Bourne shell builtin operations for "remove largest suffix pattern" and "remove smallest prefix pattern" operations.

This is the follow-up of #145809

This replaces forking separate processes and using "cut" with Bourne
shell builtin operations for "remove largest suffix pattern" and
"remove smallest prefix pattern" operations.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 25, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-borsBot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 86aac98 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 25, 2026
install-template.sh: Optimize by using Bourne shell builtins.
This replaces forking separate processes and using "cut" with Bourne shell builtin operations for "remove largest suffix pattern" and "remove smallest prefix pattern" operations.
This is the follow-up of rust-lang#145809
This was referenced Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- #153049 (Add `-Zsanitize=kernel-hwaddress`)
- #153702 (Add macro matcher for `guard` fragment specifier)
- #154200 (debuginfo: emit DW_TAG_call_site entries)
- #154263 (interpret: when passing an argument fails, point at that argument)
- #154269 (miri recursive validation: only check one layer deep)
- #154313 (Init `self_decl` with a correct visibility)
- #154344 (Update LLVM to 22.1.2)
- #154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- #154351 (Overhaul `Erasable` impls)
- #154363 (delegation: fix zero-args nested delegation ICE)
- #154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- #151148 (Add functions to `GrowableBitSet`)
- #154090 (Move tests in the statics category)
- #154112 (some `tests/ui/macros` cleanup)
- #154131 (begin `tests/ui/structs-enums` cleanup)
- #154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- #154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- #154233 (Move ui/issues tests to relevant subdirectories)
- #154288 (Fix typo in doc comment for `char::to_titlecase`)
- #154355 (delegation: add const type ICE test)
- #154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- #154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
@rust-bors
rust-borsBot merged commit 796d52f into rust-lang:mainMar 25, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 25, 2026
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 26, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
- rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
- rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
- rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
- rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
- rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
- rust-lang/rust#154344 (Update LLVM to 22.1.2)
- rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- rust-lang/rust#154351 (Overhaul `Erasable` impls)
- rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
- rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
- rust-lang/rust#154090 (Move tests in the statics category)
- rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
- rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
- rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
- rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
- rust-lang/rust#154355 (delegation: add const type ICE test)
- rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
- rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
- rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
- rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
- rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
- rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
- rust-lang/rust#154344 (Update LLVM to 22.1.2)
- rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
- rust-lang/rust#154351 (Overhaul `Erasable` impls)
- rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
- rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
- rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
- rust-lang/rust#154090 (Move tests in the statics category)
- rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
- rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
- rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
- rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
- rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
- rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
- rust-lang/rust#154355 (delegation: add const type ICE test)
- rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
- rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@he32@rustbot@jieyouxu