Skip to content

Positive test for closures needing expectations - #158694

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jdonszelmann:closure-inference
Jul 6, 2026
Merged

Positive test for closures needing expectations#158694
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jdonszelmann:closure-inference

Conversation

@jdonszelmann

Copy link
Copy Markdown
Contributor

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2026
Comment threadtests/ui/closures/closure_requires_expectation.rs Outdated

@WaffleLapkinWaffleLapkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, modulo lcnr's nit

View changes since this review

@jdonszelmann

Copy link
Copy Markdown
ContributorAuthor

@bors r=lcnr,wafflelapkin

@rust-bors

rust-borsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 3f92845 has been approved by lcnr,wafflelapkin

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2026
@jhprattjhpratt mentioned this pull request Jul 6, 2026
rust-borsBot pushed a commit that referenced this pull request Jul 6, 2026
Rollup of 24 pull requests
Successful merges:
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158642 (Clarify some interning details)
- #158694 (Positive test for closures needing expectations)
- #158743 (Look for cdb location in the registry first)
- #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- #158785 (hook intrinsic-test into aarch64-gnu)
- #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- #157734 (Stabilize `local_key_cell_update`)
- #158183 (std: allocate less memory in `current_exe` for OpenBSD)
- #158310 (Remove unexpected usage of Unambig in non-infer variants)
- #158671 (Move tests batch 17)
- #158730 (Update `FIXME(static_mut_refs)` comments)
- #158752 (Reorganize `tests/ui/issues` [18/N])
- #158755 (Use `ThinVec` more in the AST)
- #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- #158771 (library: expand HashSet::extract_if coverage)
- #158772 (rustc-dev-guide subtree update)
- #158776 (fix: emit diagnostic for AVR target without target-cpu)
- #158786 (Add regression test for builtin attr macro values)
- #158810 (Add supplementary information for get_unchecked(mut))
- #158825 (Fix typo)
- #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
rust-borsBot pushed a commit that referenced this pull request Jul 6, 2026
Rollup of 24 pull requests
Successful merges:
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158642 (Clarify some interning details)
- #158694 (Positive test for closures needing expectations)
- #158743 (Look for cdb location in the registry first)
- #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- #158785 (hook intrinsic-test into aarch64-gnu)
- #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- #157734 (Stabilize `local_key_cell_update`)
- #158183 (std: allocate less memory in `current_exe` for OpenBSD)
- #158310 (Remove unexpected usage of Unambig in non-infer variants)
- #158671 (Move tests batch 17)
- #158730 (Update `FIXME(static_mut_refs)` comments)
- #158752 (Reorganize `tests/ui/issues` [18/N])
- #158755 (Use `ThinVec` more in the AST)
- #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- #158771 (library: expand HashSet::extract_if coverage)
- #158772 (rustc-dev-guide subtree update)
- #158776 (fix: emit diagnostic for AVR target without target-cpu)
- #158786 (Add regression test for builtin attr macro values)
- #158810 (Add supplementary information for get_unchecked(mut))
- #158825 (Fix typo)
- #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
rust-borsBot pushed a commit that referenced this pull request Jul 6, 2026
Rollup of 24 pull requests
Successful merges:
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158642 (Clarify some interning details)
- #158694 (Positive test for closures needing expectations)
- #158743 (Look for cdb location in the registry first)
- #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- #158785 (hook intrinsic-test into aarch64-gnu)
- #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- #157734 (Stabilize `local_key_cell_update`)
- #158183 (std: allocate less memory in `current_exe` for OpenBSD)
- #158310 (Remove unexpected usage of Unambig in non-infer variants)
- #158671 (Move tests batch 17)
- #158730 (Update `FIXME(static_mut_refs)` comments)
- #158752 (Reorganize `tests/ui/issues` [18/N])
- #158755 (Use `ThinVec` more in the AST)
- #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- #158771 (library: expand HashSet::extract_if coverage)
- #158772 (rustc-dev-guide subtree update)
- #158776 (fix: emit diagnostic for AVR target without target-cpu)
- #158786 (Add regression test for builtin attr macro values)
- #158810 (Add supplementary information for get_unchecked(mut))
- #158825 (Fix typo)
- #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
@rust-bors
rust-borsBot merged commit 48ceecf into rust-lang:mainJul 6, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 6, 2026
rust-timer added a commit that referenced this pull request Jul 6, 2026
Rollup merge of #158694 - jdonszelmann:closure-inference, r=lcnr,wafflelapkin
Positive test for closures needing expectations
r? @lcnr
cc: @WaffleLapkin
pullBot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jul 7, 2026
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#158377 (add `-Zforce-intrinsic-fallback` flag)
- rust-lang/rust#158642 (Clarify some interning details)
- rust-lang/rust#158694 (Positive test for closures needing expectations)
- rust-lang/rust#158743 (Look for cdb location in the registry first)
- rust-lang/rust#158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- rust-lang/rust#158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- rust-lang/rust#158785 (hook intrinsic-test into aarch64-gnu)
- rust-lang/rust#158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- rust-lang/rust#157734 (Stabilize `local_key_cell_update`)
- rust-lang/rust#158183 (std: allocate less memory in `current_exe` for OpenBSD)
- rust-lang/rust#158310 (Remove unexpected usage of Unambig in non-infer variants)
- rust-lang/rust#158671 (Move tests batch 17)
- rust-lang/rust#158730 (Update `FIXME(static_mut_refs)` comments)
- rust-lang/rust#158752 (Reorganize `tests/ui/issues` [18/N])
- rust-lang/rust#158755 (Use `ThinVec` more in the AST)
- rust-lang/rust#158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- rust-lang/rust#158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- rust-lang/rust#158771 (library: expand HashSet::extract_if coverage)
- rust-lang/rust#158772 (rustc-dev-guide subtree update)
- rust-lang/rust#158776 (fix: emit diagnostic for AVR target without target-cpu)
- rust-lang/rust#158786 (Add regression test for builtin attr macro values)
- rust-lang/rust#158810 (Add supplementary information for get_unchecked(mut))
- rust-lang/rust#158825 (Fix typo)
- rust-lang/rust#158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 20, 2026
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#158377 (add `-Zforce-intrinsic-fallback` flag)
- rust-lang/rust#158642 (Clarify some interning details)
- rust-lang/rust#158694 (Positive test for closures needing expectations)
- rust-lang/rust#158743 (Look for cdb location in the registry first)
- rust-lang/rust#158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- rust-lang/rust#158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- rust-lang/rust#158785 (hook intrinsic-test into aarch64-gnu)
- rust-lang/rust#158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- rust-lang/rust#157734 (Stabilize `local_key_cell_update`)
- rust-lang/rust#158183 (std: allocate less memory in `current_exe` for OpenBSD)
- rust-lang/rust#158310 (Remove unexpected usage of Unambig in non-infer variants)
- rust-lang/rust#158671 (Move tests batch 17)
- rust-lang/rust#158730 (Update `FIXME(static_mut_refs)` comments)
- rust-lang/rust#158752 (Reorganize `tests/ui/issues` [18/N])
- rust-lang/rust#158755 (Use `ThinVec` more in the AST)
- rust-lang/rust#158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- rust-lang/rust#158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- rust-lang/rust#158771 (library: expand HashSet::extract_if coverage)
- rust-lang/rust#158772 (rustc-dev-guide subtree update)
- rust-lang/rust#158776 (fix: emit diagnostic for AVR target without target-cpu)
- rust-lang/rust#158786 (Add regression test for builtin attr macro values)
- rust-lang/rust#158810 (Add supplementary information for get_unchecked(mut))
- rust-lang/rust#158825 (Fix typo)
- rust-lang/rust#158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#158377 (add `-Zforce-intrinsic-fallback` flag)
- rust-lang/rust#158642 (Clarify some interning details)
- rust-lang/rust#158694 (Positive test for closures needing expectations)
- rust-lang/rust#158743 (Look for cdb location in the registry first)
- rust-lang/rust#158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- rust-lang/rust#158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- rust-lang/rust#158785 (hook intrinsic-test into aarch64-gnu)
- rust-lang/rust#158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- rust-lang/rust#157734 (Stabilize `local_key_cell_update`)
- rust-lang/rust#158183 (std: allocate less memory in `current_exe` for OpenBSD)
- rust-lang/rust#158310 (Remove unexpected usage of Unambig in non-infer variants)
- rust-lang/rust#158671 (Move tests batch 17)
- rust-lang/rust#158730 (Update `FIXME(static_mut_refs)` comments)
- rust-lang/rust#158752 (Reorganize `tests/ui/issues` [18/N])
- rust-lang/rust#158755 (Use `ThinVec` more in the AST)
- rust-lang/rust#158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- rust-lang/rust#158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- rust-lang/rust#158771 (library: expand HashSet::extract_if coverage)
- rust-lang/rust#158772 (rustc-dev-guide subtree update)
- rust-lang/rust#158776 (fix: emit diagnostic for AVR target without target-cpu)
- rust-lang/rust#158786 (Add regression test for builtin attr macro values)
- rust-lang/rust#158810 (Add supplementary information for get_unchecked(mut))
- rust-lang/rust#158825 (Fix typo)
- rust-lang/rust#158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jdonszelmann@lcnr@WaffleLapkin@rustbot