Add regression test for builtin attr macro values by Ap4sh · Pull Request #158786 · rust-lang/rust

Ap4sh · 2026-07-04T19:57:57Z

Adds a UI regression test for #145922

The test covers builtin attributes whose value is a macro call on a macro item, including the extra attributes mentioned in the issue thread. windows_subsystem still emits its normal malformed-attribute error; the other cases make sure they don't regress into the delayed ICE again

Fixes#145922

Tested:

python3 x.py test tests/ui/attributes/builtin-attr-macro-value-issue-145922.rs --force-rerun -j 2
python3 x.py test tidy -j 2

rustbot · 2026-07-04T19:58:02Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @folkertdev (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 22 candidates

folkertdev

and then you may need //@ check-pass up top, and can delete the .stderr file, because we want these to work.

(as opposed to tests/ui/attributes/crate-name-macro-call.rs which should fail).

View changes since this review

folkertdev · 2026-07-05T16:57:42Z

+ };
+}
+
+#[windows_subsystem = concat!("a", "b")]


Suggested change
#[windows_subsystem = concat!("a","b")]
#[windows_subsystem = concat!("cons","ole")]

rustbot · 2026-07-05T16:59:29Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Ap4sh · 2026-07-05T17:07:43Z

@rustbot ready

folkertdev · 2026-07-05T22:08:46Z

Nice, thanks!

@bors r+ rollup

rust-bors · 2026-07-05T22:08:49Z

📌 Commit ee05842 has been approved by folkertdev

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 2. This pull request will be tested once the tree is reopened.

…ttr-macro-values, r=folkertdev Add regression test for builtin attr macro values Adds a UI regression test for rust-lang#145922 The test covers builtin attributes whose value is a macro call on a macro item, including the extra attributes mentioned in the issue thread. `windows_subsystem` still emits its normal malformed-attribute error; the other cases make sure they don't regress into the delayed ICE again Fixesrust-lang#145922 Tested: - `python3 x.py test tests/ui/attributes/builtin-attr-macro-value-issue-145922.rs --force-rerun -j 2` - `python3 x.py test tidy -j 2`

Rollup of 20 pull requests Successful merges: - #158377 (add `-Zforce-intrinsic-fallback` flag) - #158642 (Clarify some interning details) - #158743 (Look for cdb location in the registry first) - #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space) - #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage) - #158785 (hook intrinsic-test into aarch64-gnu) - #157734 (Stabilize `local_key_cell_update`) - #158183 (std: allocate less memory in `current_exe` for OpenBSD) - #158671 (Move tests batch 17) - #158730 (Update `FIXME(static_mut_refs)` comments) - #158752 (Reorganize `tests/ui/issues` [18/N]) - #158755 (Use `ThinVec` more in the AST) - #158757 (Fix incorrect tracking issue for `read_le`/`read_be`) - #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`) - #158771 (library: expand HashSet::extract_if coverage) - #158772 (rustc-dev-guide subtree update) - #158776 (fix: emit diagnostic for AVR target without target-cpu) - #158786 (Add regression test for builtin attr macro values) - #158807 (Add regression test for CString::clone_into unwind safety) - #158825 (Fix typo)

Rollup of 24 pull requests Successful merges: - #158377 (add `-Zforce-intrinsic-fallback` flag) - #158642 (Clarify some interning details) - #158694 (Positive test for closures needing expectations) - #158743 (Look for cdb location in the registry first) - #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space) - #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage) - #158785 (hook intrinsic-test into aarch64-gnu) - #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster) - #157734 (Stabilize `local_key_cell_update`) - #158183 (std: allocate less memory in `current_exe` for OpenBSD) - #158310 (Remove unexpected usage of Unambig in non-infer variants) - #158671 (Move tests batch 17) - #158730 (Update `FIXME(static_mut_refs)` comments) - #158752 (Reorganize `tests/ui/issues` [18/N]) - #158755 (Use `ThinVec` more in the AST) - #158757 (Fix incorrect tracking issue for `read_le`/`read_be`) - #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`) - #158771 (library: expand HashSet::extract_if coverage) - #158772 (rustc-dev-guide subtree update) - #158776 (fix: emit diagnostic for AVR target without target-cpu) - #158786 (Add regression test for builtin attr macro values) - #158810 (Add supplementary information for get_unchecked(mut)) - #158825 (Fix typo) - #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)

Rollup merge of #158786 - Ap4sh:ap4sh/issue-145922-builtin-attr-macro-values, r=folkertdev Add regression test for builtin attr macro values Adds a UI regression test for #145922 The test covers builtin attributes whose value is a macro call on a macro item, including the extra attributes mentioned in the issue thread. `windows_subsystem` still emits its normal malformed-attribute error; the other cases make sure they don't regress into the delayed ICE again Fixes#145922 Tested: - `python3 x.py test tests/ui/attributes/builtin-attr-macro-value-issue-145922.rs --force-rerun -j 2` - `python3 x.py test tidy -j 2`

Rollup of 24 pull requests Successful merges: - rust-lang/rust#158377 (add `-Zforce-intrinsic-fallback` flag) - rust-lang/rust#158642 (Clarify some interning details) - rust-lang/rust#158694 (Positive test for closures needing expectations) - rust-lang/rust#158743 (Look for cdb location in the registry first) - rust-lang/rust#158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space) - rust-lang/rust#158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage) - rust-lang/rust#158785 (hook intrinsic-test into aarch64-gnu) - rust-lang/rust#158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster) - rust-lang/rust#157734 (Stabilize `local_key_cell_update`) - rust-lang/rust#158183 (std: allocate less memory in `current_exe` for OpenBSD) - rust-lang/rust#158310 (Remove unexpected usage of Unambig in non-infer variants) - rust-lang/rust#158671 (Move tests batch 17) - rust-lang/rust#158730 (Update `FIXME(static_mut_refs)` comments) - rust-lang/rust#158752 (Reorganize `tests/ui/issues` [18/N]) - rust-lang/rust#158755 (Use `ThinVec` more in the AST) - rust-lang/rust#158757 (Fix incorrect tracking issue for `read_le`/`read_be`) - rust-lang/rust#158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`) - rust-lang/rust#158771 (library: expand HashSet::extract_if coverage) - rust-lang/rust#158772 (rustc-dev-guide subtree update) - rust-lang/rust#158776 (fix: emit diagnostic for AVR target without target-cpu) - rust-lang/rust#158786 (Add regression test for builtin attr macro values) - rust-lang/rust#158810 (Add supplementary information for get_unchecked(mut)) - rust-lang/rust#158825 (Fix typo) - rust-lang/rust#158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 4, 2026

rustbot assigned folkertdev Jul 4, 2026

folkertdev requested changes Jul 5, 2026
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2026

Add regression test for builtin attr macro values
ee05842

Ap4sh force-pushed the ap4sh/issue-145922-builtin-attr-macro-values branch from 0c38332 to ee05842Compare July 5, 2026 17:07

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2026

jhpratt mentioned this pull request Jul 6, 2026
Rollup of 20 pull requests #158837
Closed

jhpratt mentioned this pull request Jul 6, 2026
Rollup of 24 pull requests #158847
Merged

rust-borsBot merged commit 953045d into rust-lang:mainJul 6, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 6, 2026

Navigation Menu

Uh oh!

Uh oh!

Add regression test for builtin attr macro values - #158786

Add regression test for builtin attr macro values#158786
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Ap4sh:ap4sh/issue-145922-builtin-attr-macro-values

Ap4sh commented Jul 4, 2026•
edited by rustbot
Loading

Uh oh!

rustbot commented Jul 4, 2026

Uh oh!

folkertdev left a comment •
edited by rustbot
Loading

Uh oh!

folkertdevJul 5, 2026

Uh oh!

rustbot commented Jul 5, 2026

Uh oh!

Ap4sh commented Jul 5, 2026

Uh oh!

folkertdev commented Jul 5, 2026

Uh oh!

rust-borsBot commented Jul 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	#[windows_subsystem = concat!("a","b")]
	#[windows_subsystem = concat!("cons","ole")]

Uh oh!

Uh oh!

Conversation

Ap4sh commented Jul 4, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 4, 2026

Uh oh!

folkertdev left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

folkertdevJul 5, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jul 5, 2026

Uh oh!

Ap4sh commented Jul 5, 2026

Uh oh!

folkertdev commented Jul 5, 2026

Uh oh!

rust-borsBot commented Jul 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ap4sh commented Jul 4, 2026•
edited by rustbot
Loading

folkertdev left a comment •
edited by rustbot
Loading