Use `ThinVec` more in the AST - #158755

Merged

rust-bors[bot] merged 3 commits into

rust-lang:mainfrom

nnethercote:ast-ThinVec

Jul 6, 2026

nnethercote commented Jul 4, 2026•
edited
Loading

Contributor

For consistency; it has negligible effects on perf. Details in individual commits.

nnethercote added 3 commits

July 4, 2026 09:55

Add some more AST size assertions

ba53d1b

Use ThinVec in Expr::OffsetOf

b14e429

Because we use `ThinVec` rather than `Vec` almost everywhere else in the
AST.

Use ThinVec in GenericBounds

3a0a977

Because we use `ThinVec` rather than `Vec` almost everywhere else in the
AST.

rustbot added S-waiting-on-author T-compiler labels

nnethercote commented Jul 4, 2026

ContributorAuthor

@bors try @rust-timer queue

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf label

This comment has been minimized.

Sign in to view

rust-borsBot pushed a commit that referenced this pull request

Auto merge of#158755- nnethercote:ast-ThinVec, r=<try>

973fa09

Use `ThinVec` more in the AST

rust-borsBot commented Jul 4, 2026

Contributor

☀️ Try build successful (CI)
Build commit: 973fa09 (973fa097ee83e915d5a9ba83a9cbb259b4573170)
Base parent: c397dae (c397dae808f70caebab1fc4e11b3edf7e59f58c7)

This comment has been minimized.

Sign in to view

rust-timer commented Jul 4, 2026

Collaborator

Finished benchmarking commit (973fa09): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.3%, secondary -5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.8%, 1.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-5.6%	[-5.7%, -5.5%]	2
All ❌✅ (primary)	0.3%	[-1.4%, 1.0%]	4

Cycles

Results (primary 2.2%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-5.5%, -2.4%]	3
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.944s -> 484.62s (-0.27%)
Artifact size: 393.37 MiB -> 393.83 MiB (0.12%)

rustbot removed the S-waiting-on-perf label

rustbot assigned mejrs

nnethercote marked this pull request as ready for review

July 4, 2026 12:44

rustbot commented Jul 4, 2026

Collaborator

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

rustbot added S-waiting-on-review and removed S-waiting-on-author labels

mejrs reviewed

View reviewed changes

mejrs left a comment •
edited by rustbot
Loading

Member

@bors r+ rollup

View changes since this review

rust-borsBot commented Jul 4, 2026

Contributor

📌 Commit 3a0a977 has been approved by mejrs

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

rust-borsBot added S-waiting-on-bors and removed S-waiting-on-review labels

jhpratt added a commit to jhpratt/rust that referenced this pull request

Rollup merge ofrust-lang#158755- nnethercote:ast-ThinVec, r=mejrs

9b6e394

Use `ThinVec` more in the AST
For consistency; it has negligible effects on perf. Details in individual commits.
r? @mejrs

jhpratt mentioned this pull request

Rollup of 13 pull requests #158790

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request

Rollup merge ofrust-lang#158755- nnethercote:ast-ThinVec, r=mejrs

aef9bb3

Use `ThinVec` more in the AST
For consistency; it has negligible effects on perf. Details in individual commits.
r? @mejrs

jhpratt mentioned this pull request

Rollup of 12 pull requests #158793

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request

Rollup merge ofrust-lang#158755- nnethercote:ast-ThinVec, r=mejrs

ea1c0f3

Use `ThinVec` more in the AST
For consistency; it has negligible effects on perf. Details in individual commits.
r? @mejrs

JonathanBrouwer mentioned this pull request

Rollup of 12 pull requests #158806

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request

Rollup merge ofrust-lang#158755- nnethercote:ast-ThinVec, r=mejrs

8b1ee68

Use `ThinVec` more in the AST
For consistency; it has negligible effects on perf. Details in individual commits.
r? @mejrs

JonathanBrouwer mentioned this pull request

Rollup of 12 pull requests #158815

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request

Rollup merge ofrust-lang#158755- nnethercote:ast-ThinVec, r=mejrs

f991496

Use `ThinVec` more in the AST
For consistency; it has negligible effects on perf. Details in individual commits.
r? @mejrs

JonathanBrouwer mentioned this pull request

Rollup of 16 pull requests #158828

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request

Rollup merge ofrust-lang#158755- nnethercote:ast-ThinVec, r=mejrs

9ab04cf

Use `ThinVec` more in the AST
For consistency; it has negligible effects on perf. Details in individual commits.
r? @mejrs

jhpratt mentioned this pull request

Rollup of 20 pull requests #158837

Closed

rust-borsBot pushed a commit that referenced this pull request

Auto merge of#158837- jhpratt:rollup-KBtLguc, r=jhpratt

67e9636

Rollup of 20 pull requests
Successful merges:
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158642 (Clarify some interning details)
- #158743 (Look for cdb location in the registry first)
- #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- #158785 (hook intrinsic-test into aarch64-gnu)
- #157734 (Stabilize `local_key_cell_update`)
- #158183 (std: allocate less memory in `current_exe` for OpenBSD)
- #158671 (Move tests batch 17)
- #158730 (Update `FIXME(static_mut_refs)` comments)
- #158752 (Reorganize `tests/ui/issues` [18/N])
- #158755 (Use `ThinVec` more in the AST)
- #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- #158771 (library: expand HashSet::extract_if coverage)
- #158772 (rustc-dev-guide subtree update)
- #158776 (fix: emit diagnostic for AVR target without target-cpu)
- #158786 (Add regression test for builtin attr macro values)
- #158807 (Add regression test for CString::clone_into unwind safety)
- #158825 (Fix typo)

jhpratt mentioned this pull request

Rollup of 24 pull requests #158847

Merged

rust-borsBot pushed a commit that referenced this pull request

Auto merge of#158847- jhpratt:rollup-MkjhKjV, r=jhpratt

29d802f

Rollup of 24 pull requests
Successful merges:
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158642 (Clarify some interning details)
- #158694 (Positive test for closures needing expectations)
- #158743 (Look for cdb location in the registry first)
- #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- #158785 (hook intrinsic-test into aarch64-gnu)
- #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- #157734 (Stabilize `local_key_cell_update`)
- #158183 (std: allocate less memory in `current_exe` for OpenBSD)
- #158310 (Remove unexpected usage of Unambig in non-infer variants)
- #158671 (Move tests batch 17)
- #158730 (Update `FIXME(static_mut_refs)` comments)
- #158752 (Reorganize `tests/ui/issues` [18/N])
- #158755 (Use `ThinVec` more in the AST)
- #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- #158771 (library: expand HashSet::extract_if coverage)
- #158772 (rustc-dev-guide subtree update)
- #158776 (fix: emit diagnostic for AVR target without target-cpu)
- #158786 (Add regression test for builtin attr macro values)
- #158810 (Add supplementary information for get_unchecked(mut))
- #158825 (Fix typo)
- #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)

rust-borsBot pushed a commit that referenced this pull request

Auto merge of#158847- jhpratt:rollup-MkjhKjV, r=jhpratt

315eb8b

Rollup of 24 pull requests
Successful merges:
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158642 (Clarify some interning details)
- #158694 (Positive test for closures needing expectations)
- #158743 (Look for cdb location in the registry first)
- #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- #158785 (hook intrinsic-test into aarch64-gnu)
- #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- #157734 (Stabilize `local_key_cell_update`)
- #158183 (std: allocate less memory in `current_exe` for OpenBSD)
- #158310 (Remove unexpected usage of Unambig in non-infer variants)
- #158671 (Move tests batch 17)
- #158730 (Update `FIXME(static_mut_refs)` comments)
- #158752 (Reorganize `tests/ui/issues` [18/N])
- #158755 (Use `ThinVec` more in the AST)
- #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- #158771 (library: expand HashSet::extract_if coverage)
- #158772 (rustc-dev-guide subtree update)
- #158776 (fix: emit diagnostic for AVR target without target-cpu)
- #158786 (Add regression test for builtin attr macro values)
- #158810 (Add supplementary information for get_unchecked(mut))
- #158825 (Fix typo)
- #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)

rust-borsBot pushed a commit that referenced this pull request

Auto merge of#158847- jhpratt:rollup-MkjhKjV, r=jhpratt

c4af710

Rollup of 24 pull requests
Successful merges:
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158642 (Clarify some interning details)
- #158694 (Positive test for closures needing expectations)
- #158743 (Look for cdb location in the registry first)
- #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- #158785 (hook intrinsic-test into aarch64-gnu)
- #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- #157734 (Stabilize `local_key_cell_update`)
- #158183 (std: allocate less memory in `current_exe` for OpenBSD)
- #158310 (Remove unexpected usage of Unambig in non-infer variants)
- #158671 (Move tests batch 17)
- #158730 (Update `FIXME(static_mut_refs)` comments)
- #158752 (Reorganize `tests/ui/issues` [18/N])
- #158755 (Use `ThinVec` more in the AST)
- #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- #158771 (library: expand HashSet::extract_if coverage)
- #158772 (rustc-dev-guide subtree update)
- #158776 (fix: emit diagnostic for AVR target without target-cpu)
- #158786 (Add regression test for builtin attr macro values)
- #158810 (Add supplementary information for get_unchecked(mut))
- #158825 (Fix typo)
- #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)

rust-borsBot merged commit eadd942 into rust-lang:main

14 checks passed

rustbot added this to the 1.99.0 milestone

rust-timer added a commit that referenced this pull request

Unrolled build for#158755

8646ca4

Rollup merge of #158755 - nnethercote:ast-ThinVec, r=mejrs
Use `ThinVec` more in the AST
For consistency; it has negligible effects on perf. Details in individual commits.
r? @mejrs

nnethercote deleted the ast-ThinVec branch

July 6, 2026 23:08

pullBot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request

Auto merge of #158847 - jhpratt:rollup-MkjhKjV, r=jhpratt

a2587f8

Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#158377 (add `-Zforce-intrinsic-fallback` flag)
- rust-lang/rust#158642 (Clarify some interning details)
- rust-lang/rust#158694 (Positive test for closures needing expectations)
- rust-lang/rust#158743 (Look for cdb location in the registry first)
- rust-lang/rust#158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- rust-lang/rust#158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- rust-lang/rust#158785 (hook intrinsic-test into aarch64-gnu)
- rust-lang/rust#158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- rust-lang/rust#157734 (Stabilize `local_key_cell_update`)
- rust-lang/rust#158183 (std: allocate less memory in `current_exe` for OpenBSD)
- rust-lang/rust#158310 (Remove unexpected usage of Unambig in non-infer variants)
- rust-lang/rust#158671 (Move tests batch 17)
- rust-lang/rust#158730 (Update `FIXME(static_mut_refs)` comments)
- rust-lang/rust#158752 (Reorganize `tests/ui/issues` [18/N])
- rust-lang/rust#158755 (Use `ThinVec` more in the AST)
- rust-lang/rust#158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- rust-lang/rust#158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- rust-lang/rust#158771 (library: expand HashSet::extract_if coverage)
- rust-lang/rust#158772 (rustc-dev-guide subtree update)
- rust-lang/rust#158776 (fix: emit diagnostic for AVR target without target-cpu)
- rust-lang/rust#158786 (Add regression test for builtin attr macro values)
- rust-lang/rust#158810 (Add supplementary information for get_unchecked(mut))
- rust-lang/rust#158825 (Fix typo)
- rust-lang/rust#158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)

github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Auto merge of #158847 - jhpratt:rollup-MkjhKjV, r=jhpratt

45b5e12

Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#158377 (add `-Zforce-intrinsic-fallback` flag)
- rust-lang/rust#158642 (Clarify some interning details)
- rust-lang/rust#158694 (Positive test for closures needing expectations)
- rust-lang/rust#158743 (Look for cdb location in the registry first)
- rust-lang/rust#158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- rust-lang/rust#158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- rust-lang/rust#158785 (hook intrinsic-test into aarch64-gnu)
- rust-lang/rust#158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- rust-lang/rust#157734 (Stabilize `local_key_cell_update`)
- rust-lang/rust#158183 (std: allocate less memory in `current_exe` for OpenBSD)
- rust-lang/rust#158310 (Remove unexpected usage of Unambig in non-infer variants)
- rust-lang/rust#158671 (Move tests batch 17)
- rust-lang/rust#158730 (Update `FIXME(static_mut_refs)` comments)
- rust-lang/rust#158752 (Reorganize `tests/ui/issues` [18/N])
- rust-lang/rust#158755 (Use `ThinVec` more in the AST)
- rust-lang/rust#158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- rust-lang/rust#158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- rust-lang/rust#158771 (library: expand HashSet::extract_if coverage)
- rust-lang/rust#158772 (rustc-dev-guide subtree update)
- rust-lang/rust#158776 (fix: emit diagnostic for AVR target without target-cpu)
- rust-lang/rust#158786 (Add regression test for builtin attr macro values)
- rust-lang/rust#158810 (Add supplementary information for get_unchecked(mut))
- rust-lang/rust#158825 (Fix typo)
- rust-lang/rust#158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)

flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request

Auto merge of #158847 - jhpratt:rollup-MkjhKjV, r=jhpratt

e365fb0

Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#158377 (add `-Zforce-intrinsic-fallback` flag)
- rust-lang/rust#158642 (Clarify some interning details)
- rust-lang/rust#158694 (Positive test for closures needing expectations)
- rust-lang/rust#158743 (Look for cdb location in the registry first)
- rust-lang/rust#158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
- rust-lang/rust#158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
- rust-lang/rust#158785 (hook intrinsic-test into aarch64-gnu)
- rust-lang/rust#158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
- rust-lang/rust#157734 (Stabilize `local_key_cell_update`)
- rust-lang/rust#158183 (std: allocate less memory in `current_exe` for OpenBSD)
- rust-lang/rust#158310 (Remove unexpected usage of Unambig in non-infer variants)
- rust-lang/rust#158671 (Move tests batch 17)
- rust-lang/rust#158730 (Update `FIXME(static_mut_refs)` comments)
- rust-lang/rust#158752 (Reorganize `tests/ui/issues` [18/N])
- rust-lang/rust#158755 (Use `ThinVec` more in the AST)
- rust-lang/rust#158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
- rust-lang/rust#158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
- rust-lang/rust#158771 (library: expand HashSet::extract_if coverage)
- rust-lang/rust#158772 (rustc-dev-guide subtree update)
- rust-lang/rust#158776 (fix: emit diagnostic for AVR target without target-cpu)
- rust-lang/rust#158786 (Add regression test for builtin attr macro values)
- rust-lang/rust#158810 (Add supplementary information for get_unchecked(mut))
- rust-lang/rust#158825 (Fix typo)
- rust-lang/rust#158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment