Rename ModDefId to ModId and use more by camsteffen · Pull Request #159197 · rust-lang/rust

camsteffen · 2026-07-12T22:42:26Z

Addresses some FIXMEs.

The ModDefId was used pretty sparingly, and honestly I wondered if it should exist at all. After making these changes, I think the type is worth it. Most notably it is now used in Visibility::Restricted.

I first renamed ModDefId to ModId since I think the former is over-specific, and also this is more in line with BodyId or OwnerId.

I'll wait for initial feedback before fixing rustdoc/clippy.

rustbot · 2026-07-12T22:42:29Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

HIR ty lowering was modified

cc @fmease

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-07-12T22:42:31Z

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

petrochenkov · 2026-07-13T15:43:12Z

I wondered if it should exist at all. After making these changes, I think the type is worth it.

I think using (Local)ModId in visibilities and other places finally gave it some acceptable level of usefulness, yes.

rustbot · 2026-07-14T02:33:44Z

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

camsteffen · 2026-07-14T03:19:53Z

@rustbot ready

petrochenkov · 2026-07-14T10:16:24Z

CI failed due to a spurious network error.
r? me @bors r+

rust-bors · 2026-07-14T10:16:27Z

📌 Commit acdd18e has been approved by petrochenkov

It is now in the queue for this repository.

JonathanBrouwer · 2026-07-14T11:41:44Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #159278 (comment)

rust-bors · 2026-07-14T11:41:55Z

This pull request was unapproved.

This PR was contained in a rollup (#159278), which was unapproved.

View changes since this unapproval

JonathanBrouwer · 2026-07-14T11:43:27Z

Also this one I think
#159278 (comment)

rustbot · 2026-07-14T13:24:08Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

camsteffen · 2026-07-14T17:09:11Z

Fixed the errors. @rustbot ready

petrochenkov · 2026-07-15T10:28:38Z

@bors r+

rust-bors · 2026-07-15T10:28:41Z

📌 Commit 2c70f93 has been approved by petrochenkov

It is now in the queue for this repository.

…uwer Rollup of 8 pull requests Successful merges: - #159197 (Rename ModDefId to ModId and use more) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #159296 (Implement `bool::toggle`) - #158302 (Fix `overflowing_literals` lint with repeated negation) - #158484 (Add documentation for the `cold` and `track_caller` attributes) - #159239 (Add codegen test for remainder match) - #159330 (fix some edition annotations in UI tests) - #159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs) Failed merges: - #158962 (Add `proc_macro` attribute documentation)

Rollup merge of #159197 - camsteffen:more-modid, r=petrochenkov Rename ModDefId to ModId and use more Addresses some FIXMEs. The `ModDefId` was used pretty sparingly, and honestly I wondered if it should exist at all. After making these changes, I think the type is worth it. Most notably it is now used in `Visibility::Restricted`. I first renamed `ModDefId` to `ModId` since I think the former is over-specific, and also this is more in line with `BodyId` or `OwnerId`. I'll wait for initial feedback before fixing rustdoc/clippy.

Rename ModDefId to ModId and use more Addresses some FIXMEs. The `ModDefId` was used pretty sparingly, and honestly I wondered if it should exist at all. After making these changes, I think the type is worth it. Most notably it is now used in `Visibility::Restricted`. I first renamed `ModDefId` to `ModId` since I think the former is over-specific, and also this is more in line with `BodyId` or `OwnerId`. I'll wait for initial feedback before fixing rustdoc/clippy.

…uwer Rollup of 8 pull requests Successful merges: - rust-lang/rust#159197 (Rename ModDefId to ModId and use more) - rust-lang/rust#159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - rust-lang/rust#159296 (Implement `bool::toggle`) - rust-lang/rust#158302 (Fix `overflowing_literals` lint with repeated negation) - rust-lang/rust#158484 (Add documentation for the `cold` and `track_caller` attributes) - rust-lang/rust#159239 (Add codegen test for remainder match) - rust-lang/rust#159330 (fix some edition annotations in UI tests) - rust-lang/rust#159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs) Failed merges: - rust-lang/rust#158962 (Add `proc_macro` attribute documentation)

rustbot assigned JonathanBrouwer Jul 12, 2026

This comment has been minimized.
Sign in to view

petrochenkov self-assigned this Jul 13, 2026

petrochenkov reviewed Jul 13, 2026
View reviewed changes

Comment threadcompiler/rustc_metadata/src/rmeta/encoder.rs Outdated
Comment threadcompiler/rustc_metadata/src/rmeta/encoder.rs Outdated

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2026

camsteffen force-pushed the more-modid branch from 59fd5e1 to 430dc1bCompare July 14, 2026 02:33

rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-clippy Relevant to the Clippy team. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 14, 2026

This comment has been minimized.
Sign in to view

camsteffen force-pushed the more-modid branch from 430dc1b to acdd18eCompare July 14, 2026 02:42

This comment has been minimized.
Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2026

rustbot unassigned JonathanBrouwer Jul 14, 2026

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2026

This comment has been minimized.
Sign in to view

camsteffen added 6 commits July 14, 2026 07:31

Add Into<DefId> to is_descendant_of
1f5e4ba

Inline typed_def_id macro
d26029d

Rename ModDefId to ModId
df3766d

Use ModId more
3c0923a

Fix rustdoc with ModId refactors
60d52ca

Fix clippy with ModId refactors
2c70f93

camsteffen force-pushed the more-modid branch from acdd18e to 2c70f93Compare July 14, 2026 13:24

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026

JonathanBrouwer mentioned this pull request Jul 15, 2026
Rollup of 8 pull requests #159336
Merged

rust-borsBot merged commit 8fdc29c into rust-lang:mainJul 15, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 15, 2026

Uh oh!

Uh oh!

Conversation

camsteffen commented Jul 12, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 12, 2026

Uh oh!

rustbot commented Jul 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

petrochenkov commented Jul 13, 2026

Uh oh!

rustbot commented Jul 14, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

camsteffen commented Jul 14, 2026

Uh oh!

petrochenkov commented Jul 14, 2026

Uh oh!

rust-borsBot commented Jul 14, 2026

Uh oh!

JonathanBrouwer commented Jul 14, 2026

Uh oh!

rust-borsBot commented Jul 14, 2026

Uh oh!

JonathanBrouwer commented Jul 14, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jul 14, 2026

Uh oh!

camsteffen commented Jul 14, 2026

Uh oh!

petrochenkov commented Jul 15, 2026

Uh oh!

rust-borsBot commented Jul 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

camsteffen commented Jul 12, 2026•
edited by rustbot
Loading