Skip to content

Implement bool::toggle - #159296

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
CenTdemeern1:bool_toggle
Jul 15, 2026
Merged

Implement bool::toggle#159296
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
CenTdemeern1:bool_toggle

Conversation

@CenTdemeern1

@CenTdemeern1CenTdemeern1 commented Jul 14, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This implements bool::toggle as originally proposed and accepted in rust-lang/libs-team#820.
Tracking issue: #159298

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 14, 2026
@rustbot

rustbot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

@camsteffen

camsteffen commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I'd be happy to open a tracking issue if requested.

Go for it! You can replace issue = "none" with the tracking issue number as well.

camsteffen
camsteffen reviewed Jul 14, 2026
View reviewed changes
Comment threadlibrary/core/src/bool.rs
@CenTdemeern1CenTdemeern1 mentioned this pull request Jul 14, 2026
Closed
5 tasks
camsteffen
camsteffen reviewed Jul 14, 2026
View reviewed changes
Comment threadlibrary/core/src/bool.rs Outdated
CenTdemeern1and others added 2 commits July 14, 2026 19:24
@camsteffen

camsteffen commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@JohnTitor Oh sorry I'm not a rustc reviewer.

@chenyukang

chenyukang commented Jul 15, 2026

Copy link
Copy Markdown
Member

@bors r=chenyukang

@rust-bors

rust-borsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 3e03dd3 has been approved by chenyukang

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 15, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of#159336- JonathanBrouwer:rollup-A47hpCX, r=JonathanBro…
21aae1f
…uwer
Rollup of 8 pull requests
Successful merges:
- #159197 (Rename ModDefId to ModId and use more)
- #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- #159296 (Implement `bool::toggle`)
- #158302 (Fix `overflowing_literals` lint with repeated negation)
- #158484 (Add documentation for the `cold` and `track_caller` attributes)
- #159239 (Add codegen test for remainder match)
- #159330 (fix some edition annotations in UI tests)
- #159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs)
Failed merges:
- #158962 (Add `proc_macro` attribute documentation)
rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of#159336- JonathanBrouwer:rollup-A47hpCX, r=JonathanBro…
177ae4f
…uwer
Rollup of 8 pull requests
Successful merges:
- #159197 (Rename ModDefId to ModId and use more)
- #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- #159296 (Implement `bool::toggle`)
- #158302 (Fix `overflowing_literals` lint with repeated negation)
- #158484 (Add documentation for the `cold` and `track_caller` attributes)
- #159239 (Add codegen test for remainder match)
- #159330 (fix some edition annotations in UI tests)
- #159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs)
Failed merges:
- #158962 (Add `proc_macro` attribute documentation)
rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of#159336- JonathanBrouwer:rollup-A47hpCX, r=JonathanBro…
2118366
…uwer
Rollup of 8 pull requests
Successful merges:
- #159197 (Rename ModDefId to ModId and use more)
- #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- #159296 (Implement `bool::toggle`)
- #158302 (Fix `overflowing_literals` lint with repeated negation)
- #158484 (Add documentation for the `cold` and `track_caller` attributes)
- #159239 (Add codegen test for remainder match)
- #159330 (fix some edition annotations in UI tests)
- #159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs)
Failed merges:
- #158962 (Add `proc_macro` attribute documentation)
@rust-bors
rust-borsBot merged commit 3e648f7 into rust-lang:mainJul 15, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 15, 2026
rust-timer added a commit that referenced this pull request Jul 15, 2026
@rust-timer
Unrolled build for#159296
e401315
Rollup merge of #159296 - CenTdemeern1:bool_toggle, r=chenyukang
Implement `bool::toggle`
This implements `bool::toggle` as originally proposed and accepted in rust-lang/libs-team#820.
Tracking issue: #159298
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #159336 - JonathanBrouwer:rollup-A47hpCX, r=JonathanBro…
76baea8
…uwer
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#159197 (Rename ModDefId to ModId and use more)
- rust-lang/rust#159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- rust-lang/rust#159296 (Implement `bool::toggle`)
- rust-lang/rust#158302 (Fix `overflowing_literals` lint with repeated negation)
- rust-lang/rust#158484 (Add documentation for the `cold` and `track_caller` attributes)
- rust-lang/rust#159239 (Add codegen test for remainder match)
- rust-lang/rust#159330 (fix some edition annotations in UI tests)
- rust-lang/rust#159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs)
Failed merges:
- rust-lang/rust#158962 (Add `proc_macro` attribute documentation)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@camsteffencamsteffencamsteffen left review comments
@asquared31415asquared31415asquared31415 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@camsteffencamsteffen

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

6 participants

@CenTdemeern1@rustbot@camsteffen@chenyukang@asquared31415@JohnTitor