Skip to content

Add codegen test for remainder match - #159239

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
amirHdev:add-codegen-test-rem-match-unreachable
Jul 15, 2026
Merged

Add codegen test for remainder match#159239
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
amirHdev:add-codegen-test-rem-match-unreachable

Conversation

@amirHdev

@amirHdevamirHdev commented Jul 13, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Closes#93514

@amirHdev
chore: add codegen test for remainder match
d376c08
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2026
@rustbot

rustbot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

mejrs
mejrs approved these changes Jul 14, 2026
View reviewed changes

@mejrsmejrs left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bors r+ rollup

View changes since this review

@rust-bors

rust-borsBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d376c08 has been approved by mejrs

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 14, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#159239- amirHdev:add-codegen-test-rem-matc…
583aaa8
…h-unreachable, r=mejrs
Add codegen test for remainder match
Closesrust-lang#93514
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 14, 2026
Closed
@amirHdev
amirHdevforce-pushed the add-codegen-test-rem-match-unreachable branch from d376c08 to 468122aCompareJuly 14, 2026 14:21
@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

rust-borsBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit 468122a920ce25c46370ecea6b09fad29ace8543 was pushed.

This pull request was unapproved.

This PR was contained in a rollup (#159281), which was closed.

@amirHdev

amirHdev commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

Sorry about the noise, I accidentally force-pushed while fixing my fork branch after a push rejection.

No further changes are planned from my side`

@mejrs

mejrs commented Jul 14, 2026

Copy link
Copy Markdown
Member

No worries, it happens

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 468122a has been approved by mejrs

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2026
@amirHdev
amirHdevforce-pushed the add-codegen-test-rem-match-unreachable branch from 468122a to d376c08CompareJuly 14, 2026 14:45
@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 14, 2026
@rust-bors

rust-borsBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit d376c08f4280df68ccd7c119f53bc961578c563f was pushed.

This pull request was unapproved.

@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 14, 2026
@rustbot

rustbot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@amirHdev

amirHdev commented Jul 15, 2026

Copy link
Copy Markdown
ContributorAuthor

Sorry again
Could you please run the rollup again ? 👀

@mejrs

mejrs commented Jul 15, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d376c08 has been approved by mejrs

It is now in the queue for this repository.

@rust-borsrust-borsBot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 15, 2026
@rust-borsrust-borsBot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 15, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 15, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of#159336- JonathanBrouwer:rollup-A47hpCX, r=JonathanBro…
21aae1f
…uwer
Rollup of 8 pull requests
Successful merges:
- #159197 (Rename ModDefId to ModId and use more)
- #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- #159296 (Implement `bool::toggle`)
- #158302 (Fix `overflowing_literals` lint with repeated negation)
- #158484 (Add documentation for the `cold` and `track_caller` attributes)
- #159239 (Add codegen test for remainder match)
- #159330 (fix some edition annotations in UI tests)
- #159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs)
Failed merges:
- #158962 (Add `proc_macro` attribute documentation)
rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of#159336- JonathanBrouwer:rollup-A47hpCX, r=JonathanBro…
177ae4f
…uwer
Rollup of 8 pull requests
Successful merges:
- #159197 (Rename ModDefId to ModId and use more)
- #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- #159296 (Implement `bool::toggle`)
- #158302 (Fix `overflowing_literals` lint with repeated negation)
- #158484 (Add documentation for the `cold` and `track_caller` attributes)
- #159239 (Add codegen test for remainder match)
- #159330 (fix some edition annotations in UI tests)
- #159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs)
Failed merges:
- #158962 (Add `proc_macro` attribute documentation)
rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of#159336- JonathanBrouwer:rollup-A47hpCX, r=JonathanBro…
2118366
…uwer
Rollup of 8 pull requests
Successful merges:
- #159197 (Rename ModDefId to ModId and use more)
- #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- #159296 (Implement `bool::toggle`)
- #158302 (Fix `overflowing_literals` lint with repeated negation)
- #158484 (Add documentation for the `cold` and `track_caller` attributes)
- #159239 (Add codegen test for remainder match)
- #159330 (fix some edition annotations in UI tests)
- #159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs)
Failed merges:
- #158962 (Add `proc_macro` attribute documentation)
@rust-bors
rust-borsBot merged commit 298175f into rust-lang:mainJul 15, 2026
26 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 15, 2026
rust-timer added a commit that referenced this pull request Jul 15, 2026
@rust-timer
Unrolled build for#159239
3f7cc2c
Rollup merge of #159239 - amirHdev:add-codegen-test-rem-match-unreachable, r=mejrs
Add codegen test for remainder match
Closes#93514
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #159336 - JonathanBrouwer:rollup-A47hpCX, r=JonathanBro…
76baea8
…uwer
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#159197 (Rename ModDefId to ModId and use more)
- rust-lang/rust#159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- rust-lang/rust#159296 (Implement `bool::toggle`)
- rust-lang/rust#158302 (Fix `overflowing_literals` lint with repeated negation)
- rust-lang/rust#158484 (Add documentation for the `cold` and `track_caller` attributes)
- rust-lang/rust#159239 (Add codegen test for remainder match)
- rust-lang/rust#159330 (fix some edition annotations in UI tests)
- rust-lang/rust#159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs)
Failed merges:
- rust-lang/rust#158962 (Add `proc_macro` attribute documentation)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejrsmejrsmejrs approved these changes

Assignees

@mejrsmejrs

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

Adding an unreachable branch helps optimize the code when matching on x % N

3 participants

@amirHdev@rustbot@mejrs