Skip to content

remove const hack in alloc - #159776

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Syvraa:main
Jul 28, 2026
Merged

remove const hack in alloc#159776
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Syvraa:main

Conversation

@Syvraa

@SyvraaSyvraa commented Jul 23, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Seems like this change was missed when other const hacks were removed.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 23, 2026
@rustbot

rustbot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @LawnGnome (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 7 candidates

@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Syvraa

Syvraa commented Jul 24, 2026

Copy link
Copy Markdown
ContributorAuthor

huh, weird

@rustbot

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@LawnGnome

LawnGnome commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6a7e3d2 has been approved by LawnGnome

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 28, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 28, 2026
@bors
Auto merge of#160102- JonathanBrouwer:rollup-0WT4269, r=JonathanBro…
26ae60a
…uwer
Rollup of 21 pull requests
Successful merges:
- #159990 (Many "predicate"-to-"clause" renamings)
- #159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- #159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- #160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`)
- #160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt #2)
- #160063 (Fix ICE when dumping the dep graph with the parallel frontend)
- #160065 (Distinguish the dep-graph index space from the live node count)
- #158038 (Split register_tool into register_attribute_tool and register_lint_tool)
- #159776 (remove const hack in alloc)
- #159978 (run intrinsic-test by default on x86_64-gnu)
- #160008 (Avoid stale closure recovery state across statements)
- #160027 (Add regression test for #132767)
- #160030 (Update `browser-ui-test` version to `0.25.0`)
- #160046 (Improve consistency of attribute error messages (part 2))
- #160056 (Fix associated function suggestion for generic ADTs)
- #160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- #160071 (sanitize_standard_fds: clarify macos comment)
- #160076 (use unstable features when updating dependencies)
- #160092 (miri ui tests: don't run native tests on stage 0)
- #160093 (Switch cargo assignments to weihanglo)
- #160094 (Update assignment for docs)
@rust-bors
rust-borsBot merged commit 82b7eea into rust-lang:mainJul 28, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 28, 2026
rust-timer added a commit that referenced this pull request Jul 28, 2026
@rust-timer
Unrolled build for#159776
669c74c
Rollup merge of #159776 - Syvraa:main, r=LawnGnome
remove const hack in alloc
Seems like this change was missed when other const hacks were removed.
pullBot pushed a commit to LeeeeeeM/miri that referenced this pull request Jul 29, 2026
@bors
Auto merge of #160102 - JonathanBrouwer:rollup-0WT4269, r=JonathanBro…
9a46d50
…uwer
Rollup of 21 pull requests
Successful merges:
- rust-lang/rust#159990 (Many "predicate"-to-"clause" renamings)
- rust-lang/rust#159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- rust-lang/rust#159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- rust-lang/rust#160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`)
- rust-lang/rust#160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt rust-lang/rust#2)
- rust-lang/rust#160063 (Fix ICE when dumping the dep graph with the parallel frontend)
- rust-lang/rust#160065 (Distinguish the dep-graph index space from the live node count)
- rust-lang/rust#158038 (Split register_tool into register_attribute_tool and register_lint_tool)
- rust-lang/rust#159776 (remove const hack in alloc)
- rust-lang/rust#159978 (run intrinsic-test by default on x86_64-gnu)
- rust-lang/rust#160008 (Avoid stale closure recovery state across statements)
- rust-lang/rust#160027 (Add regression test for rust-lang/rust#132767)
- rust-lang/rust#160030 (Update `browser-ui-test` version to `0.25.0`)
- rust-lang/rust#160046 (Improve consistency of attribute error messages (part 2))
- rust-lang/rust#160056 (Fix associated function suggestion for generic ADTs)
- rust-lang/rust#160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- rust-lang/rust#160071 (sanitize_standard_fds: clarify macos comment)
- rust-lang/rust#160076 (use unstable features when updating dependencies)
- rust-lang/rust#160092 (miri ui tests: don't run native tests on stage 0)
- rust-lang/rust#160093 (Switch cargo assignments to weihanglo)
- rust-lang/rust#160094 (Update assignment for docs)
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 3, 2026
@bors
Auto merge of #160102 - JonathanBrouwer:rollup-0WT4269, r=JonathanBro…
1592b3b
…uwer
Rollup of 21 pull requests
Successful merges:
- rust-lang/rust#159990 (Many "predicate"-to-"clause" renamings)
- rust-lang/rust#159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- rust-lang/rust#159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- rust-lang/rust#160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`)
- rust-lang/rust#160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt rust-lang/rust#2)
- rust-lang/rust#160063 (Fix ICE when dumping the dep graph with the parallel frontend)
- rust-lang/rust#160065 (Distinguish the dep-graph index space from the live node count)
- rust-lang/rust#158038 (Split register_tool into register_attribute_tool and register_lint_tool)
- rust-lang/rust#159776 (remove const hack in alloc)
- rust-lang/rust#159978 (run intrinsic-test by default on x86_64-gnu)
- rust-lang/rust#160008 (Avoid stale closure recovery state across statements)
- rust-lang/rust#160027 (Add regression test for rust-lang/rust#132767)
- rust-lang/rust#160030 (Update `browser-ui-test` version to `0.25.0`)
- rust-lang/rust#160046 (Improve consistency of attribute error messages (part 2))
- rust-lang/rust#160056 (Fix associated function suggestion for generic ADTs)
- rust-lang/rust#160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- rust-lang/rust#160071 (sanitize_standard_fds: clarify macos comment)
- rust-lang/rust#160076 (use unstable features when updating dependencies)
- rust-lang/rust#160092 (miri ui tests: don't run native tests on stage 0)
- rust-lang/rust#160093 (Switch cargo assignments to weihanglo)
- rust-lang/rust#160094 (Update assignment for docs)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #160102 - JonathanBrouwer:rollup-0WT4269, r=JonathanBro…
1e00675
…uwer
Rollup of 21 pull requests
Successful merges:
- rust-lang/rust#159990 (Many "predicate"-to-"clause" renamings)
- rust-lang/rust#159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- rust-lang/rust#159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- rust-lang/rust#160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`)
- rust-lang/rust#160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt rust-lang/rust#2)
- rust-lang/rust#160063 (Fix ICE when dumping the dep graph with the parallel frontend)
- rust-lang/rust#160065 (Distinguish the dep-graph index space from the live node count)
- rust-lang/rust#158038 (Split register_tool into register_attribute_tool and register_lint_tool)
- rust-lang/rust#159776 (remove const hack in alloc)
- rust-lang/rust#159978 (run intrinsic-test by default on x86_64-gnu)
- rust-lang/rust#160008 (Avoid stale closure recovery state across statements)
- rust-lang/rust#160027 (Add regression test for rust-lang/rust#132767)
- rust-lang/rust#160030 (Update `browser-ui-test` version to `0.25.0`)
- rust-lang/rust#160046 (Improve consistency of attribute error messages (part 2))
- rust-lang/rust#160056 (Fix associated function suggestion for generic ADTs)
- rust-lang/rust#160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- rust-lang/rust#160071 (sanitize_standard_fds: clarify macos comment)
- rust-lang/rust#160076 (use unstable features when updating dependencies)
- rust-lang/rust#160092 (miri ui tests: don't run native tests on stage 0)
- rust-lang/rust#160093 (Switch cargo assignments to weihanglo)
- rust-lang/rust#160094 (Update assignment for docs)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LawnGnomeLawnGnome

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Syvraa@rustbot@rust-log-analyzer@LawnGnome