Skip to content

Distinguish the dep-graph index space from the live node count - #160065

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
xmakro:cleanup/dep-graph-index-space-len
Jul 28, 2026
Merged

Distinguish the dep-graph index space from the live node count#160065
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
xmakro:cleanup/dep-graph-index-space-len

Conversation

@xmakro

@xmakroxmakro commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

SerializedDepGraph::node_count() returns nodes.len(), the size of the index space, which includes indices that batch allocation left unused. In the same file, the local node_count in decode is the number of nodes actually encoded. The two differ and are easy to confuse.

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 28, 2026
@xmakro

xmakro commented Jul 28, 2026

Copy link
Copy Markdown
ContributorAuthor

r? @cjgillot

@xmakro
xmakro marked this pull request as ready for review July 28, 2026 13:00
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2026
@cjgillot

cjgillot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-borsBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e945118 has been approved by cjgillot

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 28, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160065- xmakro:cleanup/dep-graph-index-spa…
f54583e
…ce-len, r=cjgillot
Distinguish the dep-graph index space from the live node count
`SerializedDepGraph::node_count()` returns `nodes.len()`, the size of the index space, which includes indices that batch allocation left unused. In the same file, the local `node_count` in `decode` is the number of nodes actually encoded. The two differ and are easy to confuse.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 28, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jul 28, 2026
@bors
Auto merge of#160089- JonathanBrouwer:rollup-YDn7kro, r=JonathanBro…
550ecb7
…uwer
Rollup of 14 pull requests
Successful merges:
- #159990 (Many "predicate"-to-"clause" renamings)
- #159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- #159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- #160065 (Distinguish the dep-graph index space from the live node count)
- #159978 (run intrinsic-test by default on x86_64-gnu)
- #160008 (Avoid stale closure recovery state across statements)
- #160027 (Add regression test for #132767)
- #160030 (Update `browser-ui-test` version to `0.25.0`)
- #160046 (Improve consistency of attribute error messages (part 2))
- #160056 (Fix associated function suggestion for generic ADTs)
- #160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- #160071 (sanitize_standard_fds: clarify macos comment)
- #160076 (use unstable features when updating dependencies)
- #160088 (fix 404 url in src/doc/rustdoc.md)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 28, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160065- xmakro:cleanup/dep-graph-index-spa…
b4bbdee
…ce-len, r=cjgillot
Distinguish the dep-graph index space from the live node count
`SerializedDepGraph::node_count()` returns `nodes.len()`, the size of the index space, which includes indices that batch allocation left unused. In the same file, the local `node_count` in `decode` is the number of nodes actually encoded. The two differ and are easy to confuse.
This was referenced Jul 28, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 28, 2026
@bors
Auto merge of#160102- JonathanBrouwer:rollup-0WT4269, r=JonathanBro…
26ae60a
…uwer
Rollup of 21 pull requests
Successful merges:
- #159990 (Many "predicate"-to-"clause" renamings)
- #159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- #159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- #160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`)
- #160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt #2)
- #160063 (Fix ICE when dumping the dep graph with the parallel frontend)
- #160065 (Distinguish the dep-graph index space from the live node count)
- #158038 (Split register_tool into register_attribute_tool and register_lint_tool)
- #159776 (remove const hack in alloc)
- #159978 (run intrinsic-test by default on x86_64-gnu)
- #160008 (Avoid stale closure recovery state across statements)
- #160027 (Add regression test for #132767)
- #160030 (Update `browser-ui-test` version to `0.25.0`)
- #160046 (Improve consistency of attribute error messages (part 2))
- #160056 (Fix associated function suggestion for generic ADTs)
- #160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- #160071 (sanitize_standard_fds: clarify macos comment)
- #160076 (use unstable features when updating dependencies)
- #160092 (miri ui tests: don't run native tests on stage 0)
- #160093 (Switch cargo assignments to weihanglo)
- #160094 (Update assignment for docs)
@rust-bors
rust-borsBot merged commit aff2e65 into rust-lang:mainJul 28, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 28, 2026
rust-timer added a commit that referenced this pull request Jul 28, 2026
@rust-timer
Unrolled build for#160065
53785fb
Rollup merge of #160065 - xmakro:cleanup/dep-graph-index-space-len, r=cjgillot
Distinguish the dep-graph index space from the live node count
`SerializedDepGraph::node_count()` returns `nodes.len()`, the size of the index space, which includes indices that batch allocation left unused. In the same file, the local `node_count` in `decode` is the number of nodes actually encoded. The two differ and are easy to confuse.
pullBot pushed a commit to LeeeeeeM/miri that referenced this pull request Jul 29, 2026
@bors
Auto merge of #160102 - JonathanBrouwer:rollup-0WT4269, r=JonathanBro…
9a46d50
…uwer
Rollup of 21 pull requests
Successful merges:
- rust-lang/rust#159990 (Many "predicate"-to-"clause" renamings)
- rust-lang/rust#159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- rust-lang/rust#159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- rust-lang/rust#160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`)
- rust-lang/rust#160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt rust-lang/rust#2)
- rust-lang/rust#160063 (Fix ICE when dumping the dep graph with the parallel frontend)
- rust-lang/rust#160065 (Distinguish the dep-graph index space from the live node count)
- rust-lang/rust#158038 (Split register_tool into register_attribute_tool and register_lint_tool)
- rust-lang/rust#159776 (remove const hack in alloc)
- rust-lang/rust#159978 (run intrinsic-test by default on x86_64-gnu)
- rust-lang/rust#160008 (Avoid stale closure recovery state across statements)
- rust-lang/rust#160027 (Add regression test for rust-lang/rust#132767)
- rust-lang/rust#160030 (Update `browser-ui-test` version to `0.25.0`)
- rust-lang/rust#160046 (Improve consistency of attribute error messages (part 2))
- rust-lang/rust#160056 (Fix associated function suggestion for generic ADTs)
- rust-lang/rust#160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- rust-lang/rust#160071 (sanitize_standard_fds: clarify macos comment)
- rust-lang/rust#160076 (use unstable features when updating dependencies)
- rust-lang/rust#160092 (miri ui tests: don't run native tests on stage 0)
- rust-lang/rust#160093 (Switch cargo assignments to weihanglo)
- rust-lang/rust#160094 (Update assignment for docs)
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 3, 2026
@bors
Auto merge of #160102 - JonathanBrouwer:rollup-0WT4269, r=JonathanBro…
1592b3b
…uwer
Rollup of 21 pull requests
Successful merges:
- rust-lang/rust#159990 (Many "predicate"-to-"clause" renamings)
- rust-lang/rust#159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- rust-lang/rust#159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- rust-lang/rust#160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`)
- rust-lang/rust#160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt rust-lang/rust#2)
- rust-lang/rust#160063 (Fix ICE when dumping the dep graph with the parallel frontend)
- rust-lang/rust#160065 (Distinguish the dep-graph index space from the live node count)
- rust-lang/rust#158038 (Split register_tool into register_attribute_tool and register_lint_tool)
- rust-lang/rust#159776 (remove const hack in alloc)
- rust-lang/rust#159978 (run intrinsic-test by default on x86_64-gnu)
- rust-lang/rust#160008 (Avoid stale closure recovery state across statements)
- rust-lang/rust#160027 (Add regression test for rust-lang/rust#132767)
- rust-lang/rust#160030 (Update `browser-ui-test` version to `0.25.0`)
- rust-lang/rust#160046 (Improve consistency of attribute error messages (part 2))
- rust-lang/rust#160056 (Fix associated function suggestion for generic ADTs)
- rust-lang/rust#160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- rust-lang/rust#160071 (sanitize_standard_fds: clarify macos comment)
- rust-lang/rust#160076 (use unstable features when updating dependencies)
- rust-lang/rust#160092 (miri ui tests: don't run native tests on stage 0)
- rust-lang/rust#160093 (Switch cargo assignments to weihanglo)
- rust-lang/rust#160094 (Update assignment for docs)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #160102 - JonathanBrouwer:rollup-0WT4269, r=JonathanBro…
1e00675
…uwer
Rollup of 21 pull requests
Successful merges:
- rust-lang/rust#159990 (Many "predicate"-to-"clause" renamings)
- rust-lang/rust#159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
- rust-lang/rust#159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
- rust-lang/rust#160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`)
- rust-lang/rust#160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt rust-lang/rust#2)
- rust-lang/rust#160063 (Fix ICE when dumping the dep graph with the parallel frontend)
- rust-lang/rust#160065 (Distinguish the dep-graph index space from the live node count)
- rust-lang/rust#158038 (Split register_tool into register_attribute_tool and register_lint_tool)
- rust-lang/rust#159776 (remove const hack in alloc)
- rust-lang/rust#159978 (run intrinsic-test by default on x86_64-gnu)
- rust-lang/rust#160008 (Avoid stale closure recovery state across statements)
- rust-lang/rust#160027 (Add regression test for rust-lang/rust#132767)
- rust-lang/rust#160030 (Update `browser-ui-test` version to `0.25.0`)
- rust-lang/rust#160046 (Improve consistency of attribute error messages (part 2))
- rust-lang/rust#160056 (Fix associated function suggestion for generic ADTs)
- rust-lang/rust#160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
- rust-lang/rust#160071 (sanitize_standard_fds: clarify macos comment)
- rust-lang/rust#160076 (use unstable features when updating dependencies)
- rust-lang/rust#160092 (miri ui tests: don't run native tests on stage 0)
- rust-lang/rust#160093 (Switch cargo assignments to weihanglo)
- rust-lang/rust#160094 (Update assignment for docs)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cjgillotcjgillot

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

3 participants

@xmakro@cjgillot@rustbot