Rollup of 21 pull requests by JonathanBrouwer · Pull Request #160102 · rust-lang/rust

JonathanBrouwer · 2026-07-28T19:08:11Z

Successful merges:

Many "predicate"-to-"clause" renamings #159990 (Many "predicate"-to-"clause" renamings)
Replace most Ty::new_fn_def calls with type_of queries directly #159665 (Replace most Ty::new_fn_def calls with type_of queries directly)
rustdoc: Set tracing max_level_info when debug-logging is false #159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
refactor(mir-transform): Calculate optimization status inside run_passes_inner #160057 (refactor(mir-transform): Calculate optimization status inside run_passes_inner)
codegen: skip stores for entirely-uninit constant aggregate fields, attempt #2 #160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt bind's glue function should tail-call its target #2)
Fix ICE when dumping the dep graph with the parallel frontend #160063 (Fix ICE when dumping the dep graph with the parallel frontend)
Distinguish the dep-graph index space from the live node count #160065 (Distinguish the dep-graph index space from the live node count)
Split register_tool into register_attribute_tool and register_lint_tool #158038 (Split register_tool into register_attribute_tool and register_lint_tool)
remove const hack in alloc #159776 (remove const hack in alloc)
run intrinsic-test by default on x86_64-gnu #159978 (run intrinsic-test by default on x86_64-gnu)
Avoid stale closure recovery state across statements #160008 (Avoid stale closure recovery state across statements)
Add regression test for #132767 #160027 (Add regression test for [ICE]: maybe try to call try_normalize_erasing_regions instead #132767)
Update browser-ui-test version to 0.25.0 #160030 (Update browser-ui-test version to 0.25.0)
Improve consistency of attribute error messages (part 2) #160046 (Improve consistency of attribute error messages (part 2))
Fix associated function suggestion for generic ADTs #160056 (Fix associated function suggestion for generic ADTs)
Update Rust crate tracing-subscriber to v0.3.23 [SECURITY] #160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
sanitize_standard_fds: clarify macos comment #160071 (sanitize_standard_fds: clarify macos comment)
use unstable features when updating dependencies #160076 (use unstable features when updating dependencies)
miri ui tests: don't run native tests on stage 0 #160092 (miri ui tests: don't run native tests on stage 0)
Switch cargo assignments to weihanglo #160093 (Switch cargo assignments to weihanglo)
Update assignment for docs #160094 (Update assignment for docs)

This matches rustc and should improve performance for the published versions of rustdoc. We shouldn't be including all our debug! calls in builds for users.

The existing API is preserved as `parse_limited_sym` as a simple helper. Similarly, `parse_limited_should_emit` is preserved as `parse_limited_sym_should_emit`. I've noted that all users targets crate, so the `target_node_id` and `target` parameters are removed from it.

It is also removed.

This splits the functionality to two parts per RFC. The `#![register_tool]` attribute registers the tool in both ways. Semantics remain unchanged and will be adjusted in later commit.

Under the RFC, it's not an error to register tool multiple times, but it is an error to register "rustc" tool.

Coercing the fn item `bar` to a fn pointer while `Foo::value` holds the associated-type projection `<<T as Func>::Ret as Id>::Assoc` used to ICE during normalization ("maybe try to call `try_normalize_erasing_regions` instead"). It now reports the ordinary `u32: Id` trait-bound error instead of crashing.

Lots of names weren't changed to account for the introduction of the `Clause` type as a specialized form of `Predicate`, presumably because it was tedious. This commit converts as many of them as I could find. It's mostly very tedious renamings of types, functions, variables, and queries. The more interesting ones are a couple of files (`predicates_of.rs`, `impossible_predicates.rs`) and a MIR pass (`ImpossiblePredicates`).

The carets should ideally point to the path, not the entire attribute, but that's hard to achieve with the current code structure.

The carets already point to just the attribute path, which is what we want.

…sses_inner`

…ator" This reverts commit 9e9467a.

…-uninit constants" This reverts commit ed9de1e.

MIR GVN propagates MaybeUninit::uninit() as `const <uninit>` in aggregate constructions and codegen emits a memcpy from an `[N x i8] undef` global for each such field, which LLVM materializes as zero-initialization. We extract the existing `all_bytes_uninit` skip already present for `Rvalue::Use` and `Rvalue::Repeat` to a separate helper function, and use it in the `Rvalue::Aggregate` field loop.

Rollup of 21 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*

rust-bors · 2026-07-28T22:17:08Z

☀️ Try build successful (CI)
Build commit: cafc370 (cafc370b1235ab2bbb9b49d672b48878ae5e8cc6)
Base parent: e19d321 (e19d321c06479c6fd77533582b0d5a86651f1be3)

rust-bors · 2026-07-28T22:40:00Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 25m 51s
Pushing 26ae60a to main...

github-actions · 2026-07-28T22:43:11Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e19d321 (parent) -> 26ae60a (this PR)

Test differences

Show 241 test diffs

Stage 1

[ui (polonius)] tests/ui/associated-types/fn-ptr-coercion-normalize-ice-132767.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/expr/malformed_closure/missing-braces-before-close-brace.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/methods/associated-fn-turbofish-issue-159813.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/tool-attributes/cfg-register.rs#split_attr_lint: [missing] -> pass (J1)
[ui (polonius)] tests/ui/tool-attributes/cfg-register.rs#tool: [missing] -> pass (J1)
[ui (polonius)] tests/ui/tool-attributes/duplicate-tool.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/tool-attributes/predefined-tool.rs: [missing] -> pass (J1)
[mir-opt] tests/mir-opt/impossible_clauses.rs: [missing] -> pass (J2)
[mir-opt] tests/mir-opt/impossible_predicates.rs: pass -> [missing] (J2)
[codegen] tests/codegen-llvm/uninit-return-value.rs: pass -> [missing] (J3)
[ui] tests/ui/associated-types/fn-ptr-coercion-normalize-ice-132767.rs: [missing] -> pass (J4)
[ui] tests/ui/expr/malformed_closure/missing-braces-before-close-brace.rs: [missing] -> pass (J4)
[ui] tests/ui/methods/associated-fn-turbofish-issue-159813.rs: [missing] -> pass (J4)
[ui] tests/ui/tool-attributes/cfg-register.rs#split_attr_lint: [missing] -> pass (J4)
[ui] tests/ui/tool-attributes/cfg-register.rs#tool: [missing] -> pass (J4)
[ui] tests/ui/tool-attributes/duplicate-tool.rs: [missing] -> pass (J4)
[ui] tests/ui/tool-attributes/predefined-tool.rs: [missing] -> pass (J4)

Stage 2

[ui] tests/ui/associated-types/fn-ptr-coercion-normalize-ice-132767.rs: [missing] -> pass (J0)
[ui] tests/ui/expr/malformed_closure/missing-braces-before-close-brace.rs: [missing] -> pass (J0)
[ui] tests/ui/methods/associated-fn-turbofish-issue-159813.rs: [missing] -> pass (J0)
[ui] tests/ui/tool-attributes/cfg-register.rs#split_attr_lint: [missing] -> pass (J0)
[ui] tests/ui/tool-attributes/cfg-register.rs#tool: [missing] -> pass (J0)
[ui] tests/ui/tool-attributes/duplicate-tool.rs: [missing] -> pass (J0)
[ui] tests/ui/tool-attributes/predefined-tool.rs: [missing] -> pass (J0)
[mir-opt] tests/mir-opt/impossible_clauses.rs: [missing] -> pass (J5)
[mir-opt] tests/mir-opt/impossible_predicates.rs: pass -> [missing] (J5)
[codegen] tests/codegen-llvm/uninit-return-value.rs: pass -> [missing] (J6)

Additionally, 214 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 26ae60a9eeb20b4935be49d7a931a650fa1d2923 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-miri: 1h 2m -> 1h 39m (+58.7%)
i686-msvc-2: 1h 29m -> 2h 4m (+38.7%)
x86_64-gnu-tools: 49m 20s -> 1h 4m (+30.3%)
dist-powerpc64le-linux-musl: 1h 39m -> 1h 12m (-27.3%)
i686-msvc-1: 3h 1m -> 2h 13m (-26.1%)
x86_64-msvc-1: 2h 41m -> 1h 59m (-25.7%)
x86_64-gnu-llvm-22-3: 1h 25m -> 1h 46m (+25.0%)
x86_64-gnu-llvm-22-2: 1h 33m -> 1h 11m (-24.1%)
dist-i686-mingw: 2h 10m -> 2h 42m (+24.0%)
dist-ohos-x86_64: 1h 3m -> 1h 18m (+22.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-07-28T22:46:19Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#159990	Many "predicate"-to-"clause" renamings	`6f4d57ac94d497486a56f6fca27c0e1c4abf0935` (link)
#159665	Replace most `Ty::new_fn_def` calls with `type_of` queries …	`680e6a2d598853fafcd6a0d20de8b9fada9a1bcc` (link)
#159687	rustdoc: Set tracing max_level_info when debug-logging is f…	`905a67f7644ac33eea17284eab51d922559c4ccb` (link)
#160057	refactor(mir-transform): Calculate optimization status insi…	`f98c4105e1ad447bf6d267961b8cd0f048793790` (link)
#160060	codegen: skip stores for entirely-uninit constant aggregate…	`d0c03a4d6dcd8638ca7ac5de97bf18c573ed3bad` (link)
#160063	Fix ICE when dumping the dep graph with the parallel fronte…	`b729ec0233775f78e36f11942d11a89203c866fa` (link)
#160065	Distinguish the dep-graph index space from the live node co…	`53785fb8f314738fcb909a921be80df5b4ea1b15` (link)
#158038	Split register_tool into register_attribute_tool and regist…	`0a10f5f4f5349daa68675e1717d6103a7a489bf3` (link)
#159776	remove const hack in alloc	`669c74c96c18a6a46120e9eb84f9322f573939b0` (link)
#159978	run intrinsic-test by default on x86_64-gnu	`48a6b878b5218a707f7ff7861fe97a34101510a6` (link)
#160008	Avoid stale closure recovery state across statements	`cc12b343aab74f23b4cb0dbdb63a50d3570b1c69` (link)
#160027	Add regression test for #132767	`0a8b91a44d6f042b627c23a0950511567fc1610f` (link)
#160030	Update `browser-ui-test` version to `0.25.0`	`af1386e51b9d55a453dcc52707f4d58d4d86490e` (link)
#160046	Improve consistency of attribute error messages (part 2)	`c35ebdcf3b59d148c02fedc0bf7f5b9f4c1500bb` (link)
#160056	Fix associated function suggestion for generic ADTs	`bfb039a80e1fc3999aa1233ed9bf1ae6f4a634c6` (link)
#160069	Update Rust crate tracing-subscriber to v0.3.23 [SECURITY]	`f0e636b9e36ac7ab397b8dbd3764028612cc3719` (link)
#160071	sanitize_standard_fds: clarify macos comment	`1e437f5bb499bd30f8ea1edfcb9b9a34ae191d55` (link)
#160076	use unstable features when updating dependencies	`6d79a8a5821a3e73f55ea0dda7c573cf3b44c3eb` (link)
#160092	miri ui tests: don't run native tests on stage 0	`ed8dc546ac9a8c38babe1ad7b0e608bc9766ebfe` (link)
#160093	Switch cargo assignments to weihanglo	`d48a924f64dac31869613a70469a67295c695f2d` (link)
#160094	Update assignment for docs	`fbd6afe860d2b4a6caca710fa6590c043e93dd3b` (link)

previous master: e19d321c06

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-07-28T23:49:51Z

Finished benchmarking commit (26ae60a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	3
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results (primary 2.4%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.3%, 2.4%]	2
Regressions ❌ (secondary)	5.1%	[5.1%, 5.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-2.1%, -0.7%]	3
All ❌✅ (primary)	2.4%	[2.3%, 2.4%]	2

Cycles

Results (primary 6.0%, secondary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	8.4%	[5.8%, 10.4%]	3
Regressions ❌ (secondary)	20.7%	[3.1%, 54.8%]	3
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-4.2%	[-6.5%, -2.0%]	6
All ❌✅ (primary)	6.0%	[-1.3%, 10.4%]	4

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.165s -> 489.651s (-0.10%)
Artifact size: 388.34 MiB -> 390.13 MiB (0.46%)

camelidand others added 30 commits July 21, 2026 20:31

rustdoc: Set tracing max_level_info when debug-logging is false
b7df3de
This matches rustc and should improve performance for the published versions of rustdoc. We shouldn't be including all our debug! calls in builds for users.

remove const hack in alloc
6a7e3d2

run intrinsic-test by default on x86_64-gnu
85adfcf

add regression test for stale closure recovery state
7f8e276

reset closure recovery state before parsing a statement
da2697d

Stop mentioning register_attr feature from custom_attribute
c8238fa
It is also removed.

Make RegisterToolParser implement AttributeParser directly
178bddc

Split register_tool into register_attribute_tool and register_lint_tool
75999c4
This splits the functionality to two parts per RFC. The `#![register_tool]` attribute registers the tool in both ways. Semantics remain unchanged and will be adjusted in later commit.

Remove duplicate tool error and add reserved error
43444bf
Under the RFC, it's not an error to register tool multiple times, but it is an error to register "rustc" tool.

Add test for register_{attribute,lint}_tool with cfg
a22359b

Expand register_tool feature gate test to cover attr and lint tool
d0f008d

Add register_{attribute,lint}_tool test with crate-attr
b0da120

Update browser-ui-test version to 0.25.0
4ab575d

Improve consistency of proc macro attribute error messages
51a9794

Improve consistency of rustc_abi attribute error messages
c9be59d

Improve consistency of rustc_const_stable attribute error messages
02df958

Improve consistency of diagnostic::on_const attribute error messages
909079f

Improve consistency of test/bench attribute error messages
6c97237
The carets should ideally point to the path, not the entire attribute, but that's hard to achieve with the current code structure.

Improve consistency of unsafe attribute error messages
8704b63
The carets already point to just the attribute path, which is what we want.

Add regression test for generic associated function suggestions
8bfa429

Use value syntax for associated function suggestions
c9dbe2b

Add missing "clipboard-read" permission
1d32220

refactor(mir-transform): Calculate optimization status inside `run_pa…
a6b2d2b
…sses_inner`

Revert "codegen: handle OperandValue::Uninit in codegen_return_termin…
506de47
…ator" This reverts commit 9e9467a.

Revert "codegen: add OperandValue::Uninit to skip stores for entirely…
7158341
…-uninit constants" This reverts commit ed9de1e.

add build.sde to bootstrap.example.toml
23e9a09

rust-borsBot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2026

This comment has been minimized.
Sign in to view

rust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 28, 2026

rust-borsBot merged commit 26ae60a into rust-lang:mainJul 28, 2026
15 checks passed

rustbot added this to the 1.99.0 milestone Jul 28, 2026

rustbot added the perf-regression Performance regression. label Jul 28, 2026

panstromek mentioned this pull request Aug 3, 2026
refactor(mir-transform): Calculate optimization status inside run_passes_inner#160057
Merged

JonathanBrouwer deleted the rollup-0WT4269 branch August 21, 2026 07:56

Navigation Menu

Uh oh!

Uh oh!

Rollup of 21 pull requests - #160102

Rollup of 21 pull requests#160102
rust-bors[bot] merged 60 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-0WT4269

JonathanBrouwer commented Jul 28, 2026•
edited by rustbot
Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Jul 28, 2026

Uh oh!

rust-borsBot commented Jul 28, 2026

Uh oh!

Uh oh!

github-actionsBot commented Jul 28, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jul 28, 2026

Uh oh!

rust-timer commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jul 28, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Jul 28, 2026

Uh oh!

rust-borsBot commented Jul 28, 2026

Uh oh!

Uh oh!

github-actionsBot commented Jul 28, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jul 28, 2026

Uh oh!

rust-timer commented Jul 28, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

JonathanBrouwer commented Jul 28, 2026•
edited by rustbot
Loading