Uh oh!
There was an error while loading. Please reload this page.
resolve: Avoid emitting redundant path resolution errors - #32789
Merged
Conversation
Contributor
There was a problem hiding this comment.
Is the const evaluation error triggering for DefError? Could we suppress that, too?
ContributorAuthor
There was a problem hiding this comment.
I believe so -- I'll look into it.
eddyb
commented
Apr 7, 2016
Contributor
r=me with tidy errors fixed. |
jseyfried
commented
Apr 7, 2016
ContributorAuthor
bors
commented
Apr 7, 2016
Collaborator
📌 Commit d3affc6 has been approved by |
jseyfriedforce-pushed
the
fix_duplicate_resolve_errors
branch
from
April 7, 2016 05:50
d3affc6 to
07dac97Comparejseyfried
commented
Apr 7, 2016
ContributorAuthor
@bors r=eddyb |
bors
commented
Apr 7, 2016
Collaborator
📌 Commit 07dac97 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Apr 7, 2016
…ors, r=eddyb resolve: Avoid emitting redundant path resolution errors This PR avoids emitting redundant path resolution errors in `resolve` (fixesrust-lang#32760). r? @eddyb
bors added a commit
that referenced
this pull request
Apr 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids emitting redundant path resolution errors in
resolve(fixes#32760).r? @eddyb