Uh oh!
There was an error while loading. Please reload this page.
Reinstate fast_reject for overlap checking - #32748
Merged
Merged
Conversation
The initial implementation of specialization did not use the `fast_reject` mechanism when checking for overlap, which caused a serious performance regression in some cases. This commit modifies the specialization graph to use simplified types for fast rejection when possible, and along the way refactors the logic for building the specialization graph. Closesrust-lang#32499
aturon
commented
Apr 5, 2016
ContributorAuthor
Note: I've confirmed locally that this resolves the coherence slowdown for winapi. |
nikomatsakis
commented
Apr 5, 2016
Contributor
It'd be nice to have a regression test added to https://github.com/nrc/rustc-perf |
nikomatsakis
commented
Apr 5, 2016
Contributor
@bors r+ |
bors
commented
Apr 5, 2016
Collaborator
📌 Commit 9ba3d5e has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Apr 6, 2016
Reinstate fast_reject for overlap checking The initial implementation of specialization did not use the `fast_reject` mechanism when checking for overlap, which caused a serious performance regression in some cases. This commit modifies the specialization graph to use simplified types for fast rejection when possible, and along the way refactors the logic for building the specialization graph. Closesrust-lang#32499 r? @nikomatsakis
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Apr 7, 2016
Reinstate fast_reject for overlap checking The initial implementation of specialization did not use the `fast_reject` mechanism when checking for overlap, which caused a serious performance regression in some cases. This commit modifies the specialization graph to use simplified types for fast rejection when possible, and along the way refactors the logic for building the specialization graph. Closesrust-lang#32499 r? @nikomatsakis
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Apr 7, 2016
Reinstate fast_reject for overlap checking The initial implementation of specialization did not use the `fast_reject` mechanism when checking for overlap, which caused a serious performance regression in some cases. This commit modifies the specialization graph to use simplified types for fast rejection when possible, and along the way refactors the logic for building the specialization graph. Closesrust-lang#32499 r? @nikomatsakis
bors added a commit
that referenced
this pull request
Apr 7, 2016
nikomatsakis
commented
Apr 21, 2016
Contributor
Nominating for regression because:
|
nikomatsakis
commented
Apr 21, 2016
Contributor
Accepting for beta based on prior criteria. |
alexcrichton
commented
May 4, 2016
Member
I'm not sure if this backport was intended for 1.8, but it's missed that train unfortunately. Beta was branched off of b622c3e, however, which includes this commit, so I'm going to remove the beta-nominated tag as our way of indicating "backport done" is "beta-accepted" only, and the "backport" is done as this just made its way naturally into 1.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial implementation of specialization did not use the
fast_rejectmechanism when checking for overlap, which caused aserious performance regression in some cases.
This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.
Closes#32499
r? @nikomatsakis