Skip to content

Fix typos in atomic compare_exchange. - #32757

Merged
bors merged 1 commit into
rust-lang:masterfrom
taralx:patch-1
Apr 7, 2016
Merged

Fix typos in atomic compare_exchange.#32757
bors merged 1 commit into
rust-lang:masterfrom
taralx:patch-1

Conversation

@taralx

@taralxtaralx commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

Failure ordering can't be Release, not (not) Acquire. Seems like a typo copy-pasted all over.

@rust-highfive

rust-highfive commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson

brson commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 6, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 4883824 has been approved by brson

@ManishearthManishearth mentioned this pull request Apr 6, 2016
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 6, 2016
@Manishearth
Rollup merge ofrust-lang#32757- taralx:patch-1, r=brson
ee55501
Fix typos in atomic compare_exchange.
Failure ordering can't be Release, not (not) Acquire. Seems like a typo copy-pasted all over.
@taralx

taralx commented Apr 7, 2016

Copy link
Copy Markdown
ContributorAuthor

FYI consider cherrypicking this to stable -- it was really confusing in the docs.

@ManishearthManishearth mentioned this pull request Apr 7, 2016
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2016
@Manishearth
Rollup merge ofrust-lang#32757- taralx:patch-1, r=brson
ae50375
Fix typos in atomic compare_exchange.
Failure ordering can't be Release, not (not) Acquire. Seems like a typo copy-pasted all over.
bors added a commit that referenced this pull request Apr 7, 2016
@bors
Auto merge of#32787- Manishearth:rollup, r=Manishearth
6a55f4f
Rollup of 11 pull requests
- Successful merges: #32016, #32583, #32699, #32729, #32731, #32738, #32741, #32745, #32748, #32757, #32786
- Failed merges: #32773
@ManishearthManishearth mentioned this pull request Apr 7, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2016
@Manishearth
Rollup merge ofrust-lang#32757- taralx:patch-1, r=brson
2a88ca4
Fix typos in atomic compare_exchange.
Failure ordering can't be Release, not (not) Acquire. Seems like a typo copy-pasted all over.
bors added a commit that referenced this pull request Apr 7, 2016
@bors
Auto merge of#32794- Manishearth:rollup, r=Manishearth
470ca1c
Rollup of 7 pull requests
- Successful merges: #32674, #32699, #32711, #32745, #32748, #32757, #32789
- Failed merges:
@bors
bors merged commit 4883824 into rust-lang:masterApr 7, 2016
@taralx
taralx deleted the patch-1 branch April 12, 2016 18:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brsonbrson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@taralx@rust-highfive@brson@bors