Add error description for E0455 by cristianoliveira · Pull Request #33393 · rust-lang/rust

cristianoliveira · 2016-05-04T04:02:56Z

About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.

rust-highfive · 2016-05-04T04:03:11Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

birkenfeld · 2016-05-04T07:16:49Z

Does the running OS really have to be OSX, or just the target we're compiling for?

You have to compile it on OSX and use it on OSX as well.

Oh and the sentence sounds strange here as well. Did you mean "A framework link kind..."?

cristianoliveira · 2016-05-04T16:10:35Z

#32777

GuillaumeGomez · 2016-05-04T16:47:49Z

"When using 'framework' link kind, please ensure to use OSX to compile the code."

GuillaumeGomez · 2016-05-04T16:48:22Z

Two last nits, sqaush commits and we're good to merge!

cristianoliveira · 2016-05-04T18:02:10Z

Done.

GuillaumeGomez · 2016-05-04T20:32:40Z

Thanks for your work!

r=me @steveklabnik @Manishearth

cristianoliveira · 2016-05-04T23:43:04Z

:)

Manishearth · 2016-05-05T10:47:56Z

"isn't OS X"
Mention that link kinds are only allowed on OS X.

cristianoliveira · 2016-05-06T02:18:47Z

Done.

GuillaumeGomez · 2016-05-10T19:53:33Z

Thanks!

r=me

steveklabnik · 2016-05-10T20:35:26Z

I would add a newline above this, to make it its own paragraph

steveklabnik · 2016-05-10T20:45:39Z

Thanks @cristianoliveira ! I do have some grammar nits before we can merge this in.

cristianoliveira · 2016-05-10T23:08:08Z

Great! I will change it. :)

- Adding name attribute to the sample code - Fix description sentences

cristianoliveira · 2016-05-10T23:33:06Z

Done.

Also, thank you guys for being patient with the grammar issues. ^^
You are great!

GuillaumeGomez · 2016-05-11T20:52:41Z

Thanks to you for your contribution. :)

Seems all good for me @steveklabnik.

steveklabnik · 2016-05-12T18:23:18Z

@cristianoliveira thanks for being patient yourself! It can be tough to go through like 5 rounds of grammar review 😄

@bors: r+ rollup

bors · 2016-05-12T18:23:19Z

📌 Commit 85e0242 has been approved by steveklabnik

@GuillaumeGomez

…tion, r=steveklabnik Add error description for E0455 r? @GuillaumeGomez. About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.

Rollup of 23 pull requests - Successful merges: #33282, #33342, #33393, #33450, #33513, #33517, #33531, #33532, #33533, #33534, #33538, #33541, #33544, #33552, #33555, #33560, #33563, #33565, #33566, #33572, #33580, #33590, #33596 - Failed merges: #33578

cristianoliveira · 2016-05-13T01:36:13Z

:D

@GuillaumeGomez

…tion, r=steveklabnik Add error description for E0455 r? @GuillaumeGomez. About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.

@GuillaumeGomez

…tion, r=steveklabnik Add error description for E0455 r? @GuillaumeGomez. About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.

Rollup of 15 pull requests - Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33590, #33591, #33598, #33603, #33604, #33605 - Failed merges: #33578

@GuillaumeGomez

…tion, r=steveklabnik Add error description for E0455 r? @GuillaumeGomez. About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.

Rollup of 14 pull requests - Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33590, #33591, #33598 - Failed merges: #33578

Rollup of 27 pull requests - Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33588, #33590, #33591, #33593, #33598, #33600, #33602, #33603, #33604, #33605, #33607, #33612, #33620, #33633, #33634, #33635 - Failed merges: #33578

rust-highfive assigned GuillaumeGomez May 4, 2016

birkenfeld reviewed May 4, 2016
View reviewed changes

GuillaumeGomez reviewed May 4, 2016
View reviewed changes

Manishearth reviewed May 5, 2016
View reviewed changes

Comment threadsrc/librustc_metadata/diagnostics.rs Outdated
ManishearthMay 5, 2016
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"isn't OS X"
Mention that link kinds are only allowed on OS X.

steveklabnik reviewed May 10, 2016
View reviewed changes

Add error description for E0455
85e0242
- Adding name attribute to the sample code - Fix description sentences

eddyb mentioned this pull request May 12, 2016
Rollup of 23 pull requests #33597
Closed

eddyb mentioned this pull request May 13, 2016
Rollup of 29 pull requests #33610
Closed

sanxiyn mentioned this pull request May 14, 2016
Rollup of 15 pull requests #33629
Closed

eddyb mentioned this pull request May 14, 2016
Rollup of 27 pull requests #33643
Merged

Manishearth mentioned this pull request May 15, 2016
Rollup of 14 pull requests #33658
Merged

bors merged commit 85e0242 into rust-lang:masterMay 15, 2016

cristianoliveira deleted the docs-error-explanation branch May 27, 2016 00:42

Uh oh!

Uh oh!

Conversation

cristianoliveira commented May 4, 2016

Uh oh!

rust-highfive commented May 4, 2016

Uh oh!

birkenfeldMay 4, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMay 4, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMay 4, 2016

Choose a reason for hiding this comment

Uh oh!

cristianoliveira commented May 4, 2016

Uh oh!

GuillaumeGomezMay 4, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented May 4, 2016

Uh oh!

cristianoliveira commented May 4, 2016

Uh oh!

GuillaumeGomez commented May 4, 2016

Uh oh!

cristianoliveira commented May 4, 2016

Uh oh!

ManishearthMay 5, 2016

Choose a reason for hiding this comment

Uh oh!

cristianoliveira commented May 6, 2016

Uh oh!

GuillaumeGomez commented May 10, 2016

Uh oh!

steveklabnikMay 10, 2016

Choose a reason for hiding this comment

Uh oh!

steveklabnik commented May 10, 2016

Uh oh!

cristianoliveira commented May 10, 2016

Uh oh!

cristianoliveira commented May 10, 2016

Uh oh!

GuillaumeGomez commented May 11, 2016

Uh oh!

steveklabnik commented May 12, 2016

Uh oh!

bors commented May 12, 2016

Uh oh!

cristianoliveira commented May 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

GuillaumeGomezMay 4, 2016•
edited
Loading