Skip to content

Add more details and examples in error codes - #33584

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:error_code_improvements
May 15, 2016
Merged

Add more details and examples in error codes#33584
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:error_code_improvements

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented May 12, 2016

Copy link
Copy Markdown
Member

@GuillaumeGomezGuillaumeGomez changed the title Add more details and examplesAdd more details and examples in error codesMay 12, 2016
@GuillaumeGomez
GuillaumeGomezforce-pushed the error_code_improvements branch from 5a37a2e to e4e4868CompareMay 12, 2016 12:42
@GuillaumeGomez
GuillaumeGomezforce-pushed the error_code_improvements branch from e4e4868 to 5f2099dCompareMay 12, 2016 14:45
@steveklabnik

steveklabnik commented May 14, 2016

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented May 14, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 5f2099d has been approved by steveklabnik

@eddybeddyb mentioned this pull request May 14, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 15, 2016
@Manishearth
Rollup merge ofrust-lang#33584- GuillaumeGomez:error_code_improveme…
65814df
…nts, r=steveklabnik
Add more details and examples in error codes
r? @steveklabnik
@ManishearthManishearth mentioned this pull request May 15, 2016
Merged
bors added a commit that referenced this pull request May 15, 2016
@bors
Auto merge of#33658- Manishearth:rollup, r=Manishearth
9f58fb7
Rollup of 14 pull requests
- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33590, #33591, #33598
- Failed merges: #33578
@bors
bors merged commit 5f2099d into rust-lang:masterMay 15, 2016
@GuillaumeGomez
GuillaumeGomez deleted the error_code_improvements branch May 15, 2016 22:29
bors added a commit that referenced this pull request May 16, 2016
@bors
Auto merge of#33643- eddyb:rollup, r=eddyb
bb39c49
Rollup of 27 pull requests
- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33588, #33590, #33591, #33593, #33598, #33600, #33602, #33603, #33604, #33605, #33607, #33612, #33620, #33633, #33634, #33635
- Failed merges: #33578
Ms2ger
Ms2ger reviewed May 16, 2016
View reviewed changes
Comment threadsrc/librustc_typeck/diagnostics.rs
enum Fruit {
Apple(String, String),
Pear(u32),
Fruit::Apple(String, String),

@Ms2gerMs2gerMay 16, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@steveklabnik@bors@Ms2ger