Fix compile_fail tag by GuillaumeGomez · Pull Request #33793 · rust-lang/rust

GuillaumeGomez · 2016-05-22T17:02:03Z

sophiajt · 2016-05-23T15:39:42Z

I'm not clear on why we're ignoring these

It shouldn't. Thanks for noticing!

steveklabnik · 2016-05-23T15:42:23Z

So, this patch seems sensible, but because of the lack of description, it took me a while to figure out exactly what it was doing, and what the problem is. Could you maybe amend the commit message to describe exactly what's going on here, and squash? Thanks

sophiajt · 2016-05-23T15:43:45Z

I think this reads better having the panic + closure in a variable and then later matching the variable rather than doing both at once.

I guess it's a question of point of view? For me it's better this way but if someone else agrees with you, then I'll do it again in two steps.

cc @steveklabnik

I am not sure, personally. I can see it both ways.

Well... Thanks? 😆

GuillaumeGomez · 2016-05-23T22:38:18Z

@steveklabnik: I splitted the two commits to make the review easier. I guess it wasn't a good idea. So just in case, the first commit was to fix cases where the compilation went fine when it was expecting that it'd fail. Second case just update the cases where it now fails because of this change.

GuillaumeGomez · 2016-05-24T09:45:16Z

Ok, so now commits have been squashed and commit message has been rewritten. It just remains the little syntax issue @jonathandturner reported (but I need another confirmation before removing it).

steveklabnik · 2016-05-24T15:29:32Z

@bors: r+ rollup

bors · 2016-05-24T15:29:33Z

📌 Commit 44e9ae0 has been approved by steveklabnik

steveklabnik · 2016-05-24T15:31:31Z

@bors: rollup-

bors · 2016-05-25T03:22:13Z

☔ The latest upstream changes (presumably #33833) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2016-05-25T07:52:04Z

@bors: r=steveklabnik

bors · 2016-05-25T07:52:06Z

📌 Commit 7a5bf59 has been approved by steveklabnik

bors · 2016-05-26T21:25:38Z

⌛ Testing commit 7a5bf59 with merge 4572819...

…expected to and was still considered 'ok') * Fix error explanations tests/tags

bors · 2016-05-26T23:19:04Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

GuillaumeGomez · 2016-05-27T07:51:29Z

Updated.

steveklabnik · 2016-05-27T18:12:31Z

@bors: r+ rollup

bors · 2016-05-27T18:12:32Z

📌 Commit abe9961 has been approved by steveklabnik

bors · 2016-05-29T06:43:09Z

⌛ Testing commit abe9961 with merge cac25b7...

bors · 2016-05-29T06:45:17Z

💔 Test failed - auto-linux-64-opt-rustbuild

GuillaumeGomez · 2016-05-29T14:25:12Z

@bors: r+ rollup

bors · 2016-05-29T14:26:33Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: save-temps was moved under the -C switch #33902

bors · 2016-05-29T14:26:33Z

📌 Commit abe9961 has been approved by GuillaumeGomez

GuillaumeGomez · 2016-05-29T14:27:48Z

@bors: retry

@steveklabnik

…laumeGomez Fix compile_fail tag Fixesrust-lang#33780 r? @steveklabnik

Rollup of 10 pull requests - Successful merges: #33793, #33893, #33902, #33912, #33913, #33914, #33917, #33931, #33937, #33938 - Failed merges:

@steveklabnik

…laumeGomez Fix compile_fail tag Fixesrust-lang#33780 r? @steveklabnik

bors · 2016-05-30T07:15:35Z

⌛ Testing commit abe9961 with merge e73aba1...

bors · 2016-05-30T07:18:41Z

💔 Test failed - auto-linux-64-cross-netbsd

GuillaumeGomez · 2016-05-30T09:46:16Z

@bors: retry

bors · 2016-05-30T09:47:40Z

⌛ Testing commit abe9961 with merge 623cb7a...

@steveklabnik

…laumeGomez Fix compile_fail tag Fixesrust-lang#33780 r? @steveklabnik

bors · 2016-05-30T09:53:59Z

⛄ The build was interrupted to prioritize another pull request.

Rollup of 8 pull requests - Successful merges: #33793, #33893, #33912, #33913, #33914, #33917, #33937, #33938 - Failed merges:

bors · 2016-05-30T12:44:01Z

☔ The latest upstream changes (presumably #33959) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive assigned steveklabnik May 22, 2016

sophiajt reviewed May 23, 2016
View reviewed changes

GuillaumeGomez force-pushed the compile_fail branch from bbd5195 to 459da6fCompare May 24, 2016 09:43

GuillaumeGomez force-pushed the compile_fail branch from 459da6f to 44e9ae0Compare May 24, 2016 15:26

GuillaumeGomez force-pushed the compile_fail branch from 44e9ae0 to 7a5bf59Compare May 25, 2016 07:51

* Fix compile_fail tag (in some cases, it compiled whereas it wasn't …
abe9961
…expected to and was still considered 'ok') * Fix error explanations tests/tags

GuillaumeGomez force-pushed the compile_fail branch from 7a5bf59 to abe9961Compare May 27, 2016 07:51

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2016
Rollup merge ofrust-lang#33793- GuillaumeGomez:compile_fail, r=Guil…
8706e2a
…laumeGomez Fix compile_fail tag Fixesrust-lang#33780 r? @steveklabnik

GuillaumeGomez mentioned this pull request May 29, 2016
Rollup of 10 pull requests #33948
Closed

bors added a commit that referenced this pull request May 29, 2016
Auto merge of#33948- GuillaumeGomez:rollup, r=GuillaumeGomez
1d78a61
Rollup of 10 pull requests - Successful merges: #33793, #33893, #33902, #33912, #33913, #33914, #33917, #33931, #33937, #33938 - Failed merges:

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2016
Rollup merge ofrust-lang#33793- GuillaumeGomez:compile_fail, r=Guil…
cae6c75
…laumeGomez Fix compile_fail tag Fixesrust-lang#33780 r? @steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request May 30, 2016
Rollup merge ofrust-lang#33793- GuillaumeGomez:compile_fail, r=Guil…
10e1e6a
…laumeGomez Fix compile_fail tag Fixesrust-lang#33780 r? @steveklabnik

Manishearth mentioned this pull request May 30, 2016
Rollup of 8 pull requests #33959
Merged

bors added a commit that referenced this pull request May 30, 2016
Auto merge of#33959- Manishearth:rollup, r=Manishearth
5da602b
Rollup of 8 pull requests - Successful merges: #33793, #33893, #33912, #33913, #33914, #33917, #33937, #33938 - Failed merges:

bors merged commit abe9961 into rust-lang:masterMay 30, 2016

GuillaumeGomez deleted the compile_fail branch May 30, 2016 12:45

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented May 22, 2016

Uh oh!

sophiajtMay 23, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMay 23, 2016

Choose a reason for hiding this comment

Uh oh!

steveklabnik commented May 23, 2016

Uh oh!

sophiajtMay 23, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMay 23, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMay 24, 2016

Choose a reason for hiding this comment

Uh oh!

steveklabnikMay 24, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMay 24, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented May 23, 2016

Uh oh!

GuillaumeGomez commented May 24, 2016

Uh oh!

steveklabnik commented May 24, 2016

Uh oh!

bors commented May 24, 2016

Uh oh!

steveklabnik commented May 24, 2016

Uh oh!

bors commented May 25, 2016

Uh oh!

GuillaumeGomez commented May 25, 2016

Uh oh!

bors commented May 25, 2016

Uh oh!

bors commented May 26, 2016

Uh oh!

bors commented May 26, 2016

Uh oh!

GuillaumeGomez commented May 27, 2016

Uh oh!

steveklabnik commented May 27, 2016

Uh oh!

bors commented May 27, 2016

Uh oh!

bors commented May 29, 2016

Uh oh!

bors commented May 29, 2016

Uh oh!

GuillaumeGomez commented May 29, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented May 29, 2016

Uh oh!

bors commented May 29, 2016

Uh oh!

GuillaumeGomez commented May 29, 2016

Uh oh!

bors commented May 30, 2016

Uh oh!

bors commented May 30, 2016

Uh oh!

GuillaumeGomez commented May 30, 2016

Uh oh!

bors commented May 30, 2016

Uh oh!

bors commented May 30, 2016

Uh oh!

bors commented May 30, 2016

Uh oh!

Reviewers

GuillaumeGomez commented May 29, 2016•
edited
Loading